[GitHub] [hadoop] hadoop-yetus commented on pull request #5131: YARN-11350. [Federation] Router Support DelegationToken With ZK.

2022-12-10 Thread GitBox
hadoop-yetus commented on PR #5131: URL: https://github.com/apache/hadoop/pull/5131#issuecomment-1345449868 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5193: YARN-11374. [Federation] Support refreshSuperUserGroupsConfiguration、refreshUserToGroupsMappings API's for Federation.

2022-12-10 Thread GitBox
hadoop-yetus commented on PR #5193: URL: https://github.com/apache/hadoop/pull/5193#issuecomment-1345445421 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on pull request #5182: YARN-11385. Fix hadoop-yarn-server-common module Java Doc Errors.

2022-12-10 Thread GitBox
slfan1989 commented on PR #5182: URL: https://github.com/apache/hadoop/pull/5182#issuecomment-1345418464 @goiri Thank you very much for helping to review the code! @cnauroth Thank you for your suggestion! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] tomscut commented on a diff in pull request #5202: HDFS-16866. Fix a typo in Dispatcher

2022-12-10 Thread GitBox
tomscut commented on code in PR #5202: URL: https://github.com/apache/hadoop/pull/5202#discussion_r1045151090 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Dispatcher.java: ## @@ -164,7 +164,7 @@ synchronized int allocate(int n) {

[jira] [Commented] (HADOOP-18399) SingleFilePerBlockCache to use LocalDirAllocator for file allocatoin

2022-12-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645698#comment-17645698 ] ASF GitHub Bot commented on HADOOP-18399: - virajjasani commented on code in PR #5054: URL:

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5054: HADOOP-18399 Prefetch - SingleFilePerBlockCache to use LocalDirAllocator for file allocation

2022-12-10 Thread GitBox
virajjasani commented on code in PR #5054: URL: https://github.com/apache/hadoop/pull/5054#discussion_r1033141405 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3APrefetchingInputStream.java: ## @@ -294,4 +294,34 @@ public void

[GitHub] [hadoop] goiri commented on a diff in pull request #5195: HDFS-16856: Refactor RouterAdmin to use the AdminHelper class.

2022-12-10 Thread GitBox
goiri commented on code in PR #5195: URL: https://github.com/apache/hadoop/pull/5195#discussion_r1045147361 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/tools/federation/RouterAdmin.java: ## @@ -467,310 +293,265 @@ public int run(String[] argv)

[GitHub] [hadoop] goiri merged pull request #5182: YARN-11385. Fix hadoop-yarn-server-common module Java Doc Errors.

2022-12-10 Thread GitBox
goiri merged PR #5182: URL: https://github.com/apache/hadoop/pull/5182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] goiri commented on pull request #5182: YARN-11385. Fix hadoop-yarn-server-common module Java Doc Errors.

2022-12-10 Thread GitBox
goiri commented on PR #5182: URL: https://github.com/apache/hadoop/pull/5182#issuecomment-1345403787 The pending change from @cnauroth is solved. I'll override the vote and merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop] FahaoTang commented on pull request #4538: HDFS-16654. Link OpenSSL lib for CMake deps check

2022-12-10 Thread GitBox
FahaoTang commented on PR #4538: URL: https://github.com/apache/hadoop/pull/4538#issuecomment-1345397392 I think the existing check (not related to this PR) might be wrong: ``` check_c_source_compiles("#include \nint main(int argc, char **argv) { return !EVP_aes_256_ctr; }"

[jira] [Commented] (HADOOP-18329) Add support for IBM Semeru OE JRE 11.0.15.0 and greater

2022-12-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645629#comment-17645629 ] ASF GitHub Bot commented on HADOOP-18329: - steveloughran commented on PR #4537: URL:

[GitHub] [hadoop] steveloughran commented on pull request #4537: HADOOP-18329 - Support for IBM Semeru JVM v>11.0.15.0 Vendor Name Changes

2022-12-10 Thread GitBox
steveloughran commented on PR #4537: URL: https://github.com/apache/hadoop/pull/4537#issuecomment-1345277471 @JackBuggins merged to trunk, but it has merge conflicts into 3.3 with SSLFactory.java. can you do a quick review and PR there? I'm busy testing the abfs blockers

[jira] [Commented] (HADOOP-18329) Add support for IBM Semeru OE JRE 11.0.15.0 and greater

2022-12-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645626#comment-17645626 ] ASF GitHub Bot commented on HADOOP-18329: - steveloughran merged PR #4537: URL:

[GitHub] [hadoop] steveloughran merged pull request #4537: HADOOP-18329 - Support for IBM Semeru JVM v>11.0.15.0 Vendor Name Changes

2022-12-10 Thread GitBox
steveloughran merged PR #4537: URL: https://github.com/apache/hadoop/pull/4537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] steveloughran commented on a diff in pull request #4537: HADOOP-18329 - Support for IBM Semeru JVM v>11.0.15.0 Vendor Name Changes

2022-12-10 Thread GitBox
steveloughran commented on code in PR #4537: URL: https://github.com/apache/hadoop/pull/4537#discussion_r1045091286 ## hadoop-common-project/hadoop-minikdc/src/test/java/org/apache/hadoop/minikdc/TestMiniKdc.java: ## @@ -38,8 +38,35 @@ import java.util.Arrays; public class

[jira] [Commented] (HADOOP-18329) Add support for IBM Semeru OE JRE 11.0.15.0 and greater

2022-12-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645622#comment-17645622 ] ASF GitHub Bot commented on HADOOP-18329: - steveloughran commented on code in PR #4537: URL:

[jira] [Comment Edited] (HADOOP-18566) Set Cache-Control no-store max-age as 0 header on all dynamic content

2022-12-10 Thread Brahma Reddy Battula (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645577#comment-17645577 ] Brahma Reddy Battula edited comment on HADOOP-18566 at 12/10/22 10:52 AM:

[jira] [Commented] (HADOOP-18566) Set Cache-Control no-store max-age as 0 header on all dynamic content

2022-12-10 Thread Brahma Reddy Battula (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645577#comment-17645577 ] Brahma Reddy Battula commented on HADOOP-18566: --- I think, it's good to have as per

[jira] [Created] (HADOOP-18566) Set Cache-Control no-store max-age as 0 header on all dynamic content

2022-12-10 Thread Bilwa S T (Jira)
Bilwa S T created HADOOP-18566: -- Summary: Set Cache-Control no-store max-age as 0 header on all dynamic content Key: HADOOP-18566 URL: https://issues.apache.org/jira/browse/HADOOP-18566 Project: Hadoop

[GitHub] [hadoop] hadoop-yetus commented on pull request #5169: YARN-11349. [Federation] Router Support DelegationToken With SQL.

2022-12-10 Thread GitBox
hadoop-yetus commented on PR #5169: URL: https://github.com/apache/hadoop/pull/5169#issuecomment-1345203583 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |