[jira] [Commented] (HADOOP-18613) Upgrade ZooKeeper to version 3.8.1

2023-11-21 Thread Bilwa S T (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788644#comment-17788644 ] Bilwa S T commented on HADOOP-18613: Hi [~szucsvillo] Are you planning to work on this issue? If

[jira] [Updated] (HADOOP-18986) Upgrade Zookeeper to 3.8.2

2023-11-21 Thread Bilwa S T (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilwa S T updated HADOOP-18986: --- Component/s: build Fix Version/s: 3.4.0 Affects Version/s: 3.3.6 > Upgrade

Re: [PR] HDFS-17250. EditLogTailer#triggerActiveLogRoll should handle thread Interrupted [hadoop]

2023-11-21 Thread via GitHub
xinglin commented on PR #6266: URL: https://github.com/apache/hadoop/pull/6266#issuecomment-1822167954 Feel free to commit this PR. did not intend to block here. I will spend more time on my own trying to understand the code/and the change . -- This is an automated message from the

Re: [PR] Hadoop 18860: Upgrade mockito version to 4.11.0 [hadoop]

2023-11-21 Thread via GitHub
hadoop-yetus commented on PR #6275: URL: https://github.com/apache/hadoop/pull/6275#issuecomment-1822155782 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17262 Fixed the verbose log.warn in DFSUtil.addTransferRateMetric(). [hadoop]

2023-11-21 Thread via GitHub
hadoop-yetus commented on PR #6290: URL: https://github.com/apache/hadoop/pull/6290#issuecomment-1822112726 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17223. Add journalnode maintenance node list [hadoop]

2023-11-21 Thread via GitHub
gp1314 commented on PR #6183: URL: https://github.com/apache/hadoop/pull/6183#issuecomment-1821996456 @xinglin , thank you very much for code review and suggestions, I will pay attention next time. -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (HADOOP-18967) Allow secure mode to be enabled with no downtime

2023-11-21 Thread Charles Connell (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788602#comment-17788602 ] Charles Connell commented on HADOOP-18967: -- This is HDFS only. I don't believe I have

Re: [PR] HDFS-17223. Add journalnode maintenance node list [hadoop]

2023-11-21 Thread via GitHub
xinglin commented on PR #6183: URL: https://github.com/apache/hadoop/pull/6183#issuecomment-1821934677 @gp1314, can you try not force-push next time? Just push incremental commits so that I can review the new change. thanks, -- This is an automated message from the Apache Git Service. To

[PR] HDFS-17262 Fixed the verbose log.warn in DFSUtil.addTransferRateMetric(). [hadoop]

2023-11-21 Thread via GitHub
xinglin opened a new pull request, #6290: URL: https://github.com/apache/hadoop/pull/6290 ### Description of PR Fixed the verbose log.warn in DFSUtil.addTransferRateMetric(). Contributed by Ravindra Dingankar . ### How was this patch tested? ``` $

Re: [PR] YARN-11616. Fast fail for NodeConstraintParser when having multi attribute kvs [hadoop]

2023-11-21 Thread via GitHub
slfan1989 commented on PR #6282: URL: https://github.com/apache/hadoop/pull/6282#issuecomment-1821877401 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] YARN-11620. [Federation] Improve FederationClientInterceptor To Return Partial Results of subClusters. [hadoop]

2023-11-21 Thread via GitHub
hadoop-yetus commented on PR #6289: URL: https://github.com/apache/hadoop/pull/6289#issuecomment-1821574777 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-16917 Add transfer rate quantile metrics for DataNode reads [hadoop]

2023-11-21 Thread via GitHub
bbeaudreault commented on PR #5397: URL: https://github.com/apache/hadoop/pull/5397#issuecomment-1821458290 I agree this is way too verbose. I created https://issues.apache.org/jira/browse/HDFS-17262 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] YARN-11485. [Federation] Router Supports Yarn Admin CLI Cmds. [hadoop]

2023-11-21 Thread via GitHub
hadoop-yetus commented on PR #6265: URL: https://github.com/apache/hadoop/pull/6265#issuecomment-1821451653 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11614. [Federation] Add Federation PolicyManager Validation Rules. [hadoop]

2023-11-21 Thread via GitHub
hadoop-yetus commented on PR #6271: URL: https://github.com/apache/hadoop/pull/6271#issuecomment-1821396941 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17223. Add journalnode maintenance node list [hadoop]

2023-11-21 Thread via GitHub
hadoop-yetus commented on PR #6183: URL: https://github.com/apache/hadoop/pull/6183#issuecomment-1821360101 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[PR] YARN-11620. [Federation] Improve FederationClientInterceptor To Return Partial Results of subClusters. [hadoop]

2023-11-21 Thread via GitHub
slfan1989 opened a new pull request, #6289: URL: https://github.com/apache/hadoop/pull/6289 ### Description of PR JIRA: YARN-11620. [Federation] Improve FederationClientInterceptor To Return Partial Results of subClusters. ### How was this patch tested? Add

Re: [PR] YARN-11614. [Federation] Add Federation PolicyManager Validation Rules. [hadoop]

2023-11-21 Thread via GitHub
hadoop-yetus commented on PR #6271: URL: https://github.com/apache/hadoop/pull/6271#issuecomment-1821345107 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11485. [Federation] Router Supports Yarn Admin CLI Cmds. [hadoop]

2023-11-21 Thread via GitHub
slfan1989 commented on code in PR #6265: URL: https://github.com/apache/hadoop/pull/6265#discussion_r1400818911 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java: ## @@ -1099,4 +1099,27 @@ public void

Re: [PR] YARN-11420 Stabilize TestNMClient [hadoop]

2023-11-21 Thread via GitHub
tomicooler commented on code in PR #5317: URL: https://github.com/apache/hadoop/pull/5317#discussion_r1400750174 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java: ## @@ -456,6 +456,19

[jira] [Resolved] (HADOOP-18969) S3A: AbstractS3ACostTest to clear bucket fs.s3a.create.performance flag

2023-11-21 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-18969. - Fix Version/s: 3.4.0 Resolution: Fixed > S3A: AbstractS3ACostTest to clear

[jira] [Commented] (HADOOP-18969) S3A: AbstractS3ACostTest to clear bucket fs.s3a.create.performance flag

2023-11-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788441#comment-17788441 ] ASF GitHub Bot commented on HADOOP-18969: - steveloughran merged PR #6264: URL:

Re: [PR] HADOOP-18969. S3A: AbstractS3ACostTest to clear bucket fs.s3a.create.performance [hadoop]

2023-11-21 Thread via GitHub
steveloughran merged PR #6264: URL: https://github.com/apache/hadoop/pull/6264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HDFS-17261. Fix getFileInfo return wrong path when get mountTable path which is multi-level [hadoop]

2023-11-21 Thread via GitHub
hadoop-yetus commented on PR #6288: URL: https://github.com/apache/hadoop/pull/6288#issuecomment-1821080080 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Created] (HADOOP-18986) Upgrade Zookeeper to 3.8.2

2023-11-21 Thread Bilwa S T (Jira)
Bilwa S T created HADOOP-18986: -- Summary: Upgrade Zookeeper to 3.8.2 Key: HADOOP-18986 URL: https://issues.apache.org/jira/browse/HADOOP-18986 Project: Hadoop Common Issue Type: Improvement

Re: [PR] HDFS-17233. The conf dfs.datanode.lifeline.interval.seconds is not co… [hadoop]

2023-11-21 Thread via GitHub
hadoop-yetus commented on PR #6286: URL: https://github.com/apache/hadoop/pull/6286#issuecomment-1820940621 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-18971: [ABFS] Enable Footer Read Optimizations with Appropriate Footer Read Buffer Size [hadoop]

2023-11-21 Thread via GitHub
hadoop-yetus commented on PR #6270: URL: https://github.com/apache/hadoop/pull/6270#issuecomment-1820864034 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18971) ABFS: Enable Footer Read Optimizations with Appropriate Footer Read Buffer Size

2023-11-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788408#comment-17788408 ] ASF GitHub Bot commented on HADOOP-18971: - hadoop-yetus commented on PR #6270: URL:

[jira] [Commented] (HADOOP-18984) S3A: Support dynamic region resolution

2023-11-21 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788407#comment-17788407 ] Steve Loughran commented on HADOOP-18984: - fyi, cloudstore now has a regions2 command to work

[PR] HDFS-17261. Fix getFileInfo return wrong path when get mountTable path which is multi-level [hadoop]

2023-11-21 Thread via GitHub
LiuGuH opened a new pull request, #6288: URL: https://github.com/apache/hadoop/pull/6288 …i-level dirs ### Description of PR With DFSRouter, Suppose there are two nameservices : ns0,ns1 Add mountTable /testgetfileinfo/ns1/dir -> (ns1 ->

Re: [PR] YARN-11420 Stabilize TestNMClient [hadoop]

2023-11-21 Thread via GitHub
hadoop-yetus commented on PR #5317: URL: https://github.com/apache/hadoop/pull/5317#issuecomment-1820804877 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] Hadoop 18860: Upgrade mockito version to 4.11.0 [hadoop]

2023-11-21 Thread via GitHub
hadoop-yetus commented on PR #6275: URL: https://github.com/apache/hadoop/pull/6275#issuecomment-1820696613 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-18971: [ABFS] Enable Footer Read Optimizations with Appropriate Footer Read Buffer Size [hadoop]

2023-11-21 Thread via GitHub
anujmodi2021 commented on code in PR #6270: URL: https://github.com/apache/hadoop/pull/6270#discussion_r1400365675 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/FileSystemConfigurations.java: ## @@ -59,7 +59,8 @@ public final class

Re: [PR] [ABFS][CST Optimization] Enhancing Client-Side Metrics Updating Logic [hadoop]

2023-11-21 Thread via GitHub
saxenapranav commented on code in PR #6276: URL: https://github.com/apache/hadoop/pull/6276#discussion_r1400364012 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsRestOperation.java: ## @@ -337,32 +356,31 @@ private boolean

Re: [PR] [ABFS][CST Optimization] Enhancing Client-Side Metrics Updating Logic [hadoop]

2023-11-21 Thread via GitHub
saxenapranav commented on code in PR #6276: URL: https://github.com/apache/hadoop/pull/6276#discussion_r1400364012 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsRestOperation.java: ## @@ -337,32 +356,31 @@ private boolean

[jira] [Commented] (HADOOP-17767) ABFS: Improve test scripts

2023-11-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788356#comment-17788356 ] ASF GitHub Bot commented on HADOOP-17767: - hadoop-yetus commented on PR #6287: URL:

Re: [PR] HADOOP-18971: [ABFS] Enable Footer Read Optimizations with Appropriate Footer Read Buffer Size [hadoop]

2023-11-21 Thread via GitHub
anujmodi2021 commented on code in PR #6270: URL: https://github.com/apache/hadoop/pull/6270#discussion_r1400358992 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/ConfigurationKeys.java: ## @@ -104,7 +104,20 @@ public final class

Re: [PR] HADOOP-17767: [Backport to 3.3] [ABFS] Update test scripts (#3124) [hadoop]

2023-11-21 Thread via GitHub
hadoop-yetus commented on PR #6287: URL: https://github.com/apache/hadoop/pull/6287#issuecomment-1820642527 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17223. Add journalnode maintenance node list [hadoop]

2023-11-21 Thread via GitHub
hadoop-yetus commented on PR #6183: URL: https://github.com/apache/hadoop/pull/6183#issuecomment-1820590066 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-18971: [ABFS] Enable Footer Read Optimizations with Appropriate Footer Read Buffer Size [hadoop]

2023-11-21 Thread via GitHub
anujmodi2021 commented on code in PR #6270: URL: https://github.com/apache/hadoop/pull/6270#discussion_r1400245348 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStream.java: ## @@ -812,6 +814,11 @@ public int getBufferSize() {

[jira] [Commented] (HADOOP-17767) ABFS: Improve test scripts

2023-11-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788324#comment-17788324 ] ASF GitHub Bot commented on HADOOP-17767: - anujmodi2021 opened a new pull request, #6287: URL:

[PR] HADOOP-17767. ABFS: Update test scripts (#3124) [hadoop]

2023-11-21 Thread via GitHub
anujmodi2021 opened a new pull request, #6287: URL: https://github.com/apache/hadoop/pull/6287 Jira Ticket: https://issues.apache.org/jira/browse/HADOOP-17767 Trunk PR: https://github.com/apache/hadoop/pull/3124 Cherry-picked Commit:

Re: [PR] YARN-11420 Stabilize TestNMClient [hadoop]

2023-11-21 Thread via GitHub
susheel-gupta commented on code in PR #5317: URL: https://github.com/apache/hadoop/pull/5317#discussion_r1400212988 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestNMClient.java: ## @@ -125,576 +117,344 @@ public

Re: [PR] YARN-11420 Stabilize TestNMClient [hadoop]

2023-11-21 Thread via GitHub
susheel-gupta commented on code in PR #5317: URL: https://github.com/apache/hadoop/pull/5317#discussion_r1400210934 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestNMClient.java: ## @@ -125,576 +117,344 @@ public

Re: [PR] YARN-11420 Stabilize TestNMClient [hadoop]

2023-11-21 Thread via GitHub
susheel-gupta commented on code in PR #5317: URL: https://github.com/apache/hadoop/pull/5317#discussion_r1400208697 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestNMClient.java: ## @@ -60,53 +55,50 @@ import