[jira] [Commented] (HADOOP-19154) upgrade bouncy castle to 1.78.1 due to CVEs

2024-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839943#comment-17839943 ] ASF GitHub Bot commented on HADOOP-19154: - hadoop-yetus commented on PR #6755: URL:

Re: [PR] HADOOP-19154. Upgrade bouncycastle to 1.78.1 due to CVEs [hadoop]

2024-04-22 Thread via GitHub
hadoop-yetus commented on PR #6755: URL: https://github.com/apache/hadoop/pull/6755#issuecomment-2071444504 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

[jira] [Commented] (HADOOP-19146) noaa-cors-pds bucket access with global endpoint fails

2024-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839940#comment-17839940 ] ASF GitHub Bot commented on HADOOP-19146: - virajjasani commented on PR #6723: URL:

Re: [PR] HADOOP-19146 noaa-cors-pds bucket access with global endpoint fails [hadoop]

2024-04-22 Thread via GitHub
virajjasani commented on PR #6723: URL: https://github.com/apache/hadoop/pull/6723#issuecomment-2071433640 Re-ran the whole suite with `scale` and `prefetch` profiles one more time against `us-west-2` -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (HADOOP-19146) noaa-cors-pds bucket access with global endpoint fails

2024-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839938#comment-17839938 ] ASF GitHub Bot commented on HADOOP-19146: - virajjasani commented on code in PR #6723: URL:

Re: [PR] HADOOP-19146 noaa-cors-pds bucket access with global endpoint fails [hadoop]

2024-04-22 Thread via GitHub
virajjasani commented on code in PR #6723: URL: https://github.com/apache/hadoop/pull/6723#discussion_r1575652737 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/ITestS3AInputStreamPerformance.java: ## @@ -99,9 +100,12 @@ public class

Re: [PR] YARN-11674. Add CPUResourceHandler for cgroup v2. [hadoop]

2024-04-22 Thread via GitHub
hadoop-yetus commented on PR #6751: URL: https://github.com/apache/hadoop/pull/6751#issuecomment-2071402893 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

[jira] [Commented] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839930#comment-17839930 ] ASF GitHub Bot commented on HADOOP-19102: - saxenapranav opened a new pull request, #6763: URL:

[PR] HADOOP-19102. FooterReadBufferSize should not be greater than readBufferSize [hadoop]

2024-04-22 Thread via GitHub
saxenapranav opened a new pull request, #6763: URL: https://github.com/apache/hadoop/pull/6763 JIRA: https://issues.apache.org/jira/browse/HADOOP-19102 PR on trunk: https://github.com/apache/hadoop/pull/6617 Merged commit on trunk:

Re: [PR] HDFS-17488. DN can fail IBRs with NPE when a volume is removed [hadoop]

2024-04-22 Thread via GitHub
hadoop-yetus commented on PR #6759: URL: https://github.com/apache/hadoop/pull/6759#issuecomment-2071375244 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] YARN-11675. Update MemoryResourceHandler implementation for cgroup v2 support [hadoop]

2024-04-22 Thread via GitHub
hadoop-yetus commented on PR #6760: URL: https://github.com/apache/hadoop/pull/6760#issuecomment-2071323869 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17484. Introduce redundancy.considerLoad.minLoad to avoiding excluding nodes when they are not busy actually. [hadoop]

2024-04-22 Thread via GitHub
hfutatzhanghb commented on PR #6758: URL: https://github.com/apache/hadoop/pull/6758#issuecomment-2071305686 @Hexiaoqiao @zhangshuyan0 @haiyang1987 @tomscut Sir, could you please help me review this PR when you have free time? Thanks ahead. -- This is an automated message from the Apache

[PR] HDFS-17384. [FGL] Replace the global lock with global FS Lock and global BM lock [hadoop]

2024-04-22 Thread via GitHub
ZanderXu opened a new pull request, #6762: URL: https://github.com/apache/hadoop/pull/6762 We plan to merge HDFS-17384 to the trunk branch. This PR is used to review all changes in HDFS-17384. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] HADOOP-19150: [ABFS] Fixing Test Code for ITestAbfsRestOperationException#testAuthFailException [hadoop]

2024-04-22 Thread via GitHub
hadoop-yetus commented on PR #6756: URL: https://github.com/apache/hadoop/pull/6756#issuecomment-2071258797 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

[jira] [Commented] (HADOOP-19150) Test ITestAbfsRestOperationException#testAuthFailException is broken.

2024-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839912#comment-17839912 ] ASF GitHub Bot commented on HADOOP-19150: - hadoop-yetus commented on PR #6756: URL:

Re: [PR] HDFS-17484. Introduce redundancy.considerLoad.minLoad to avoiding excluding nodes when they are not busy actually. [hadoop]

2024-04-22 Thread via GitHub
hadoop-yetus commented on PR #6758: URL: https://github.com/apache/hadoop/pull/6758#issuecomment-2071256591 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17457. [FGL] UTs support fine-grained locking [hadoop]

2024-04-22 Thread via GitHub
ferhui commented on PR #6741: URL: https://github.com/apache/hadoop/pull/6741#issuecomment-2071256036 @ZanderXu Thanks for contribution. @kokonguyen191 Thanks for review. Merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] HDFS-17457. [FGL] UTs support fine-grained locking [hadoop]

2024-04-22 Thread via GitHub
ferhui merged PR #6741: URL: https://github.com/apache/hadoop/pull/6741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] [DRAFT] Jackson 2.14 [hadoop]

2024-04-22 Thread via GitHub
pjfanning opened a new pull request, #6761: URL: https://github.com/apache/hadoop/pull/6761 ### Description of PR WIP. Aim is to upgrade to Jackson 2.14. The jsr311-compat jar has the missing class that caues Jackson JAX-RS code post Jackson 2.13 not to work with jersey 1.x.

Re: [PR] YARN-11672. Create a CgroupHandler implementation for cgroup v2 [hadoop]

2024-04-22 Thread via GitHub
slfan1989 commented on code in PR #6734: URL: https://github.com/apache/hadoop/pull/6734#discussion_r1575492286 ##

Re: [PR] YARN-11684. Fix general contract violation in PriorityQueueComparator… [hadoop]

2024-04-22 Thread via GitHub
slfan1989 commented on PR #6754: URL: https://github.com/apache/hadoop/pull/6754#issuecomment-2071158121 @tomicooler Thanks for the contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] YARN-11684. Fix general contract violation in PriorityQueueComparator… [hadoop]

2024-04-22 Thread via GitHub
slfan1989 merged PR #6754: URL: https://github.com/apache/hadoop/pull/6754 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HADOOP-19136) Upgrade commons-io to 2.16.1

2024-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839895#comment-17839895 ] ASF GitHub Bot commented on HADOOP-19136: - slfan1989 commented on PR #6704: URL:

Re: [PR] HADOOP-19136. Upgrade commons-io to 2.16.1. [hadoop]

2024-04-22 Thread via GitHub
slfan1989 commented on PR #6704: URL: https://github.com/apache/hadoop/pull/6704#issuecomment-2071157196 @ayushtkn Can you help review this pr again? Thank you very much! The unit test error is not caused by upgrading the jar package version. -- This is an automated message from the

[jira] [Commented] (HADOOP-19136) Upgrade commons-io to 2.16.1

2024-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839893#comment-17839893 ] ASF GitHub Bot commented on HADOOP-19136: - hadoop-yetus commented on PR #6704: URL:

Re: [PR] HADOOP-19136. Upgrade commons-io to 2.16.1. [hadoop]

2024-04-22 Thread via GitHub
hadoop-yetus commented on PR #6704: URL: https://github.com/apache/hadoop/pull/6704#issuecomment-2071136552 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11191. Fix potentional deadlock in GlobalScheduler refreshQueues [hadoop]

2024-04-22 Thread via GitHub
slfan1989 commented on code in PR #6732: URL: https://github.com/apache/hadoop/pull/6732#discussion_r1575454919 ##

Re: [PR] YARN-11674. Add CPUResourceHandler for cgroup v2. [hadoop]

2024-04-22 Thread via GitHub
hadoop-yetus commented on PR #6751: URL: https://github.com/apache/hadoop/pull/6751#issuecomment-2070385835 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839800#comment-17839800 ] ASF GitHub Bot commented on HADOOP-19102: - steveloughran merged PR #6617: URL:

Re: [PR] HADOOP-19102. FooterReadBufferSize should not be greater than readBufferSize [hadoop]

2024-04-22 Thread via GitHub
steveloughran merged PR #6617: URL: https://github.com/apache/hadoop/pull/6617 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (HADOOP-18325) ABFS: Add correlated metric support for ABFS operations

2024-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18325: Labels: pull-request-available (was: ) > ABFS: Add correlated metric support for ABFS

Re: [PR] HDFS-17457. [FGL] UTs support fine-grained locking [hadoop]

2024-04-22 Thread via GitHub
hadoop-yetus commented on PR #6741: URL: https://github.com/apache/hadoop/pull/6741#issuecomment-2070306218 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11675. Update MemoryResourceHandler implementation for cgroup v2 support [hadoop]

2024-04-22 Thread via GitHub
hadoop-yetus commented on PR #6760: URL: https://github.com/apache/hadoop/pull/6760#issuecomment-2070193014 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18656) ABFS: Support for Pagination in Recursive Directory Delete

2024-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839783#comment-17839783 ] ASF GitHub Bot commented on HADOOP-18656: - mukund-thakur merged PR #6718: URL:

Re: [PR] HADOOP-18656: [Backport to 3.4] [ABFS] Adding Support for Paginated Delete for Large Directories in HNS Account [hadoop]

2024-04-22 Thread via GitHub
mukund-thakur merged PR #6718: URL: https://github.com/apache/hadoop/pull/6718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] YARN-11672. Create a CgroupHandler implementation for cgroup v2 [hadoop]

2024-04-22 Thread via GitHub
hadoop-yetus commented on PR #6734: URL: https://github.com/apache/hadoop/pull/6734#issuecomment-2070127772 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19107) Drop support for HBase v1

2024-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839774#comment-17839774 ] ASF GitHub Bot commented on HADOOP-19107: - ayushtkn merged PR #6629: URL:

Re: [PR] HADOOP-19107. Drop support for HBase v1 & upgrade HBase v2 [hadoop]

2024-04-22 Thread via GitHub
ayushtkn merged PR #6629: URL: https://github.com/apache/hadoop/pull/6629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] YARN-11672. Create a CgroupHandler implementation for cgroup v2 [hadoop]

2024-04-22 Thread via GitHub
hadoop-yetus commented on PR #6734: URL: https://github.com/apache/hadoop/pull/6734#issuecomment-2070076468 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11672. Create a CgroupHandler implementation for cgroup v2 [hadoop]

2024-04-22 Thread via GitHub
hadoop-yetus commented on PR #6734: URL: https://github.com/apache/hadoop/pull/6734#issuecomment-2070031217 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11672. Create a CgroupHandler implementation for cgroup v2 [hadoop]

2024-04-22 Thread via GitHub
hadoop-yetus commented on PR #6734: URL: https://github.com/apache/hadoop/pull/6734#issuecomment-2070035840 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19152. Do not hard code security providers. [hadoop]

2024-04-22 Thread via GitHub
szetszwo commented on PR #6739: URL: https://github.com/apache/hadoop/pull/6739#issuecomment-2069920257 Let's do Alternative Approach 2 then. We could as welll add another conf to disable the existing hardcoded provider. -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (HADOOP-19152) Do not hard code security providers.

2024-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839746#comment-17839746 ] ASF GitHub Bot commented on HADOOP-19152: - steveloughran commented on PR #6739: URL:

Re: [PR] HADOOP-19152. Do not hard code security providers. [hadoop]

2024-04-22 Thread via GitHub
steveloughran commented on PR #6739: URL: https://github.com/apache/hadoop/pull/6739#issuecomment-2069888269 yeah, looks incompatible. I'd rather it supports switching, but the existing BC jar ships and everything works -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (HADOOP-19146) noaa-cors-pds bucket access with global endpoint fails

2024-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839737#comment-17839737 ] ASF GitHub Bot commented on HADOOP-19146: - steveloughran commented on code in PR #6723: URL:

Re: [PR] HADOOP-19102. FooterReadBufferSize should not be greater than readBufferSize [hadoop]

2024-04-22 Thread via GitHub
hadoop-yetus commented on PR #6617: URL: https://github.com/apache/hadoop/pull/6617#issuecomment-2069841215 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-19146 noaa-cors-pds bucket access with global endpoint fails [hadoop]

2024-04-22 Thread via GitHub
steveloughran commented on code in PR #6723: URL: https://github.com/apache/hadoop/pull/6723#discussion_r1574937338 ## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/ITestS3AInputStreamPerformance.java: ## @@ -99,9 +100,12 @@ public class

[jira] [Commented] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839736#comment-17839736 ] ASF GitHub Bot commented on HADOOP-19102: - hadoop-yetus commented on PR #6617: URL:

Re: [PR] HDFS-17484. Introduce redundancy.considerLoad.minLoad to avoiding excluding nodes when they are not busy actually. [hadoop]

2024-04-22 Thread via GitHub
hadoop-yetus commented on PR #6758: URL: https://github.com/apache/hadoop/pull/6758#issuecomment-2069821953 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11672. Create a CgroupHandler implementation for cgroup v2 [hadoop]

2024-04-22 Thread via GitHub
brumi1024 commented on code in PR #6734: URL: https://github.com/apache/hadoop/pull/6734#discussion_r1574902377 ##

[PR] YARN-11675. Update MemoryResourceHandler implementation for cgroup v2 support [hadoop]

2024-04-22 Thread via GitHub
p-szucs opened a new pull request, #6760: URL: https://github.com/apache/hadoop/pull/6760 ### Description of PR Cgroup v2 has some changes in various controllers (some changed their functionality, some were removed). This task is about checking if MemoryResourceHandler's

Re: [PR] HDFS-17488. DN can fail IBRs with NPE when a volume is removed [hadoop]

2024-04-22 Thread via GitHub
hadoop-yetus commented on PR #6759: URL: https://github.com/apache/hadoop/pull/6759#issuecomment-2069730206 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19139) [ABFS]: No GetPathStatus call for opening AbfsInputStream

2024-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839720#comment-17839720 ] ASF GitHub Bot commented on HADOOP-19139: - hadoop-yetus commented on PR #6699: URL:

Re: [PR] HADOOP-19139.No GetPathStatus for opening AbfsInputStream [hadoop]

2024-04-22 Thread via GitHub
hadoop-yetus commented on PR #6699: URL: https://github.com/apache/hadoop/pull/6699#issuecomment-2069703014 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19085) Compatibility Benchmark over HCFS Implementations

2024-04-22 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839704#comment-17839704 ] Steve Loughran commented on HADOOP-19085: - that's really interesting. abfs has full filesystem

Re: [PR] HDFS-17484. Introduce redundancy.considerLoad.minLoad to avoiding excluding nodes when they are not busy actually. [hadoop]

2024-04-22 Thread via GitHub
hadoop-yetus commented on PR #6758: URL: https://github.com/apache/hadoop/pull/6758#issuecomment-2069624972 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17484. Introduce redundancy.considerLoad.minLoad to avoiding excluding nodes when they are not busy actually. [hadoop]

2024-04-22 Thread via GitHub
hadoop-yetus commented on PR #6758: URL: https://github.com/apache/hadoop/pull/6758#issuecomment-2069616190 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11672. Create a CgroupHandler implementation for cgroup v2 [hadoop]

2024-04-22 Thread via GitHub
brumi1024 commented on code in PR #6734: URL: https://github.com/apache/hadoop/pull/6734#discussion_r1574743317 ##

Re: [PR] YARN-11672. Create a CgroupHandler implementation for cgroup v2 [hadoop]

2024-04-22 Thread via GitHub
brumi1024 commented on code in PR #6734: URL: https://github.com/apache/hadoop/pull/6734#discussion_r1574743251 ##

Re: [PR] YARN-11672. Create a CgroupHandler implementation for cgroup v2 [hadoop]

2024-04-22 Thread via GitHub
tomicooler commented on code in PR #6734: URL: https://github.com/apache/hadoop/pull/6734#discussion_r1574695897 ##

Re: [PR] YARN-11672. Create a CgroupHandler implementation for cgroup v2 [hadoop]

2024-04-22 Thread via GitHub
tomicooler commented on code in PR #6734: URL: https://github.com/apache/hadoop/pull/6734#discussion_r1574695343 ##

Re: [PR] YARN-11672. Create a CgroupHandler implementation for cgroup v2 [hadoop]

2024-04-22 Thread via GitHub
hadoop-yetus commented on PR #6734: URL: https://github.com/apache/hadoop/pull/6734#issuecomment-2069237515 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11672. Create a CgroupHandler implementation for cgroup v2 [hadoop]

2024-04-22 Thread via GitHub
hadoop-yetus commented on PR #6734: URL: https://github.com/apache/hadoop/pull/6734#issuecomment-2069237005 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11672. Create a CgroupHandler implementation for cgroup v2 [hadoop]

2024-04-22 Thread via GitHub
tomicooler commented on code in PR #6734: URL: https://github.com/apache/hadoop/pull/6734#discussion_r1574578983 ##

Re: [PR] HDFS-17451. RBF: fix spotbugs for redundant nullcheck of dns. [hadoop]

2024-04-22 Thread via GitHub
ZanderXu commented on PR #6697: URL: https://github.com/apache/hadoop/pull/6697#issuecomment-2069092826 As I described in HDFS-17485, this spotbug should be fixed. If there is no input type DNs, `dnCache` will return an empty result, not null. So I thinks this modification is ok.

Re: [PR] HDFS-17485. Remove redundant nullcheck in RouterRpcServer.java [hadoop]

2024-04-22 Thread via GitHub
ZanderXu closed pull request #6757: HDFS-17485. Remove redundant nullcheck in RouterRpcServer.java URL: https://github.com/apache/hadoop/pull/6757 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] HDFS-17485. Remove redundant nullcheck in RouterRpcServer.java [hadoop]

2024-04-22 Thread via GitHub
hadoop-yetus commented on PR #6757: URL: https://github.com/apache/hadoop/pull/6757#issuecomment-2069029513 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19102) [ABFS]: FooterReadBufferSize should not be greater than readBufferSize

2024-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839595#comment-17839595 ] ASF GitHub Bot commented on HADOOP-19102: - saxenapranav commented on PR #6617: URL:

Re: [PR] HADOOP-19102. FooterReadBufferSize should not be greater than readBufferSize [hadoop]

2024-04-22 Thread via GitHub
saxenapranav commented on PR #6617: URL: https://github.com/apache/hadoop/pull/6617#issuecomment-2069027408 Thanks @steveloughran for the review. Have refactored the import order, and have refactored `log.error` to `log.debug`. -- This is an automated message from the Apache Git Service.

Re: [PR] YARN-11672. Create a CgroupHandler implementation for cgroup v2 [hadoop]

2024-04-22 Thread via GitHub
tomicooler commented on code in PR #6734: URL: https://github.com/apache/hadoop/pull/6734#discussion_r1574502560 ##

Re: [PR] HADOOP-19139.No GetPathStatus for opening AbfsInputStream [hadoop]

2024-04-22 Thread via GitHub
hadoop-yetus commented on PR #6699: URL: https://github.com/apache/hadoop/pull/6699#issuecomment-2068985224 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19139) [ABFS]: No GetPathStatus call for opening AbfsInputStream

2024-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839589#comment-17839589 ] ASF GitHub Bot commented on HADOOP-19139: - hadoop-yetus commented on PR #6699: URL:

Re: [PR] HDFS-17457. [FGL] UTs support fine-grained locking [hadoop]

2024-04-22 Thread via GitHub
kokonguyen191 commented on code in PR #6741: URL: https://github.com/apache/hadoop/pull/6741#discussion_r1574451782 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestListOpenFiles.java: ## @@ -48,6 +48,7 @@ import

Re: [PR] YARN-11686. Correct traversing indexs when scheduling asynchronously using Capacity Scheduler [hadoop]

2024-04-22 Thread via GitHub
onebox-li commented on PR #6750: URL: https://github.com/apache/hadoop/pull/6750#issuecomment-2068907134 Gentle ping @slfan1989 @zhuqi-lucas. PTAL if you have time, thanks. I think it's a minor list index change, there could be no need to introduce a new test. -- This is an automated

[jira] [Commented] (HADOOP-19137) [ABFS]:Extra getAcl call while calling the very first API of FileSystem

2024-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839569#comment-17839569 ] ASF GitHub Bot commented on HADOOP-19137: - hadoop-yetus commented on PR #6752: URL:

Re: [PR] HADOOP-19137. [ABFS]Fail fs init if cpk config is given on non-hns account [hadoop]

2024-04-22 Thread via GitHub
hadoop-yetus commented on PR #6752: URL: https://github.com/apache/hadoop/pull/6752#issuecomment-2068873028 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19150) Test ITestAbfsRestOperationException#testAuthFailException is broken.

2024-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839568#comment-17839568 ] ASF GitHub Bot commented on HADOOP-19150: - hadoop-yetus commented on PR #6756: URL:

Re: [PR] HADOOP-19150: [ABFS] Fixing Test Code for ITestAbfsRestOperationException#testAuthFailException [hadoop]

2024-04-22 Thread via GitHub
hadoop-yetus commented on PR #6756: URL: https://github.com/apache/hadoop/pull/6756#issuecomment-2068867717 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11672. Create a CgroupHandler implementation for cgroup v2 [hadoop]

2024-04-22 Thread via GitHub
brumi1024 commented on code in PR #6734: URL: https://github.com/apache/hadoop/pull/6734#discussion_r1574392520 ##

[jira] [Commented] (HADOOP-19139) [ABFS]: No GetPathStatus call for opening AbfsInputStream

2024-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839562#comment-17839562 ] ASF GitHub Bot commented on HADOOP-19139: - saxenapranav commented on code in PR #6699: URL:

Re: [PR] HADOOP-19139.No GetPathStatus for opening AbfsInputStream [hadoop]

2024-04-22 Thread via GitHub
saxenapranav commented on code in PR #6699: URL: https://github.com/apache/hadoop/pull/6699#discussion_r1574388064 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemAuthorization.java: ## @@ -327,7 +328,15 @@ private void

Re: [PR] HADOOP-19137. Fail fs init if cpk config is given on non-hns account [hadoop]

2024-04-22 Thread via GitHub
saxenapranav commented on PR #6752: URL: https://github.com/apache/hadoop/pull/6752#issuecomment-2068824940 -- AGGREGATED TEST RESULT HNS-OAuth

[jira] [Commented] (HADOOP-19137) [ABFS]:Extra getAcl call while calling the very first API of FileSystem

2024-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839554#comment-17839554 ] ASF GitHub Bot commented on HADOOP-19137: - saxenapranav commented on PR #6752: URL:

[jira] [Commented] (HADOOP-19137) [ABFS]:Extra getAcl call while calling the very first API of FileSystem

2024-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839552#comment-17839552 ] ASF GitHub Bot commented on HADOOP-19137: - saxenapranav commented on PR #6752: URL:

Re: [PR] HADOOP-19137. Fail fs init if cpk config is given on non-hns account [hadoop]

2024-04-22 Thread via GitHub
saxenapranav commented on PR #6752: URL: https://github.com/apache/hadoop/pull/6752#issuecomment-2068816077 -- AGGREGATED TEST RESULT HNS-OAuth

[PR] HDFS-17488. DN can fail IBRs with NPE when a volume is removed [hadoop]

2024-04-22 Thread via GitHub
kokonguyen191 opened a new pull request, #6759: URL: https://github.com/apache/hadoop/pull/6759 ### Description of PR Error logs ``` 2024-04-22 15:46:33,422 [BP-1842952724-10.22.68.249-1713771988830 heartbeating to localhost/127.0.0.1:64977] ERROR datanode.DataNode

[jira] [Commented] (HADOOP-19150) Test ITestAbfsRestOperationException#testAuthFailException is broken.

2024-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839530#comment-17839530 ] ASF GitHub Bot commented on HADOOP-19150: - hadoop-yetus commented on PR #6756: URL:

Re: [PR] HADOOP-19150: [ABFS] Fixing Test Code for ITestAbfsRestOperationException#testAuthFailException [hadoop]

2024-04-22 Thread via GitHub
hadoop-yetus commented on PR #6756: URL: https://github.com/apache/hadoop/pull/6756#issuecomment-2068700806 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19139) [ABFS]: No GetPathStatus call for opening AbfsInputStream

2024-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839525#comment-17839525 ] ASF GitHub Bot commented on HADOOP-19139: - saxenapranav commented on PR #6699: URL:

Re: [PR] HADOOP-19139.No GetPathStatus for opening AbfsInputStream [hadoop]

2024-04-22 Thread via GitHub
saxenapranav commented on PR #6699: URL: https://github.com/apache/hadoop/pull/6699#issuecomment-2068692643 -- AGGREGATED TEST RESULT HNS-OAuth

[PR] HDFS-17484. Introduce redundancy.considerLoad.minLoad to avoiding excluding nodes when they are not busy actually. [hadoop]

2024-04-22 Thread via GitHub
hfutatzhanghb opened a new pull request, #6758: URL: https://github.com/apache/hadoop/pull/6758 ### Description of PR Refer to HDFS-17484. Currently, we have `dfs.namenode.redundancy.considerLoad` equals true by default, and dfs.namenode.redundancy.considerLoad.factor

Re: [PR] HDFS-15413. add dfs.client.read.striped.datanode.max.attempts to fix read ecfile timeout [hadoop]

2024-04-22 Thread via GitHub
hadoop-yetus commented on PR #5829: URL: https://github.com/apache/hadoop/pull/5829#issuecomment-2068640885 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17457. [FGL] UTs support fine-grained locking [hadoop]

2024-04-22 Thread via GitHub
ZanderXu commented on PR #6741: URL: https://github.com/apache/hadoop/pull/6741#issuecomment-2068640362 The spotbugs will be fixed by HDFS-17485. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] YARN-11622. Fix ResourceManager asynchronous switch from Standy to Active exception [hadoop]

2024-04-22 Thread via GitHub
hadoop-yetus commented on PR #6352: URL: https://github.com/apache/hadoop/pull/6352#issuecomment-2068639212 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[PR] HDFS-17485. Remove redundant nullcheck in RouterRpcServer.java [hadoop]

2024-04-22 Thread via GitHub
ZanderXu opened a new pull request, #6757: URL: https://github.com/apache/hadoop/pull/6757 Fix SpotBug in RouterRpcServer.java. Jira: [HDFS-17485](https://issues.apache.org/jira/browse/HDFS-17485) -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (HADOOP-18656) ABFS: Support for Pagination in Recursive Directory Delete

2024-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839510#comment-17839510 ] ASF GitHub Bot commented on HADOOP-18656: - hadoop-yetus commented on PR #6718: URL:

Re: [PR] HADOOP-18656: [Backport to 3.4] [ABFS] Adding Support for Paginated Delete for Large Directories in HNS Account [hadoop]

2024-04-22 Thread via GitHub
hadoop-yetus commented on PR #6718: URL: https://github.com/apache/hadoop/pull/6718#issuecomment-2068631006 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-19139) [ABFS]: No GetPathStatus call for opening AbfsInputStream

2024-04-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839509#comment-17839509 ] ASF GitHub Bot commented on HADOOP-19139: - saxenapranav commented on PR #6699: URL:

Re: [PR] HADOOP-19139.No GetPathStatus for opening AbfsInputStream [hadoop]

2024-04-22 Thread via GitHub
saxenapranav commented on PR #6699: URL: https://github.com/apache/hadoop/pull/6699#issuecomment-2068625715 All combinations of head optimization, footer optimization, smallFile optimization: headOptimization: false; readFullFile:false; footerOptimization: false

Re: [PR] HDFS-17457. [FGL] UTs support fine-grained locking [hadoop]

2024-04-22 Thread via GitHub
ZanderXu commented on PR #6741: URL: https://github.com/apache/hadoop/pull/6741#issuecomment-2068623064 > @ZanderXu could you check the failed test cases and the spotbugs @ferhui All of failed UTs have been fixed by HDFS-17435. And the spotbugs is not introduced by this PR, I will

  1   2   >