[GitHub] [hadoop] amahussein commented on pull request #2834: HADOOP-17603. Upgrade tomcat-embed-core to 7.0.108

2021-04-12 Thread GitBox
amahussein commented on pull request #2834: URL: https://github.com/apache/hadoop/pull/2834#issuecomment-817876121 Thanks @smengcl , Can you please commit the change to branch-2.10? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [hadoop] amahussein commented on pull request #2835: HADOOP-17601. Upgrade Jackson databind in branch-2.10 to 2.9.10.7

2021-04-12 Thread GitBox
amahussein commented on pull request #2835: URL: https://github.com/apache/hadoop/pull/2835#issuecomment-817876862 Thanks @jojochuang ! Can you please commit the change to branch-2.10? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hadoop] mehakmeet commented on a change in pull request #2731: HADOOP-17471. ABFS to collect IOStatistics

2021-04-12 Thread GitBox
mehakmeet commented on a change in pull request #2731: URL: https://github.com/apache/hadoop/pull/2731#discussion_r611715063 ## File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsOutputStreamStatistics.java ## @@ -241,10 +247,13 @@ public

[GitHub] [hadoop] mehakmeet commented on a change in pull request #2731: HADOOP-17471. ABFS to collect IOStatistics

2021-04-12 Thread GitBox
mehakmeet commented on a change in pull request #2731: URL: https://github.com/apache/hadoop/pull/2731#discussion_r611715063 ## File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsOutputStreamStatistics.java ## @@ -241,10 +247,13 @@ public

[GitHub] [hadoop] mehakmeet commented on a change in pull request #2731: HADOOP-17471. ABFS to collect IOStatistics

2021-04-12 Thread GitBox
mehakmeet commented on a change in pull request #2731: URL: https://github.com/apache/hadoop/pull/2731#discussion_r611715063 ## File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsOutputStreamStatistics.java ## @@ -241,10 +247,13 @@ public

[GitHub] [hadoop] ayushtkn commented on a change in pull request #2861: HADOOP-17620. DistCp: Use Iterator for listing target directory as well.

2021-04-12 Thread GitBox
ayushtkn commented on a change in pull request #2861: URL: https://github.com/apache/hadoop/pull/2861#discussion_r611748559 ## File path: hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/contract/AbstractContractDistCpTest.java ## @@ -628,8 +629,15 @@ public vo

[GitHub] [hadoop] ayushtkn commented on a change in pull request #2861: HADOOP-17620. DistCp: Use Iterator for listing target directory as well.

2021-04-12 Thread GitBox
ayushtkn commented on a change in pull request #2861: URL: https://github.com/apache/hadoop/pull/2861#discussion_r611748559 ## File path: hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/contract/AbstractContractDistCpTest.java ## @@ -628,8 +629,15 @@ public vo

[GitHub] [hadoop] ayushtkn commented on pull request #2896: HDFS-15970. Print network topology on web

2021-04-12 Thread GitBox
ayushtkn commented on pull request #2896: URL: https://github.com/apache/hadoop/pull/2896#issuecomment-817930124 Can you extend this to the rbf ui as well? the federationhealth.html and federationhealth.js -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [hadoop] amaroti opened a new pull request #2897: HADOOP-17611 Restore modification and access times after concat

2021-04-12 Thread GitBox
amaroti opened a new pull request #2897: URL: https://github.com/apache/hadoop/pull/2897 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [hadoop] amaroti commented on pull request #2892: HADOOP-17611. Distcp parallel file copy should retain first chunk modifiedTime after concat

2021-04-12 Thread GitBox
amaroti commented on pull request #2892: URL: https://github.com/apache/hadoop/pull/2892#issuecomment-817942490 Hey @virajjasani take a look at this: https://github.com/apache/hadoop/pull/2897. This also restores the parent directories modification time access time. I have tested this myse

[GitHub] [hadoop] fengnanli commented on a change in pull request #2639: HDFS-15785. Datanode to support using DNS to resolve nameservices to IP addresses to get list of namenodes.

2021-04-12 Thread GitBox
fengnanli commented on a change in pull request #2639: URL: https://github.com/apache/hadoop/pull/2639#discussion_r574117112 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java ## @@ -647,6 +634,58 @@ public static String addKeySuffi

[GitHub] [hadoop] smengcl merged pull request #2834: HADOOP-17603. Upgrade tomcat-embed-core to 7.0.108

2021-04-12 Thread GitBox
smengcl merged pull request #2834: URL: https://github.com/apache/hadoop/pull/2834 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [hadoop] smengcl commented on pull request #2834: HADOOP-17603. Upgrade tomcat-embed-core to 7.0.108

2021-04-12 Thread GitBox
smengcl commented on pull request #2834: URL: https://github.com/apache/hadoop/pull/2834#issuecomment-817980640 @amahussein Done. Thanks for the contribution! :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] hadoop-yetus commented on pull request #2861: HADOOP-17620. DistCp: Use Iterator for listing target directory as well.

2021-04-12 Thread GitBox
hadoop-yetus commented on pull request #2861: URL: https://github.com/apache/hadoop/pull/2861#issuecomment-817993990 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[GitHub] [hadoop] GauthamBanasandra opened a new pull request #2898: HDFS-15971. Make mkstemp cross platform

2021-04-12 Thread GitBox
GauthamBanasandra opened a new pull request #2898: URL: https://github.com/apache/hadoop/pull/2898 * mkstemp isn't available in Visual C++. This PR implements the necessary cross platform implementation for mkstemp. -- This is an automated message from the Apache Git Se

[GitHub] [hadoop] hadoop-yetus commented on pull request #2897: HADOOP-17611 Restore modification and access times after concat

2021-04-12 Thread GitBox
hadoop-yetus commented on pull request #2897: URL: https://github.com/apache/hadoop/pull/2897#issuecomment-818024160 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] steveloughran commented on pull request #2895: HADOOP-17633. Bump json-smart to 2.4.2 due to CVEs

2021-04-12 Thread GitBox
steveloughran commented on pull request #2895: URL: https://github.com/apache/hadoop/pull/2895#issuecomment-818032692 I worry about the lines on the json-smart import ```xml ``` The assumption here is: nimbus-jose-jwt needs to be updated in sync, and kerby. Are there a

[GitHub] [hadoop] hadoop-yetus commented on pull request #2896: HDFS-15970. Print network topology on web

2021-04-12 Thread GitBox
hadoop-yetus commented on pull request #2896: URL: https://github.com/apache/hadoop/pull/2896#issuecomment-818033898 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] steveloughran commented on a change in pull request #2816: HADOOP-15566 initial changes for opentelemetry - WIP

2021-04-12 Thread GitBox
steveloughran commented on a change in pull request #2816: URL: https://github.com/apache/hadoop/pull/2816#discussion_r601307384 ## File path: hadoop-common-project/hadoop-common/pom.xml ## @@ -371,6 +371,31 @@ lz4-java provided + + io.opentelemetry

[GitHub] [hadoop] steveloughran commented on a change in pull request #1925: HADOOP-16948. Support single writer dirs.

2021-04-12 Thread GitBox
steveloughran commented on a change in pull request #1925: URL: https://github.com/apache/hadoop/pull/1925#discussion_r611867287 ## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsLease.java ## @@ -88,6 +88,12 @@ public AbfsLease(A

[GitHub] [hadoop] steveloughran commented on pull request #1925: HADOOP-16948. Support single writer dirs.

2021-04-12 Thread GitBox
steveloughran commented on pull request #1925: URL: https://github.com/apache/hadoop/pull/1925#issuecomment-818043015 @billierinaldi -I'm happy with this. There may be some surprises once you go live, but there's nothing obvious to me right now. +1. merge when ready eithe

[GitHub] [hadoop] steveloughran commented on pull request #2852: MAPREDUCE-7287. Distcp will delete exists file , If we use "--delete …

2021-04-12 Thread GitBox
steveloughran commented on pull request #2852: URL: https://github.com/apache/hadoop/pull/2852#issuecomment-818046355 OK, If @ayushtkn is happy, I'm happy. One thought: could we add a test for a file copy to AbstractContractDistCpTest ? This is the one we do for the object stores, an

[GitHub] [hadoop] steveloughran commented on pull request #2801: HADOOP-17597. Optionally downgrade on S3A Syncable calls

2021-04-12 Thread GitBox
steveloughran commented on pull request #2801: URL: https://github.com/apache/hadoop/pull/2801#issuecomment-818060004 thanks, will update the PR with the comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [hadoop] hadoop-yetus commented on pull request #2898: HDFS-15971. Make mkstemp cross platform

2021-04-12 Thread GitBox
hadoop-yetus commented on pull request #2898: URL: https://github.com/apache/hadoop/pull/2898#issuecomment-818083196 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[GitHub] [hadoop] goiri merged pull request #2605: HDFS-15423 RBF: WebHDFS create shouldn't choose DN from all sub-clusters

2021-04-12 Thread GitBox
goiri merged pull request #2605: URL: https://github.com/apache/hadoop/pull/2605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please co

[GitHub] [hadoop] amahussein opened a new pull request #2899: YARN-10733. TimelineService Hbase tests failing with timeouts

2021-04-12 Thread GitBox
amahussein opened a new pull request #2899: URL: https://github.com/apache/hadoop/pull/2899 [YARN-10733:](https://issues.apache.org/jira/browse/YARN-10733) TimelineService Hbase tests are failing with timeout error on branch-2.10 Timeout running `hadoop-yarn-server-timelineservice-hb

[GitHub] [hadoop] hadoop-yetus commented on pull request #2807: HADOOP-17511. Add audit/telemetry logging to S3A connector

2021-04-12 Thread GitBox
hadoop-yetus commented on pull request #2807: URL: https://github.com/apache/hadoop/pull/2807#issuecomment-818230736 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] hadoop-yetus commented on pull request #2807: HADOOP-17511. Add audit/telemetry logging to S3A connector

2021-04-12 Thread GitBox
hadoop-yetus commented on pull request #2807: URL: https://github.com/apache/hadoop/pull/2807#issuecomment-818255439 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] hadoop-yetus commented on pull request #2899: YARN-10733. TimelineService Hbase tests failing with timeouts

2021-04-12 Thread GitBox
hadoop-yetus commented on pull request #2899: URL: https://github.com/apache/hadoop/pull/2899#issuecomment-818284213 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 11m 2

[GitHub] [hadoop] billierinaldi merged pull request #1925: HADOOP-16948. Support single writer dirs.

2021-04-12 Thread GitBox
billierinaldi merged pull request #1925: URL: https://github.com/apache/hadoop/pull/1925 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [hadoop] jojochuang commented on pull request #2835: HADOOP-17601. Upgrade Jackson databind in branch-2.10 to 2.9.10.7

2021-04-12 Thread GitBox
jojochuang commented on pull request #2835: URL: https://github.com/apache/hadoop/pull/2835#issuecomment-818341722 Sorry my bad. Merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [hadoop] jojochuang merged pull request #2835: HADOOP-17601. Upgrade Jackson databind in branch-2.10 to 2.9.10.7

2021-04-12 Thread GitBox
jojochuang merged pull request #2835: URL: https://github.com/apache/hadoop/pull/2835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [hadoop] Zhangshunyu commented on pull request #2655: HDFS-15714: HDFS Provided Storage Read/Write Mount Support On-the-fly

2021-04-12 Thread GitBox
Zhangshunyu commented on pull request #2655: URL: https://github.com/apache/hadoop/pull/2655#issuecomment-818374335 Currentlly, alias map is based on LevelDB, and it is not support namenode HA, right? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] Zhangshunyu edited a comment on pull request #2655: HDFS-15714: HDFS Provided Storage Read/Write Mount Support On-the-fly

2021-04-12 Thread GitBox
Zhangshunyu edited a comment on pull request #2655: URL: https://github.com/apache/hadoop/pull/2655#issuecomment-818374335 Currentlly, alias map is based on LevelDB, and it does not support namenode HA, right? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] ferhui commented on pull request #2868: HDFS-15759. EC: Verify EC reconstruction correctness on DataNode (#2585)

2021-04-12 Thread GitBox
ferhui commented on pull request #2868: URL: https://github.com/apache/hadoop/pull/2868#issuecomment-818375830 @jojochuang Thanks. Failed tests are unrelated, They passed locally except TestBlockRecovery. And TestBlockRecovery fails without this PR, so i think it's not related to this P

[GitHub] [hadoop] jojochuang commented on pull request #2832: HADOOP-11245. Update NFS gateway to use Netty4

2021-04-12 Thread GitBox
jojochuang commented on pull request #2832: URL: https://github.com/apache/hadoop/pull/2832#issuecomment-818384841 As of the last commit, the code was deployed on a small cluster, verified to contain no memory leak via -Dio.netty.leakDetectionLevel=paranoid. The performance saw no no

[GitHub] [hadoop] jojochuang merged pull request #2868: HDFS-15759. EC: Verify EC reconstruction correctness on DataNode (#2585)

2021-04-12 Thread GitBox
jojochuang merged pull request #2868: URL: https://github.com/apache/hadoop/pull/2868 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [hadoop] jojochuang commented on pull request #2868: HDFS-15759. EC: Verify EC reconstruction correctness on DataNode (#2585)

2021-04-12 Thread GitBox
jojochuang commented on pull request #2868: URL: https://github.com/apache/hadoop/pull/2868#issuecomment-818391251 Thanks! @ferhui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [hadoop] ferhui commented on pull request #2868: HDFS-15759. EC: Verify EC reconstruction correctness on DataNode (#2585)

2021-04-12 Thread GitBox
ferhui commented on pull request #2868: URL: https://github.com/apache/hadoop/pull/2868#issuecomment-818398223 HDFS-15940 has fixed TestBlockRecovery -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hadoop] PHILO-HE commented on pull request #2655: HDFS-15714: HDFS Provided Storage Read/Write Mount Support On-the-fly

2021-04-12 Thread GitBox
PHILO-HE commented on pull request #2655: URL: https://github.com/apache/hadoop/pull/2655#issuecomment-818398537 1) Yes, LevelDB based AliasMap is recommended to user. And text based AliasMap is just for the purpose of unit test. In this patch, we made few code changes for AliasMap. You ma

[GitHub] [hadoop] jojochuang commented on pull request #2882: HDFS-15815. if required storageType are unavailable, log the failed reason during choosing Datanode. Contributed by Yang Yun.

2021-04-12 Thread GitBox
jojochuang commented on pull request #2882: URL: https://github.com/apache/hadoop/pull/2882#issuecomment-818406777 @ayushtkn fyi will merge later if no objections. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [hadoop] goiri commented on a change in pull request #2896: HDFS-15970. Print network topology on the web

2021-04-12 Thread GitBox
goiri commented on a change in pull request #2896: URL: https://github.com/apache/hadoop/pull/2896#discussion_r611908007 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NetworkTopologyServlet.java ## @@ -0,0 +1,115 @@ +/** + *

[GitHub] [hadoop] goiri opened a new pull request #2900: Revert "HDFS-15423 RBF: WebHDFS create shouldn't choose DN from all sub-clusters"

2021-04-12 Thread GitBox
goiri opened a new pull request #2900: URL: https://github.com/apache/hadoop/pull/2900 Reverts apache/hadoop#2605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queri

[GitHub] [hadoop] goiri merged pull request #2900: Revert "HDFS-15423 RBF: WebHDFS create shouldn't choose DN from all sub-clusters"

2021-04-12 Thread GitBox
goiri merged pull request #2900: URL: https://github.com/apache/hadoop/pull/2900 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please co

[GitHub] [hadoop] jojochuang commented on pull request #2849: HDFS-15621. Datanode DirectoryScanner uses excessive memory

2021-04-12 Thread GitBox
jojochuang commented on pull request #2849: URL: https://github.com/apache/hadoop/pull/2849#issuecomment-818409032 The spotbugs warning looks like a false positive to me. `Redundant nullcheck of file, which is known to be non-null in org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.

[GitHub] [hadoop] tomscut commented on a change in pull request #2896: HDFS-15970. Print network topology on the web

2021-04-12 Thread GitBox
tomscut commented on a change in pull request #2896: URL: https://github.com/apache/hadoop/pull/2896#discussion_r612106334 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NetworkTopologyServlet.java ## @@ -0,0 +1,115 @@ +/** +

[GitHub] [hadoop] tomscut commented on a change in pull request #2896: HDFS-15970. Print network topology on the web

2021-04-12 Thread GitBox
tomscut commented on a change in pull request #2896: URL: https://github.com/apache/hadoop/pull/2896#discussion_r612107351 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NetworkTopologyServlet.java ## @@ -0,0 +1,115 @@ +/** +

[GitHub] [hadoop] hchaverri opened a new pull request #2901: HDFS-15912. Allow ProtobufRpcEngine to be extensible

2021-04-12 Thread GitBox
hchaverri opened a new pull request #2901: URL: https://github.com/apache/hadoop/pull/2901 ## NOTICE Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull request which starts with the corresponding JIRA issue number. (e.g. H

[GitHub] [hadoop] ayushtkn commented on pull request #2882: HDFS-15815. if required storageType are unavailable, log the failed reason during choosing Datanode. Contributed by Yang Yun.

2021-04-12 Thread GitBox
ayushtkn commented on pull request #2882: URL: https://github.com/apache/hadoop/pull/2882#issuecomment-818456966 Sure @jojochuang, Thanx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [hadoop] GauthamBanasandra commented on pull request #2898: HDFS-15971. Make mkstemp cross platform

2021-04-12 Thread GitBox
GauthamBanasandra commented on pull request #2898: URL: https://github.com/apache/hadoop/pull/2898#issuecomment-818472914 I've refactored TempFile class to implement the `Rule of 5` C++ idiom - https://cpppatterns.com/patterns/rule-of-five.html. -- This is an automated message from the A

[GitHub] [hadoop] GauthamBanasandra edited a comment on pull request #2898: HDFS-15971. Make mkstemp cross platform

2021-04-12 Thread GitBox
GauthamBanasandra edited a comment on pull request #2898: URL: https://github.com/apache/hadoop/pull/2898#issuecomment-818472914 I've refactored TempFile class to implement the `Rule of 5` C++ idiom for efficient and correct management of the temporary file resource - https://cpppatterns.c

[GitHub] [hadoop] hadoop-yetus commented on pull request #2896: HDFS-15970. Print network topology on the web

2021-04-12 Thread GitBox
hadoop-yetus commented on pull request #2896: URL: https://github.com/apache/hadoop/pull/2896#issuecomment-818480937 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] jojochuang merged pull request #2882: HDFS-15815. if required storageType are unavailable, log the failed reason during choosing Datanode. Contributed by Yang Yun.

2021-04-12 Thread GitBox
jojochuang merged pull request #2882: URL: https://github.com/apache/hadoop/pull/2882 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [hadoop] hadoop-yetus commented on pull request #2896: HDFS-15970. Print network topology on the web

2021-04-13 Thread GitBox
hadoop-yetus commented on pull request #2896: URL: https://github.com/apache/hadoop/pull/2896#issuecomment-818532881 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] jojochuang commented on a change in pull request #2889: HDFS-15963. Unreleased volume references cause an infinite loop.

2021-04-13 Thread GitBox
jojochuang commented on a change in pull request #2889: URL: https://github.com/apache/hadoop/pull/2889#discussion_r612221274 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDataTransferProtocol.java ## @@ -562,4 +565,57 @@ void writeBloc

[GitHub] [hadoop] aajisaka merged pull request #2890: HADOOP-17630. [JDK 15] TestPrintableString fails due to Unicode 13.0 support.

2021-04-13 Thread GitBox
aajisaka merged pull request #2890: URL: https://github.com/apache/hadoop/pull/2890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [hadoop] aajisaka commented on pull request #2890: HADOOP-17630. [JDK 15] TestPrintableString fails due to Unicode 13.0 support.

2021-04-13 Thread GitBox
aajisaka commented on pull request #2890: URL: https://github.com/apache/hadoop/pull/2890#issuecomment-818537893 Merged. Thanks @jojochuang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [hadoop] hadoop-yetus commented on pull request #2898: HDFS-15971. Make mkstemp cross platform

2021-04-13 Thread GitBox
hadoop-yetus commented on pull request #2898: URL: https://github.com/apache/hadoop/pull/2898#issuecomment-818538528 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :o

[GitHub] [hadoop] jojochuang opened a new pull request #2902: HDFS-15940. Fixing and refactoring tests specific to Block recovery.

2021-04-13 Thread GitBox
jojochuang opened a new pull request #2902: URL: https://github.com/apache/hadoop/pull/2902 HDFS-15940 for branch-3.2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For q

[GitHub] [hadoop] virajjasani commented on pull request #2895: HADOOP-17633. Bump json-smart to 2.4.2 due to CVEs

2021-04-13 Thread GitBox
virajjasani commented on pull request #2895: URL: https://github.com/apache/hadoop/pull/2895#issuecomment-818572599 I just tested locally and realized that `nimbus-jose-jwt` 9.8 does not even produce `json-smart` hence all the places where we have excluded `json-smart` from `nimbus-jose-jw

[GitHub] [hadoop] virajjasani commented on pull request #2895: HADOOP-17633. Bump json-smart to 2.4.2 due to CVEs

2021-04-13 Thread GitBox
virajjasani commented on pull request #2895: URL: https://github.com/apache/hadoop/pull/2895#issuecomment-818578359 ``` [INFO] org.apache.hadoop:hadoop-minikdc:jar:3.4.0-SNAPSHOT [INFO] +- commons-io:commons-io:jar:2.5:compile [INFO] +- org.apache.kerby:kerb-simplekdc:jar:1.0.1:comp

[GitHub] [hadoop] virajjasani edited a comment on pull request #2895: HADOOP-17633. Bump json-smart to 2.4.2 due to CVEs

2021-04-13 Thread GitBox
virajjasani edited a comment on pull request #2895: URL: https://github.com/apache/hadoop/pull/2895#issuecomment-818578359 ``` [INFO] org.apache.hadoop:hadoop-minikdc:jar:3.4.0-SNAPSHOT [INFO] +- commons-io:commons-io:jar:2.5:compile [INFO] +- org.apache.kerby:kerb-simplekdc:jar:1.0

[GitHub] [hadoop] hadoop-yetus commented on pull request #2901: HDFS-15912. Allow ProtobufRpcEngine to be extensible

2021-04-13 Thread GitBox
hadoop-yetus commented on pull request #2901: URL: https://github.com/apache/hadoop/pull/2901#issuecomment-818587189 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] hadoop-yetus commented on pull request #2819: HDFS-15923. Authentication failed when rename accross sub clusters.

2021-04-13 Thread GitBox
hadoop-yetus commented on pull request #2819: URL: https://github.com/apache/hadoop/pull/2819#issuecomment-818588736 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] szetszwo commented on pull request #2832: HADOOP-11245. Update NFS gateway to use Netty4

2021-04-13 Thread GitBox
szetszwo commented on pull request #2832: URL: https://github.com/apache/hadoop/pull/2832#issuecomment-818602960 > ... verified to contain no memory leak via -Dio.netty.leakDetectionLevel=paranoid. Hi @jojochuang , according to https://netty.io/wiki/reference-counted-objects.html ,

[GitHub] [hadoop] hadoop-yetus commented on pull request #2896: HDFS-15970. Print network topology on the web

2021-04-13 Thread GitBox
hadoop-yetus commented on pull request #2896: URL: https://github.com/apache/hadoop/pull/2896#issuecomment-818611027 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] tomscut commented on pull request #2896: HDFS-15970. Print network topology on the web

2021-04-13 Thread GitBox
tomscut commented on pull request #2896: URL: https://github.com/apache/hadoop/pull/2896#issuecomment-818622111 Those failed unit tests were unrelated to the change. And they work fine locally. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hadoop] szetszwo commented on a change in pull request #2832: HADOOP-11245. Update NFS gateway to use Netty4

2021-04-13 Thread GitBox
szetszwo commented on a change in pull request #2832: URL: https://github.com/apache/hadoop/pull/2832#discussion_r612218129 ## File path: hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/oncrpc/RpcUtil.java ## @@ -62,75 +64,84 @@ public static FrameDecoder cons

[GitHub] [hadoop] tasanuma commented on pull request #2868: HDFS-15759. EC: Verify EC reconstruction correctness on DataNode (#2585)

2021-04-13 Thread GitBox
tasanuma commented on pull request #2868: URL: https://github.com/apache/hadoop/pull/2868#issuecomment-818649530 Thanks for your work, @jojochuang and @ferhui. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [hadoop] hadoop-yetus commented on pull request #2860: Test Pre-Commits.

2021-04-13 Thread GitBox
hadoop-yetus commented on pull request #2860: URL: https://github.com/apache/hadoop/pull/2860#issuecomment-818664661 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apac

[GitHub] [hadoop] virajjasani commented on pull request #2895: HADOOP-17633. Bump json-smart to 2.4.2 due to CVEs

2021-04-13 Thread GitBox
virajjasani commented on pull request #2895: URL: https://github.com/apache/hadoop/pull/2895#issuecomment-818678822 @steveloughran I have run tests locally for some affected modules and they seem fine. However, this PR's build seems to be stuck (build#2 is still not over after 17+ hr).

[GitHub] [hadoop] hadoop-yetus commented on pull request #2902: HDFS-15940. Fixing and refactoring tests specific to Block recovery.

2021-04-13 Thread GitBox
hadoop-yetus commented on pull request #2902: URL: https://github.com/apache/hadoop/pull/2902#issuecomment-818725828 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] hadoop-yetus commented on pull request #2807: HADOOP-17511. Add audit/telemetry logging to S3A connector

2021-04-13 Thread GitBox
hadoop-yetus commented on pull request #2807: URL: https://github.com/apache/hadoop/pull/2807#issuecomment-818733840 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] jojochuang commented on a change in pull request #2849: HDFS-15621. Datanode DirectoryScanner uses excessive memory

2021-04-13 Thread GitBox
jojochuang commented on a change in pull request #2849: URL: https://github.com/apache/hadoop/pull/2849#discussion_r612493208 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/FsVolumeSpi.java ## @@ -297,23 +281,18 @@

[GitHub] [hadoop] goiri merged pull request #2898: HDFS-15971. Make mkstemp cross platform

2021-04-13 Thread GitBox
goiri merged pull request #2898: URL: https://github.com/apache/hadoop/pull/2898 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please co

[GitHub] [hadoop] hadoop-yetus commented on pull request #2889: HDFS-15963. Unreleased volume references cause an infinite loop.

2021-04-13 Thread GitBox
hadoop-yetus commented on pull request #2889: URL: https://github.com/apache/hadoop/pull/2889#issuecomment-818875816 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] virajjasani commented on pull request #2895: HADOOP-17633. Bump json-smart to 2.4.2 due to CVEs

2021-04-13 Thread GitBox
virajjasani commented on pull request #2895: URL: https://github.com/apache/hadoop/pull/2895#issuecomment-818903880 `json-smart` is used directly by hadoop-auth and through hadoop-auth, it is used by multiple modules as transitive dependency in hadoop-common, hadoop-nfs, hadoop-hdfs, hadoo

[GitHub] [hadoop] ArkenKiran commented on a change in pull request #2816: HADOOP-15566 initial changes for opentelemetry - WIP

2021-04-13 Thread GitBox
ArkenKiran commented on a change in pull request #2816: URL: https://github.com/apache/hadoop/pull/2816#discussion_r612646490 ## File path: hadoop-common-project/hadoop-common/pom.xml ## @@ -371,6 +371,31 @@ lz4-java provided + + io.opentelemetry +

[GitHub] [hadoop] virajjasani commented on pull request #2895: HADOOP-17633. Bump json-smart to 2.4.2 due to CVEs

2021-04-13 Thread GitBox
virajjasani commented on pull request #2895: URL: https://github.com/apache/hadoop/pull/2895#issuecomment-818917758 FYI @ayushtkn @jojochuang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hadoop] virajjasani edited a comment on pull request #2895: HADOOP-17633. Bump json-smart to 2.4.2 due to CVEs

2021-04-13 Thread GitBox
virajjasani edited a comment on pull request #2895: URL: https://github.com/apache/hadoop/pull/2895#issuecomment-818917758 FYI @ayushtkn @jojochuang , if you would also like to take a look. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [hadoop] hadoop-yetus commented on pull request #2860: Test Pre-Commits.

2021-04-13 Thread GitBox
hadoop-yetus commented on pull request #2860: URL: https://github.com/apache/hadoop/pull/2860#issuecomment-818918160 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apac

[GitHub] [hadoop] fengnanli opened a new pull request #2903: HDFS-15423 RBF: WebHDFS create shouldn't choose DN from all sub-clusters

2021-04-13 Thread GitBox
fengnanli opened a new pull request #2903: URL: https://github.com/apache/hadoop/pull/2903 ## NOTICE Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull request which starts with the corresponding JIRA issue number. (e.g. H

[GitHub] [hadoop] virajjasani closed pull request #2892: HADOOP-17611. Distcp parallel file copy should retain first chunk modifiedTime after concat

2021-04-13 Thread GitBox
virajjasani closed pull request #2892: URL: https://github.com/apache/hadoop/pull/2892 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [hadoop] virajjasani commented on pull request #2892: HADOOP-17611. Distcp parallel file copy should retain first chunk modifiedTime after concat

2021-04-13 Thread GitBox
virajjasani commented on pull request #2892: URL: https://github.com/apache/hadoop/pull/2892#issuecomment-818959488 Closing this PR as this is being tracked actively on #2897 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [hadoop] xiaoyuyao commented on pull request #2784: HDFS-15850. Superuser actions should be reported to external enforcers

2021-04-13 Thread GitBox
xiaoyuyao commented on pull request #2784: URL: https://github.com/apache/hadoop/pull/2784#issuecomment-818962252 Thanks @vivekratnavel for the update. The latest change LGTM, +1. The unit test failure does not relate to the change here. I will merge the PR shortly. -- This is an

[GitHub] [hadoop] xiaoyuyao edited a comment on pull request #2784: HDFS-15850. Superuser actions should be reported to external enforcers

2021-04-13 Thread GitBox
xiaoyuyao edited a comment on pull request #2784: URL: https://github.com/apache/hadoop/pull/2784#issuecomment-818962252 Thanks @vivekratnavel for the update. The latest change LGTM, +1. The unit test failure does not relate to the change here. I will merge the PR EOD tomorrow if ther

[GitHub] [hadoop] fengnanli opened a new pull request #2904: HADOOP-17604 Fix method metric prefix for string type

2021-04-13 Thread GitBox
fengnanli opened a new pull request #2904: URL: https://github.com/apache/hadoop/pull/2904 ## NOTICE Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull request which starts with the corresponding JIRA issue number. (e.g. H

[GitHub] [hadoop] hadoop-yetus commented on pull request #2860: Test Pre-Commits.

2021-04-13 Thread GitBox
hadoop-yetus commented on pull request #2860: URL: https://github.com/apache/hadoop/pull/2860#issuecomment-818990572 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] hadoop-yetus commented on pull request #2901: HDFS-15912. Allow ProtobufRpcEngine to be extensible

2021-04-13 Thread GitBox
hadoop-yetus commented on pull request #2901: URL: https://github.com/apache/hadoop/pull/2901#issuecomment-819009254 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] hadoop-yetus commented on pull request #2903: HDFS-15423 RBF: WebHDFS create shouldn't choose DN from all sub-clusters

2021-04-13 Thread GitBox
hadoop-yetus commented on pull request #2903: URL: https://github.com/apache/hadoop/pull/2903#issuecomment-819013126 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] hchaverri closed pull request #2901: HDFS-15912. Allow ProtobufRpcEngine to be extensible

2021-04-13 Thread GitBox
hchaverri closed pull request #2901: URL: https://github.com/apache/hadoop/pull/2901 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [hadoop] hadoop-yetus commented on pull request #2816: HADOOP-15566 initial changes for opentelemetry - WIP

2021-04-13 Thread GitBox
hadoop-yetus commented on pull request #2816: URL: https://github.com/apache/hadoop/pull/2816#issuecomment-819017936 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] hchaverri opened a new pull request #2905: HDFS-15912. Allow ProtobufRpcEngine to be extensible

2021-04-13 Thread GitBox
hchaverri opened a new pull request #2905: URL: https://github.com/apache/hadoop/pull/2905 ## NOTICE Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull request which starts with the corresponding JIRA issue number. (e.g. H

[GitHub] [hadoop] hadoop-yetus commented on pull request #2903: HDFS-15423 RBF: WebHDFS create shouldn't choose DN from all sub-clusters

2021-04-13 Thread GitBox
hadoop-yetus commented on pull request #2903: URL: https://github.com/apache/hadoop/pull/2903#issuecomment-819084728 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] hadoop-yetus commented on pull request #2903: HDFS-15423 RBF: WebHDFS create shouldn't choose DN from all sub-clusters

2021-04-13 Thread GitBox
hadoop-yetus commented on pull request #2903: URL: https://github.com/apache/hadoop/pull/2903#issuecomment-819090454 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] hadoop-yetus commented on pull request #2905: HDFS-15912. Allow ProtobufRpcEngine to be extensible

2021-04-13 Thread GitBox
hadoop-yetus commented on pull request #2905: URL: https://github.com/apache/hadoop/pull/2905#issuecomment-819107509 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] hadoop-yetus commented on pull request #2904: HADOOP-17604 Fix method metric prefix for string type

2021-04-13 Thread GitBox
hadoop-yetus commented on pull request #2904: URL: https://github.com/apache/hadoop/pull/2904#issuecomment-819114365 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] fengnanli commented on pull request #2903: HDFS-15423 RBF: WebHDFS create shouldn't choose DN from all sub-clusters

2021-04-13 Thread GitBox
fengnanli commented on pull request #2903: URL: https://github.com/apache/hadoop/pull/2903#issuecomment-819115602 @goiri Mind merging this? The test failures are flaky and I got them working locally. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop] hadoop-yetus commented on pull request #2860: Test Pre-Commits.

2021-04-13 Thread GitBox
hadoop-yetus commented on pull request #2860: URL: https://github.com/apache/hadoop/pull/2860#issuecomment-819153675 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok

[GitHub] [hadoop] ferhui commented on pull request #2902: HDFS-15940. Fixing and refactoring tests specific to Block recovery.

2021-04-13 Thread GitBox
ferhui commented on pull request #2902: URL: https://github.com/apache/hadoop/pull/2902#issuecomment-819171302 @jojochuang Thanks. Failed tests passed locally There are some unused imports in TestBlockRecovery.java -- This is an automated message from the Apache Git Service. To resp

<    1   2   3   4   5   6   7   8   9   10   >