[GitHub] [hadoop] krishan1390 commented on pull request #5318: YARN-11412 Concurrent user management

krishan1390 commented on PR #5318: URL: https://github.com/apache/hadoop/pull/5318#issuecomment-1398641086 @wangdatan @sunilgovind @PrabhuJoseph can you please take a look at this PR - I am working on adding the test cases, but would be great if you can share feedback. -- This is an

[GitHub] [hadoop] hadoop-yetus commented on pull request #5054: HADOOP-18399 Prefetch - SingleFilePerBlockCache to use LocalDirAllocator for file allocation

hadoop-yetus commented on PR #5054: URL: https://github.com/apache/hadoop/pull/5054#issuecomment-1398107272 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5147: HDFS-16848. RBF: Improve StateStoreZooKeeperImpl performance

hadoop-yetus commented on PR #5147: URL: https://github.com/apache/hadoop/pull/5147#issuecomment-1398068247 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5312: YARN-11375. [Federation] Support refreshAdminAcls、refreshServiceAcls API's for Federation.

hadoop-yetus commented on PR #5312: URL: https://github.com/apache/hadoop/pull/5312#issuecomment-1398057383 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] iwasakims commented on pull request #5319: HADOOP-18598. maven site generation doesn't include javadocs.

iwasakims commented on PR #5319: URL: https://github.com/apache/hadoop/pull/5319#issuecomment-1398056673 Since I can not test the patch on trunk due to [HADOOP-18601](https://issues.apache.org/jira/browse/HADOOP-18601), this PR is against branch-3.3. -- This is an automated message from

[GitHub] [hadoop] susheel-gupta commented on a diff in pull request #5278: YARN-11408. Add a check of autoQueueCreation is disabled for emitDefaultUserLimitFactor method

susheel-gupta commented on code in PR #5278: URL: https://github.com/apache/hadoop/pull/5278#discussion_r1071075406 ##

[GitHub] [hadoop] iwasakims opened a new pull request, #5319: HADOOP-18598. maven site generation doesn't include javadocs.

iwasakims opened a new pull request, #5319: URL: https://github.com/apache/hadoop/pull/5319 https://issues.apache.org/jira/browse/HADOOP-18598 maven-site-plugin-3.11.0 is incompatible with maven-javadoc-plugin-3.0.1. Downgrading maven-site-plugin to 3.9.1 fixes missing javadocs in

[GitHub] [hadoop] hadoop-yetus commented on pull request #5302: YARN-11221. [Federation] Add replaceLabelsOnNodes, replaceLabelsOnNode REST APIs for Router.

hadoop-yetus commented on PR #5302: URL: https://github.com/apache/hadoop/pull/5302#issuecomment-1397977798 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5284: YARN-11218. [Federation] Add getActivities, getBulkActivities REST APIs for Router.

hadoop-yetus commented on PR #5284: URL: https://github.com/apache/hadoop/pull/5284#issuecomment-1397969145 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] susheel-gupta commented on a diff in pull request #5295: YARN-11404. Add junit5 dependency to hadoop-mapreduce-client-app to fix few unit test failure

susheel-gupta commented on code in PR #5295: URL: https://github.com/apache/hadoop/pull/5295#discussion_r1082128599 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapred/TestTaskAttemptListenerImpl.java: ## @@

[GitHub] [hadoop] hadoop-yetus commented on pull request #5272: YARN-11217. [Federation] Add dumpSchedulerLogs REST APIs for Router.

hadoop-yetus commented on PR #5272: URL: https://github.com/apache/hadoop/pull/5272#issuecomment-1397907701 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on pull request #5260: YARN-8900. [Follow Up] Fix FederationInterceptorREST#invokeConcurrent Inaccurate Order of Subclusters.

slfan1989 commented on PR #5260: URL: https://github.com/apache/hadoop/pull/5260#issuecomment-1397817449 @goiri Thank you very much for helping to review the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] goiri merged pull request #5260: YARN-8900. [Follow Up] Fix FederationInterceptorREST#invokeConcurrent Inaccurate Order of Subclusters.

goiri merged PR #5260: URL: https://github.com/apache/hadoop/pull/5260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] slfan1989 commented on pull request #5260: YARN-8900. [Follow Up] Fix FederationInterceptorREST#invokeConcurrent Inaccurate Order of Subclusters.

slfan1989 commented on PR #5260: URL: https://github.com/apache/hadoop/pull/5260#issuecomment-1397727689 @goiri Can you help to merge this pr into the trunk branch? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

virajjasani commented on code in PR #5315: URL: https://github.com/apache/hadoop/pull/5315#discussion_r1081716267 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/LogAdapter.java: ## @@ -17,61 +17,40 @@ */ package org.apache.hadoop.util; -import

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

virajjasani commented on code in PR #5315: URL: https://github.com/apache/hadoop/pull/5315#discussion_r1081715049 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/log/LogLevel.java: ## @@ -340,22 +337,14 @@ public void doGet(HttpServletRequest request,

[GitHub] [hadoop] virajjasani commented on pull request #5054: HADOOP-18399 Prefetch - SingleFilePerBlockCache to use LocalDirAllocator for file allocation

virajjasani commented on PR #5054: URL: https://github.com/apache/hadoop/pull/5054#issuecomment-1397617517 synced -- pulled latest trunk commits to the branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] virajjasani commented on pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

virajjasani commented on PR #5315: URL: https://github.com/apache/hadoop/pull/5315#issuecomment-1397489869 Javadoc warnings for common and spotbug warnings for mapreduce modules are not relevant to this change. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

virajjasani commented on code in PR #5315: URL: https://github.com/apache/hadoop/pull/5315#discussion_r1081718563 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java: ## @@ -318,9 +316,9 @@ public class DataNode extends

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

virajjasani commented on code in PR #5315: URL: https://github.com/apache/hadoop/pull/5315#discussion_r1081718137 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/LogAdapter.java: ## @@ -17,61 +17,40 @@ */ package org.apache.hadoop.util; -import

[GitHub] [hadoop] virajjasani commented on a diff in pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

virajjasani commented on code in PR #5315: URL: https://github.com/apache/hadoop/pull/5315#discussion_r1081715049 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/log/LogLevel.java: ## @@ -340,22 +337,14 @@ public void doGet(HttpServletRequest request,

[GitHub] [hadoop] virajjasani commented on pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

virajjasani commented on PR #5315: URL: https://github.com/apache/hadoop/pull/5315#issuecomment-1397385744 bummer, we can't completely get rid of it as commons-configuration needs it, so we will have to keep the version in our classpath but we won't use it in the codebase. -- This is an

[GitHub] [hadoop] steveloughran commented on pull request #5163: HADOOP-18073. Upgrade AWS SDK to v2 in S3A [work in progress]

steveloughran commented on PR #5163: URL: https://github.com/apache/hadoop/pull/5163#issuecomment-1397372151 merged! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hadoop] asfgit merged pull request #5163: HADOOP-18073. Upgrade AWS SDK to v2 in S3A [work in progress]

asfgit merged PR #5163: URL: https://github.com/apache/hadoop/pull/5163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

hadoop-yetus commented on PR #5315: URL: https://github.com/apache/hadoop/pull/5315#issuecomment-1397350094 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] K0K0V0K commented on pull request #5311: MAPREDUCE-7431. ShuffleHandler refactor and fix after Netty4 upgrade.

K0K0V0K commented on PR #5311: URL: https://github.com/apache/hadoop/pull/5311#issuecomment-1397239024 +1, non-binding -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hadoop] mehakmeet commented on a diff in pull request #5308: HADOOP-18596. Distcp -update to use modification time while checking for file skip.

mehakmeet commented on code in PR #5308: URL: https://github.com/apache/hadoop/pull/5308#discussion_r1081471243 ## hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/CopyMapper.java: ## @@ -354,7 +354,14 @@ private boolean canSkip(FileSystem sourceFS,

[GitHub] [hadoop] virajjasani commented on pull request #5294: HADOOP-18592 Sasl connection failure should log remote address

virajjasani commented on PR #5294: URL: https://github.com/apache/hadoop/pull/5294#issuecomment-1397191522 @steveloughran, updated the PR based on your latest review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hadoop] dannycjones commented on a diff in pull request #5308: HADOOP-18596. Distcp -update to use modification time while checking for file skip.

dannycjones commented on code in PR #5308: URL: https://github.com/apache/hadoop/pull/5308#discussion_r1081452359 ## hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/CopyMapper.java: ## @@ -354,7 +354,14 @@ private boolean canSkip(FileSystem sourceFS,

[GitHub] [hadoop] hadoop-yetus commented on pull request #5317: YARN-11420 Stabilize TestNMClient

hadoop-yetus commented on PR #5317: URL: https://github.com/apache/hadoop/pull/5317#issuecomment-1397143914 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5317: YARN-11420 Stabilize TestNMClient

hadoop-yetus commented on PR #5317: URL: https://github.com/apache/hadoop/pull/5317#issuecomment-1397143337 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5317: YARN-11420 Stabilize TestNMClient

hadoop-yetus commented on PR #5317: URL: https://github.com/apache/hadoop/pull/5317#issuecomment-1397140540 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5318: YARN-11412 Concurrent user management

hadoop-yetus commented on PR #5318: URL: https://github.com/apache/hadoop/pull/5318#issuecomment-1397089189 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] steveloughran commented on a diff in pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

steveloughran commented on code in PR #5315: URL: https://github.com/apache/hadoop/pull/5315#discussion_r1081327340 ## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/log/LogLevel.java: ## @@ -340,22 +337,14 @@ public void doGet(HttpServletRequest request,

[GitHub] [hadoop] hadoop-yetus commented on pull request #5318: YARN-11412 Concurrent user management

hadoop-yetus commented on PR #5318: URL: https://github.com/apache/hadoop/pull/5318#issuecomment-1397073307 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5316: Yarn 11420

hadoop-yetus commented on PR #5316: URL: https://github.com/apache/hadoop/pull/5316#issuecomment-1397008425 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] tomicooler commented on a diff in pull request #5311: MAPREDUCE-7431. ShuffleHandler refactor and fix after Netty4 upgrade.

tomicooler commented on code in PR #5311: URL: https://github.com/apache/hadoop/pull/5311#discussion_r1081262415 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleChannelHandler.java: ## @@ -0,0

[GitHub] [hadoop] hadoop-yetus commented on pull request #5317: YARN-11420 Stabilize TestNMClient

hadoop-yetus commented on PR #5317: URL: https://github.com/apache/hadoop/pull/5317#issuecomment-1396932613 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] szilard-nemeth commented on a diff in pull request #5295: YARN-11404. Add junit5 dependency to hadoop-mapreduce-client-app to fix few unit test failure

szilard-nemeth commented on code in PR #5295: URL: https://github.com/apache/hadoop/pull/5295#discussion_r1081217771 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapred/TestTaskAttemptListenerImpl.java: ## @@

[GitHub] [hadoop] pranavsaxena-microsoft commented on pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

pranavsaxena-microsoft commented on PR #3440: URL: https://github.com/apache/hadoop/pull/3440#issuecomment-1396908517 @mukund-thakur , requesting you to kindly review the PR. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hadoop] hadoop-yetus commented on pull request #5295: YARN-11404. Add junit5 dependency to hadoop-mapreduce-client-app to fix few unit test failure

hadoop-yetus commented on PR #5295: URL: https://github.com/apache/hadoop/pull/5295#issuecomment-1396908472 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] K0K0V0K commented on a diff in pull request #5311: MAPREDUCE-7431. ShuffleHandler refactor and fix after Netty4 upgrade.

K0K0V0K commented on code in PR #5311: URL: https://github.com/apache/hadoop/pull/5311#discussion_r1081143805 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleChannelHandler.java: ## @@ -0,0 +1,715

[GitHub] [hadoop] hadoop-yetus commented on pull request #5311: MAPREDUCE-7431. ShuffleHandler refactor and fix after Netty4 upgrade.

hadoop-yetus commented on PR #5311: URL: https://github.com/apache/hadoop/pull/5311#issuecomment-1396860917 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5312: YARN-11375. [Federation] Support refreshAdminAcls、refreshServiceAcls API's for Federation.

hadoop-yetus commented on PR #5312: URL: https://github.com/apache/hadoop/pull/5312#issuecomment-1396832513 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #650: HADOOP-16209. Create simple docker based pseudo-cluster for hdfs

hadoop-yetus commented on PR #650: URL: https://github.com/apache/hadoop/pull/650#issuecomment-1396825079 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexec

[GitHub] [hadoop] krishan1390 closed pull request #5314: Yarn-11411 Concurrent user management

krishan1390 closed pull request #5314: Yarn-11411 Concurrent user management URL: https://github.com/apache/hadoop/pull/5314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hadoop] krishan1390 closed pull request #5313: YARN-11411 Encapsulating certain User Manager APIs by making it private

krishan1390 closed pull request #5313: YARN-11411 Encapsulating certain User Manager APIs by making it private URL: https://github.com/apache/hadoop/pull/5313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop] krishan1390 opened a new pull request, #5318: YARN-11412 Concurrent user management

krishan1390 opened a new pull request, #5318: URL: https://github.com/apache/hadoop/pull/5318 JIRA: [YARN-11412](https://issues.apache.org/jira/browse/YARN-11412). Create a Concurrent Users Manager to enable thread safe concurrent resource usage tracking of user Low level

[GitHub] [hadoop] K0K0V0K opened a new pull request, #5317: YARN-11420 Stabilize TestNMClient

K0K0V0K opened a new pull request, #5317: URL: https://github.com/apache/hadoop/pull/5317 ### Description of PR The TestNMClient test methods can stuck if the test container fails, while the test is expecting it running state. This can happen for example if the container fails due low

[GitHub] [hadoop] K0K0V0K closed pull request #5286: YARN-11410. Add default methods for StateMachine

K0K0V0K closed pull request #5286: YARN-11410. Add default methods for StateMachine URL: https://github.com/apache/hadoop/pull/5286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hadoop] K0K0V0K closed pull request #5316: Yarn 11420

K0K0V0K closed pull request #5316: Yarn 11420 URL: https://github.com/apache/hadoop/pull/5316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] K0K0V0K opened a new pull request, #5316: Yarn 11420

K0K0V0K opened a new pull request, #5316: URL: https://github.com/apache/hadoop/pull/5316 ### Description of PR The TestNMClient test methods can stuck if the test container fails, while the test is expecting it running state. This can happen for example if the container fails due

[GitHub] [hadoop] hadoop-yetus commented on pull request #5311: MAPREDUCE-7431. ShuffleHandler refactor and fix after Netty4 upgrade.

hadoop-yetus commented on PR #5311: URL: https://github.com/apache/hadoop/pull/5311#issuecomment-1396671969 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] susheel-gupta commented on a diff in pull request #5295: YARN-11404. Add junit5 dependency to hadoop-mapreduce-client-app to fix few unit test failure

susheel-gupta commented on code in PR #5295: URL: https://github.com/apache/hadoop/pull/5295#discussion_r1080982699 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapred/TestTaskAttemptListenerImpl.java: ## @@

[GitHub] [hadoop] hadoop-yetus commented on pull request #5310: HADOOP-17717. Update wildfly openssl to 1.1.3.Final

hadoop-yetus commented on PR #5310: URL: https://github.com/apache/hadoop/pull/5310#issuecomment-1396645743 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] szilard-nemeth commented on a diff in pull request #5295: YARN-11404. Add junit5 dependency to hadoop-mapreduce-client-app to fix few unit test failure

szilard-nemeth commented on code in PR #5295: URL: https://github.com/apache/hadoop/pull/5295#discussion_r1080950958 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapred/TestTaskAttemptListenerImpl.java: ## @@

[GitHub] [hadoop] hadoop-yetus commented on pull request #5314: Yarn-11411 Concurrent user management

hadoop-yetus commented on PR #5314: URL: https://github.com/apache/hadoop/pull/5314#issuecomment-1396610842 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5313: YARN-11411 Encapsulating certain User Manager APIs by making it private

hadoop-yetus commented on PR #5313: URL: https://github.com/apache/hadoop/pull/5313#issuecomment-1396596316 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5312: YARN-11375. [Federation] Support refreshAdminAcls、refreshServiceAcls API's for Federation.

hadoop-yetus commented on PR #5312: URL: https://github.com/apache/hadoop/pull/5312#issuecomment-1396500494 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on pull request #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

slfan1989 commented on PR #5315: URL: https://github.com/apache/hadoop/pull/5315#issuecomment-1396473352 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hadoop] virajjasani opened a new pull request, #5315: HADOOP-18206 Cleanup the commons-logging references and restrict its usage in future

virajjasani opened a new pull request, #5315: URL: https://github.com/apache/hadoop/pull/5315 Sub-task of HADOOP-16206 (Migrate from Log4j1 to Log4j2) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hadoop] hadoop-yetus commented on pull request #5309: YARN-11419. Remove redundant exception capture in NMClientAsyncImpl and improve readability in ContainerShellWebSocket, etc

hadoop-yetus commented on PR #5309: URL: https://github.com/apache/hadoop/pull/5309#issuecomment-1396450495 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] krishan1390 opened a new pull request, #5314: Yarn-11411 Concurrent user management

krishan1390 opened a new pull request, #5314: URL: https://github.com/apache/hadoop/pull/5314 JIRA: [YARN-11411](https://issues.apache.org/jira/browse/YARN-11411). Create a Concurrent Users Manager to enable thread safe concurrent resource usage tracking of user Low level

[GitHub] [hadoop] krishan1390 opened a new pull request, #5313: YARN-11411 Encapsulating certain User Manager APIs by making it private

krishan1390 opened a new pull request, #5313: URL: https://github.com/apache/hadoop/pull/5313 As part of https://issues.apache.org/jira/browse/YARN-11412 to build a concurrent users manager, I am planning to isolate user management into a package and limit its public APIs. This will help

[GitHub] [hadoop] mccormickt12 commented on pull request #4967: HDFS-16791 WIP - client protocol and Filesystem apis implemented and …

mccormickt12 commented on PR #4967: URL: https://github.com/apache/hadoop/pull/4967#issuecomment-1396405881 @steveloughran as I commented before, I added all the contract tests I could find that made sense. Some level of functionality couldn't practically be tested in the contract tests

[GitHub] [hadoop] hadoop-yetus commented on pull request #4967: HDFS-16791 WIP - client protocol and Filesystem apis implemented and …

hadoop-yetus commented on PR #4967: URL: https://github.com/apache/hadoop/pull/4967#issuecomment-1396401494 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 opened a new pull request, #5312: YARN-11375. [Federation] Support refreshAdminAcls、refreshServiceAcls API's for Federation.

slfan1989 opened a new pull request, #5312: URL: https://github.com/apache/hadoop/pull/5312 JIRA: YARN-11375. [Federation] Support refreshAdminAcls、refreshServiceAcls API's for Federation. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hadoop] smallzhongfeng commented on a diff in pull request #5309: YARN-11419. Remove redundant exception capture in NMClientAsyncImpl and improve readability in ContainerShellWebSocket, etc

smallzhongfeng commented on code in PR #5309: URL: https://github.com/apache/hadoop/pull/5309#discussion_r1080761997 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/SharedCacheClientImpl.java: ## @@ -158,14 +158,8 @@

[GitHub] [hadoop] zhtttylz commented on pull request #5303: HDFS-16893. Standardize the usage of DFSClient debug log

zhtttylz commented on PR #5303: URL: https://github.com/apache/hadoop/pull/5303#issuecomment-1396375768 Thanks @ayushtkn @slfan1989 help review and merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop] hadoop-yetus commented on pull request #5298: HDFS-16890: RBF: Ensures router periodically refreshes its record of a namespace's state.

hadoop-yetus commented on PR #5298: URL: https://github.com/apache/hadoop/pull/5298#issuecomment-1396369913 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on pull request #5303: HDFS-16893. Standardize the usage of DFSClient debug log

slfan1989 commented on PR #5303: URL: https://github.com/apache/hadoop/pull/5303#issuecomment-1396248393 @zhtttylz, thank you for contributing this improvement. @ayushtkn, thank you for the help with code review. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [hadoop] slfan1989 merged pull request #5303: HDFS-16893. Standardize the usage of DFSClient debug log

slfan1989 merged PR #5303: URL: https://github.com/apache/hadoop/pull/5303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5298: HDFS-16890: RBF: Ensures router periodically refreshes its record of a namespace's state.

hadoop-yetus commented on PR #5298: URL: https://github.com/apache/hadoop/pull/5298#issuecomment-1396241879 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5309: YARN-11419. Remove redundant exception capture in NMClientAsyncImpl and improve readability in ContainerShellWebSocket, etc

slfan1989 commented on code in PR #5309: URL: https://github.com/apache/hadoop/pull/5309#discussion_r1080674836 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/SharedCacheClientImpl.java: ## @@ -158,14 +158,8 @@ public

[GitHub] [hadoop] slfan1989 commented on pull request #5309: YARN-11419. Remove redundant exception capture in NMClientAsyncImpl and improve readability in ContainerShellWebSocket, etc

slfan1989 commented on PR #5309: URL: https://github.com/apache/hadoop/pull/5309#issuecomment-1396240445 @smallzhongfeng Thank you very much for your contribution, We need to fix checkstyle -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hadoop] simbadzina commented on a diff in pull request #5298: HDFS-16890: RBF: Ensures router periodically refreshes its record of a namespace's state.

simbadzina commented on code in PR #5298: URL: https://github.com/apache/hadoop/pull/5298#discussion_r1080612475 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestObserverWithRouter.java: ## @@ -639,4 +643,36 @@ public void

[GitHub] [hadoop] cnauroth commented on pull request #5300: HDFS-16891 Avoid the overhead of copy-on-write exception list while loading inodes sub sections in parallel

cnauroth commented on PR #5300: URL: https://github.com/apache/hadoop/pull/5300#issuecomment-1396142728 I have committed this to trunk and branch-3.3. I did not commit to branch-3.2, because the original HDFS-14617 changes for parallel fsimage loading are not present in branch-3.2.

[GitHub] [hadoop] cnauroth merged pull request #5300: HDFS-16891 Avoid the overhead of copy-on-write exception list while loading inodes sub sections in parallel

cnauroth merged PR #5300: URL: https://github.com/apache/hadoop/pull/5300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hadoop] hadoop-yetus commented on pull request #5119: YARN-5607. Document TestContainerResourceUsage#waitForContainerCompletion

hadoop-yetus commented on PR #5119: URL: https://github.com/apache/hadoop/pull/5119#issuecomment-1387717617 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5311: MAPREDUCE-7431. ShuffleHandler refactor and fix after Netty4 upgrade.

hadoop-yetus commented on PR #5311: URL: https://github.com/apache/hadoop/pull/5311#issuecomment-1387533352 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5311: MAPREDUCE-7431. ShuffleHandler refactor and fix after Netty4 upgrade.

hadoop-yetus commented on PR #5311: URL: https://github.com/apache/hadoop/pull/5311#issuecomment-1387525353 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5309: YARN-11419. Remove redundant exception capture in NMClientAsyncImpl and improve readability in ContainerShellWebSocket, etc

hadoop-yetus commented on PR #5309: URL: https://github.com/apache/hadoop/pull/5309#issuecomment-1387445181 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] smallzhongfeng commented on pull request #5309: YARN-11419. Remove redundant exception capture in NMClientAsyncImpl and improve readability in ContainerShellWebSocket, etc

smallzhongfeng commented on PR #5309: URL: https://github.com/apache/hadoop/pull/5309#issuecomment-1387422823 > Hi @smallzhongfeng , > > Could you be more specific with the title of PR / jira about what are you improving / cleaning up? Class name should be in it at least.

[GitHub] [hadoop] tomicooler opened a new pull request, #5311: MAPREDUCE-7431. ShuffleHandler refactor and fix after Netty4 upgrade.

tomicooler opened a new pull request, #5311: URL: https://github.com/apache/hadoop/pull/5311 Change-Id: Ifedad2fae1ddd8f22623b5d44875b20a3b3fd318 ### Description of PR Work in Progress. No review is needed yet, I'll update when I'm ready with my manual end-to-end tests.

[GitHub] [hadoop] hadoop-yetus commented on pull request #4967: HDFS-16791 WIP - client protocol and Filesystem apis implemented and …

hadoop-yetus commented on PR #4967: URL: https://github.com/apache/hadoop/pull/4967#issuecomment-1387341443 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5163: HADOOP-18073. Upgrade AWS SDK to v2 in S3A [work in progress]

hadoop-yetus commented on PR #5163: URL: https://github.com/apache/hadoop/pull/5163#issuecomment-1387306117 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] szilard-nemeth commented on pull request #5309: YARN-11419. Simplify code and improve readability

szilard-nemeth commented on PR #5309: URL: https://github.com/apache/hadoop/pull/5309#issuecomment-1387259387 Hi @smallzhongfeng , Could you be more specific with the title of PR / jira about what are you improving / cleaning up? Class name should be in it at least. -- This is an

[GitHub] [hadoop] p-szucs commented on a diff in pull request #5295: YARN-11404. Add junit5 dependency to hadoop-mapreduce-client-app to fix few unit test failure

p-szucs commented on code in PR #5295: URL: https://github.com/apache/hadoop/pull/5295#discussion_r1073624151 ## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestMapReduceChildJVM.java: ##

[GitHub] [hadoop] steveloughran commented on pull request #5310: HADOOP-17717. Update wildfly openssl to 1.1.3.Final

steveloughran commented on PR #5310: URL: https://github.com/apache/hadoop/pull/5310#issuecomment-1387208196 hadoop-aws : london, hadoop-azure: cardiff, (non scale tests) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hadoop] steveloughran commented on pull request #4998: HADOOP-18235. vulnerability: we may leak sensitive information in LocalKeyStoreProvider

steveloughran commented on PR #4998: URL: https://github.com/apache/hadoop/pull/4998#issuecomment-1387207281 where are we with this patch? can/should we get it into 3.3.5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hadoop] hadoop-yetus commented on pull request #5299: Add reason in in x-ms-client-request-id on a retry API call.

hadoop-yetus commented on PR #5299: URL: https://github.com/apache/hadoop/pull/5299#issuecomment-1387199182 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5309: YARN-11419. Simplify code and improve readability

hadoop-yetus commented on PR #5309: URL: https://github.com/apache/hadoop/pull/5309#issuecomment-1387193380 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5163: HADOOP-18073. Upgrade AWS SDK to v2 in S3A [work in progress]

hadoop-yetus commented on PR #5163: URL: https://github.com/apache/hadoop/pull/5163#issuecomment-1387164859 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] steveloughran commented on pull request #3029: HADOOP-17717. Update wildfly openssl to 1.1.3.Final.

steveloughran commented on PR #3029: URL: https://github.com/apache/hadoop/pull/3029#issuecomment-1387155768 rebased into #5310 and targeting 3.3.5 so as to tick off another CVE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hadoop] steveloughran commented on pull request #5310: HADOOP-17717. Update wildfly openssl to 1.1.3.Final

steveloughran commented on PR #5310: URL: https://github.com/apache/hadoop/pull/5310#issuecomment-1387155021 s3 and azure tests in progress -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hadoop] hadoop-yetus commented on pull request #5302: YARN-11221. [Federation] Add replaceLabelsOnNodes, replaceLabelsOnNode REST APIs for Router.

hadoop-yetus commented on PR #5302: URL: https://github.com/apache/hadoop/pull/5302#issuecomment-1387107056 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] hadoop-yetus commented on pull request #5284: YARN-11218. [Federation] Add getActivities, getBulkActivities REST APIs for Router.

hadoop-yetus commented on PR #5284: URL: https://github.com/apache/hadoop/pull/5284#issuecomment-1387102811 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[GitHub] [hadoop] steveloughran commented on pull request #3029: HADOOP-17717. Update wildfly openssl to 1.1.3.Final.

steveloughran commented on PR #3029: URL: https://github.com/apache/hadoop/pull/3029#issuecomment-1387074660 rebasing for 3.3.5 with testing, as there is a CVE related to the one we ship. this is lower risk than for the 2.2 upgrade -- This is an automated message from the Apache Git

[GitHub] [hadoop] anmolanmol1234 commented on a diff in pull request #5299: Add reason in in x-ms-client-request-id on a retry API call.

anmolanmol1234 commented on code in PR #5299: URL: https://github.com/apache/hadoop/pull/5299#discussion_r1073406497 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestAbfsRestOperation.java: ## @@ -0,0 +1,289 @@ +/** + * Licensed to the

[GitHub] [hadoop] anmolanmol1234 commented on a diff in pull request #5299: Add reason in in x-ms-client-request-id on a retry API call.

anmolanmol1234 commented on code in PR #5299: URL: https://github.com/apache/hadoop/pull/5299#discussion_r1073397140 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/RetryReason.java: ## @@ -0,0 +1,176 @@ +/** + * Licensed to the Apache Software

  1   2   3   4   5   6   7   8   9   10   >