[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386178#comment-16386178
]
Hudson commented on HADOOP-13761:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13769 (See
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386098#comment-16386098
]
genericqa commented on HADOOP-13761:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386097#comment-16386097
]
Steve Loughran commented on HADOOP-13761:
-
+1 committing. I see I used the wrong JIRA name on
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386091#comment-16386091
]
genericqa commented on HADOOP-13761:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385084#comment-16385084
]
Steve Loughran commented on HADOOP-13761:
-
LGTM, just need to get rid of findbugs
+1 pending
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384246#comment-16384246
]
Aaron Fabbri commented on HADOOP-13761:
---
Findbugs seems to be smoking crack and/or
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384241#comment-16384241
]
genericqa commented on HADOOP-13761:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383164#comment-16383164
]
Aaron Fabbri commented on HADOOP-13761:
---
v12 patch attached which eliminates nested retries.
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383163#comment-16383163
]
Wangda Tan commented on HADOOP-13761:
-
Thanks [~fabbri] for help, we have last two blockers, this is
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383066#comment-16383066
]
Aaron Fabbri commented on HADOOP-13761:
---
Thanks [~leftnoteasy] I've been travelling week, so sorry
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382580#comment-16382580
]
Wangda Tan commented on HADOOP-13761:
-
[~fabbri]/[~ste...@apache.org],
Given the other blockers are
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380326#comment-16380326
]
Steve Loughran commented on HADOOP-13761:
-
My failures are HADOOP-15269; something has gone very
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376983#comment-16376983
]
Steve Loughran commented on HADOOP-13761:
-
-1
I'd committed this locally and was doing the
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376781#comment-16376781
]
genericqa commented on HADOOP-13761:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376698#comment-16376698
]
Steve Loughran commented on HADOOP-13761:
-
* ..forgot to include the wrapped-> private change in
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374834#comment-16374834
]
genericqa commented on HADOOP-13761:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374799#comment-16374799
]
Aaron Fabbri commented on HADOOP-13761:
---
Thanks.. I added some @ annotations for checkstyle but it
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374746#comment-16374746
]
Steve Loughran commented on HADOOP-13761:
-
attached: patch 010; fixes findbugs by marking one
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16374625#comment-16374625
]
Steve Loughran commented on HADOOP-13761:
-
LGTM. Like the opcontext model.
+1
just trying to
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373730#comment-16373730
]
genericqa commented on HADOOP-13761:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373534#comment-16373534
]
genericqa commented on HADOOP-13761:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373419#comment-16373419
]
Aaron Fabbri commented on HADOOP-13761:
---
Cleaning up checkstyle / findbugs now.. new patch soon.
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372426#comment-16372426
]
genericqa commented on HADOOP-13761:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372378#comment-16372378
]
genericqa commented on HADOOP-13761:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372377#comment-16372377
]
Aaron Fabbri commented on HADOOP-13761:
---
v7 patch incoming. Since last revision:
* Add some
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372014#comment-16372014
]
Aaron Fabbri commented on HADOOP-13761:
---
I will try to post an updated patch today.
{quote}
will
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369187#comment-16369187
]
Steve Loughran commented on HADOOP-13761:
-
bq. Or just call them Retry with a clarifying
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367954#comment-16367954
]
Aaron Fabbri commented on HADOOP-13761:
---
{quote}Mark up the seek/read calls with @RetryPolicy, so
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367654#comment-16367654
]
Steve Loughran commented on HADOOP-13761:
-
bq. was this part of your diff intentional or
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367653#comment-16367653
]
Steve Loughran commented on HADOOP-13761:
-
Spent a lot of time staring at that read code, good
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366675#comment-16366675
]
genericqa commented on HADOOP-13761:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366647#comment-16366647
]
Aaron Fabbri commented on HADOOP-13761:
---
About to post v6 patch. Changes from v5:
- Run
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366622#comment-16366622
]
Aaron Fabbri commented on HADOOP-13761:
---
[~ste...@apache.org] was this part of your diff
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366433#comment-16366433
]
Aaron Fabbri commented on HADOOP-13761:
---
[~ste...@apache.org] on your question about changing the
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366211#comment-16366211
]
Aaron Fabbri commented on HADOOP-13761:
---
Your changes all look straightforward, thanks. I can
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366200#comment-16366200
]
genericqa commented on HADOOP-13761:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366140#comment-16366140
]
Steve Loughran commented on HADOOP-13761:
-
submitted. Other than the big q around the read()
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366138#comment-16366138
]
Steve Loughran commented on HADOOP-13761:
-
I think you forgot to hit the submit button. I do
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365068#comment-16365068
]
Aaron Fabbri commented on HADOOP-13761:
---
tested in us-west-2, with and without s3guard.
>
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365059#comment-16365059
]
Aaron Fabbri commented on HADOOP-13761:
---
v4 patch: v3 was missing a couple of chunks.
> S3Guard:
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365040#comment-16365040
]
Aaron Fabbri commented on HADOOP-13761:
---
Just posted v3 patch.
{noformat}
Feedback from previous
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364725#comment-16364725
]
Aaron Fabbri commented on HADOOP-13761:
---
Finishing up the fail-on-read after open() retry stuff..
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363852#comment-16363852
]
Steve Loughran commented on HADOOP-13761:
-
I'll call that a success. Is the patch ready to go
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363517#comment-16363517
]
Aaron Fabbri commented on HADOOP-13761:
---
Some entertaining logs from the new scale test introduced
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357386#comment-16357386
]
Steve Loughran commented on HADOOP-13761:
-
I was looking at the input stream retry logic in the
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356378#comment-16356378
]
Aaron Fabbri commented on HADOOP-13761:
---
Thanks for the feedback on the scale test patch
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356048#comment-16356048
]
Steve Loughran commented on HADOOP-13761:
-
I've not seen that exception since; it was on ASF
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341807#comment-16341807
]
Aaron Fabbri commented on HADOOP-13761:
---
v2 patch is same as v1 (just a test which tries to
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340137#comment-16340137
]
Aaron Fabbri commented on HADOOP-13761:
---
Attached v1 RFC patch that just adds a test that attempts
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338852#comment-16338852
]
Aaron Fabbri commented on HADOOP-13761:
---
Wrote a test to check above hypothesis on batch size vs.
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338609#comment-16338609
]
Aaron Fabbri commented on HADOOP-13761:
---
{quote}
Managed to break tests when working with a bucket
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328003#comment-16328003
]
Aaron Fabbri commented on HADOOP-13761:
---
[~ste...@apache.org] sure.
> S3Guard: implement retries
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325113#comment-16325113
]
Steve Loughran commented on HADOOP-13761:
-
Aaron: you got time to look @ this?
> S3Guard:
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322178#comment-16322178
]
Steve Loughran commented on HADOOP-13761:
-
+think we could add an annotation
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321643#comment-16321643
]
Aaron Fabbri commented on HADOOP-13761:
---
Reminder comment here: We should also:
- Update
[
https://issues.apache.org/jira/browse/HADOOP-13761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278672#comment-16278672
]
Steve Loughran commented on HADOOP-13761:
-
pulling HADOOP-15035 in here, which adds the extra
56 matches
Mail list logo
