[
https://issues.apache.org/jira/browse/HADOOP-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193952#comment-16193952
]
Wangda Tan commented on HADOOP-13835:
-
Pushed to branch-2, thanks [~vvasudev] and review from
[
https://issues.apache.org/jira/browse/HADOOP-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190844#comment-16190844
]
Akira Ajisaka commented on HADOOP-13835:
LGTM, +1. Thanks [~vvasudev].
> Move Google Test
[
https://issues.apache.org/jira/browse/HADOOP-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190836#comment-16190836
]
Varun Vasudev commented on HADOOP-13835:
[~ajisakaa] - any chance you can take a look at this
[
https://issues.apache.org/jira/browse/HADOOP-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189478#comment-16189478
]
Hadoop QA commented on HADOOP-13835:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189401#comment-16189401
]
Varun Vasudev commented on HADOOP-13835:
[~ajisakaa] - can you please review the latest patch
[
https://issues.apache.org/jira/browse/HADOOP-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137478#comment-16137478
]
Wangda Tan commented on HADOOP-13835:
-
[~vvasudev],
I may not have chance to do this at least in
[
https://issues.apache.org/jira/browse/HADOOP-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136787#comment-16136787
]
Varun Vasudev commented on HADOOP-13835:
[~leftnoteasy] - did you get a chance to do this? Can
[
https://issues.apache.org/jira/browse/HADOOP-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130157#comment-16130157
]
Akira Ajisaka commented on HADOOP-13835:
Thanks [~leftnoteasy]. I'm +1 for backporting this to
[
https://issues.apache.org/jira/browse/HADOOP-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120892#comment-16120892
]
Hadoop QA commented on HADOOP-13835:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120579#comment-16120579
]
Wangda Tan commented on HADOOP-13835:
-
[~ajisakaa], [~vvasudev], I think this patch should be
[
https://issues.apache.org/jira/browse/HADOOP-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15724622#comment-15724622
]
Varun Vasudev commented on HADOOP-13835:
Thanks for the review and commit [~ajisakaa]!
> Move
[
https://issues.apache.org/jira/browse/HADOOP-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15724400#comment-15724400
]
Hudson commented on HADOOP-13835:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10945 (See
[
https://issues.apache.org/jira/browse/HADOOP-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15722972#comment-15722972
]
Akira Ajisaka commented on HADOOP-13835:
+1, thanks [~vvasudev] for updating the patch.
> Move
[
https://issues.apache.org/jira/browse/HADOOP-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15722952#comment-15722952
]
Hadoop QA commented on HADOOP-13835:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15721866#comment-15721866
]
Akira Ajisaka commented on HADOOP-13835:
{code}
# add gtest as system library to suppress gcc
[
https://issues.apache.org/jira/browse/HADOOP-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15714448#comment-15714448
]
Hadoop QA commented on HADOOP-13835:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15713913#comment-15713913
]
Varun Vasudev commented on HADOOP-13835:
[~ajisakaa] - I think the latest patch is ready for
[
https://issues.apache.org/jira/browse/HADOOP-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15712133#comment-15712133
]
Hadoop QA commented on HADOOP-13835:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711777#comment-15711777
]
Hadoop QA commented on HADOOP-13835:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711277#comment-15711277
]
Akira Ajisaka commented on HADOOP-13835:
Would you remove the following setting in rat plugin?
[
https://issues.apache.org/jira/browse/HADOOP-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711073#comment-15711073
]
Varun Vasudev commented on HADOOP-13835:
[~ajisakaa] - can you please review the latest patch?
[
https://issues.apache.org/jira/browse/HADOOP-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708839#comment-15708839
]
Varun Vasudev commented on HADOOP-13835:
The ASF license warnings and the test failures are
[
https://issues.apache.org/jira/browse/HADOOP-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708829#comment-15708829
]
Hadoop QA commented on HADOOP-13835:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15701311#comment-15701311
]
Hadoop QA commented on HADOOP-13835:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15701033#comment-15701033
]
Varun Vasudev commented on HADOOP-13835:
[~aw] - sure. I can wait for MAPREDUCE-6743 to go in.
[
https://issues.apache.org/jira/browse/HADOOP-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15700991#comment-15700991
]
Allen Wittenauer commented on HADOOP-13835:
---
How about committing MAPREDUCE-6743 first?
>
[
https://issues.apache.org/jira/browse/HADOOP-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15700932#comment-15700932
]
Hadoop QA commented on HADOOP-13835:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15700914#comment-15700914
]
Akira Ajisaka commented on HADOOP-13835:
Thanks [~vvasudev] for the work. Would you update the
28 matches
Mail list logo
