ChenSammi commented on code in PR #4917: URL: https://github.com/apache/hadoop/pull/4917#discussion_r980927224
########## hadoop-hdfs-project/hadoop-hdfs-client/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestRequestHedgingProxyProvider.java: ########## @@ -98,9 +100,10 @@ public long[] answer(InvocationOnMock invocation) throws Throwable { final ClientProtocol badMock = Mockito.mock(ClientProtocol.class); Mockito.when(badMock.getStats()).thenThrow(new IOException("Bad mock !!")); - RequestHedgingProxyProvider<ClientProtocol> provider = - new RequestHedgingProxyProvider<>(conf, nnUri, ClientProtocol.class, - createFactory(badMock, goodMock)); + RequestHedgingProxyProvider<ClientProtocol> provider = new RequestHedgingProxyProvider<>( Review Comment: Although it looks like max 80 chars a line is not strictly enforced in test package by checkstyle check, it would be nice to still follow this rule, so that the coding style is consistent. ########## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/MiniQJMHACluster.java: ########## @@ -172,8 +172,8 @@ private Configuration initHAConf(URI journalURI, Builder builder, } // use standard failover configurations - HATestUtil.setFailoverConfigurations(conf, NAMESERVICE, nns, - ConfiguredFailoverProxyProvider.class); + HATestUtil.setFailoverConfigurations(conf, NAMESERVICE, + "org.apache.hadoop.hdfs.server.namenode.ha.RequestHedgingProxyProvider", nns); Review Comment: Could you rollback this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org