[GitHub] [hadoop] arp7 commented on issue #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-09-03 Thread GitBox
arp7 commented on issue #1225: HDDS-1909. Use new HA code for Non-HA in OM.
URL: https://github.com/apache/hadoop/pull/1225#issuecomment-527618227
 
 
   +1 to commit assuming the integration test failures are unrelated.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[GitHub] [hadoop] arp7 commented on issue #1225: HDDS-1909. Use new HA code for Non-HA in OM.

2019-09-03 Thread GitBox
arp7 commented on issue #1225: HDDS-1909. Use new HA code for Non-HA in OM.
URL: https://github.com/apache/hadoop/pull/1225#issuecomment-527617350
 
 
   Thanks @bharatviswa504. The patch looks pretty good to me.
   
   +1
   
   One remaining point was to self-terminate the OM in the RocksDB update 
failure path. It can be done in a separate jira.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org