[GitHub] [hadoop] bgaborg commented on a change in pull request #1123: HADOOP-16380 S3Guard to determine empty directory status for all non-root directories
bgaborg commented on a change in pull request #1123: HADOOP-16380 S3Guard to
determine empty directory status for all non-root directories
URL: https://github.com/apache/hadoop/pull/1123#discussion_r305812343
##
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/S3ATestUtils.java
##
@@ -818,6 +828,22 @@ public static void callQuietly(final Logger log,
return null;
}
+ /**
+ * Get a file status from S3A with the {@code needEmptyDirectoryFlag}
+ * state probed.
+ * This accesses a package-private method in the
+ * S3A filesystem.
+ * @param fs filesystem
+ * @param dir directory
+ * @return a status
+ * @throws IOException
+ */
+ public static S3AFileStatus getStatusWithEmptyDirFlag(
Review comment:
just to remind me that I have a similar method in pr so I have to rebase:
https://github.com/apache/hadoop/pull/1134/files#diff-d946bda31a9bf644846f57b45a89524dR831
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] bgaborg commented on a change in pull request #1123: HADOOP-16380 S3Guard to determine empty directory status for all non-root directories
bgaborg commented on a change in pull request #1123: HADOOP-16380 S3Guard to
determine empty directory status for all non-root directories
URL: https://github.com/apache/hadoop/pull/1123#discussion_r305812343
##
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/S3ATestUtils.java
##
@@ -818,6 +828,22 @@ public static void callQuietly(final Logger log,
return null;
}
+ /**
+ * Get a file status from S3A with the {@code needEmptyDirectoryFlag}
+ * state probed.
+ * This accesses a package-private method in the
+ * S3A filesystem.
+ * @param fs filesystem
+ * @param dir directory
+ * @return a status
+ * @throws IOException
+ */
+ public static S3AFileStatus getStatusWithEmptyDirFlag(
Review comment:
just to remind me that I have a similar method in pr so I have to rebase:
https://github.com/apache/hadoop/pull/1134/files#diff-d946bda31a9bf644846f57b45a89524dR831
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] bgaborg commented on a change in pull request #1123: HADOOP-16380 S3Guard to determine empty directory status for all non-root directories
bgaborg commented on a change in pull request #1123: HADOOP-16380 S3Guard to
determine empty directory status for all non-root directories
URL: https://github.com/apache/hadoop/pull/1123#discussion_r305809514
##
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
##
@@ -2623,7 +2609,8 @@ S3AFileStatus innerGetFileStatus(final Path f,
// Check MetadataStore, if any.
PathMetadata pm = null;
if (hasMetadataStore()) {
- pm = S3Guard.getWithTtl(metadataStore, path, ttlTimeProvider);
+ pm = S3Guard.getWithTtl(metadataStore, path, ttlTimeProvider,
+ needEmptyDirectoryFlag);
Review comment:
Good that you found this and before shipping it to a customer.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
