[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1257: HDDS-1913. Fix OzoneBucket and RpcClient APIS for acl.
bharatviswa504 commented on a change in pull request #1257: HDDS-1913. Fix
OzoneBucket and RpcClient APIS for acl.
URL: https://github.com/apache/hadoop/pull/1257#discussion_r312676316
##
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java
##
@@ -388,7 +388,9 @@ public void deleteVolume(String volumeName) throws
IOException {
@Override
public void createBucket(String volumeName, String bucketName)
throws IOException {
-createBucket(volumeName, bucketName, BucketArgs.newBuilder().build());
+// Set acls of current user.
+createBucket(volumeName, bucketName,
+BucketArgs.newBuilder().setAcls(getAclList()).build());
Review comment:
Done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1257: HDDS-1913. Fix OzoneBucket and RpcClient APIS for acl.
bharatviswa504 commented on a change in pull request #1257: HDDS-1913. Fix
OzoneBucket and RpcClient APIS for acl.
URL: https://github.com/apache/hadoop/pull/1257#discussion_r312597784
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/BucketManagerImpl.java
##
@@ -272,16 +272,6 @@ public void setBucketProperty(OmBucketArgs args) throws
IOException {
.setBucketName(oldBucketInfo.getBucketName());
bucketInfoBuilder.addAllMetadata(args.getMetadata());
- //Check ACLs to update
- if (args.getAddAcls() != null || args.getRemoveAcls() != null) {
-bucketInfoBuilder.setAcls(getUpdatedAclList(oldBucketInfo.getAcls(),
-args.getRemoveAcls(), args.getAddAcls()));
-LOG.debug("Updating ACLs for bucket: {} in volume: {}",
-bucketName, volumeName);
- } else {
-bucketInfoBuilder.setAcls(oldBucketInfo.getAcls());
Review comment:
Thanks for catching. Fixed it, and also added a test to cover this scenario.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1257: HDDS-1913. Fix OzoneBucket and RpcClient APIS for acl.
bharatviswa504 commented on a change in pull request #1257: HDDS-1913. Fix
OzoneBucket and RpcClient APIS for acl.
URL: https://github.com/apache/hadoop/pull/1257#discussion_r312597784
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/BucketManagerImpl.java
##
@@ -272,16 +272,6 @@ public void setBucketProperty(OmBucketArgs args) throws
IOException {
.setBucketName(oldBucketInfo.getBucketName());
bucketInfoBuilder.addAllMetadata(args.getMetadata());
- //Check ACLs to update
- if (args.getAddAcls() != null || args.getRemoveAcls() != null) {
-bucketInfoBuilder.setAcls(getUpdatedAclList(oldBucketInfo.getAcls(),
-args.getRemoveAcls(), args.getAddAcls()));
-LOG.debug("Updating ACLs for bucket: {} in volume: {}",
-bucketName, volumeName);
- } else {
-bucketInfoBuilder.setAcls(oldBucketInfo.getAcls());
Review comment:
Thanks for catching fixed it, and also added a test to cover this scenario.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
