[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1305: HDDS-1938. Change omPort parameter type from String to int in BasicOzoneFileSystem#createAdapter

2019-08-16 Thread GitBox 
bharatviswa504 commented on a change in pull request #1305: HDDS-1938. Change 
omPort parameter type from String to int in BasicOzoneFileSystem#createAdapter
URL: https://github.com/apache/hadoop/pull/1305#discussion_r314894101
 
 

 ##
 File path: 
hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneFileSystem.java
 ##
 @@ -113,7 +113,7 @@ public void initialize(URI name, Configuration conf) 
throws IOException {
 String remaining = matcher.groupCount() == 3 ? matcher.group(3) : null;
 
 String omHost = null;
-String omPort = String.valueOf(-1);
+int omPort = -1;
 
 Review comment:
   Thanks @smengcl for offline explanation why we need to set this.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1305: HDDS-1938. Change omPort parameter type from String to int in BasicOzoneFileSystem#createAdapter

2019-08-15 Thread GitBox 
bharatviswa504 commented on a change in pull request #1305: HDDS-1938. Change 
omPort parameter type from String to int in BasicOzoneFileSystem#createAdapter
URL: https://github.com/apache/hadoop/pull/1305#discussion_r314546738
 
 

 ##
 File path: 
hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneFileSystem.java
 ##
 @@ -113,7 +113,7 @@ public void initialize(URI name, Configuration conf) 
throws IOException {
 String remaining = matcher.groupCount() == 3 ? matcher.group(3) : null;
 
 String omHost = null;
-String omPort = String.valueOf(-1);
+int omPort = -1;
 
 Review comment:
   Minor Nit: We don't need to set it to -1.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org