[GitHub] [hadoop] holdenk commented on pull request #3312: HADOOP-17851 Support user specified content encoding for S3A
holdenk commented on pull request #3312: URL: https://github.com/apache/hadoop/pull/3312#issuecomment-917192415 re-ran the content encoding tests since those changed during code review and they pass :) For the refactoring the test into `ITestXAttrCost` I'm not super sure about that, it seems like I've got to make the file to test the rename anyways so I'm not sure we'd be saving many cycles by moving that check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] holdenk commented on pull request #3312: HADOOP-17851 Support user specified content encoding for S3A
holdenk commented on pull request #3312: URL: https://github.com/apache/hadoop/pull/3312#issuecomment-917034143 Sure, sorry about that I've been moving and just sort of dropped all of my tasks on the floor in the same way the movers did with my computers :p But I've got some cycles this weekend I can hack on this now that my desktop boots again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] holdenk commented on pull request #3312: HADOOP-17851 Support user specified content encoding for S3A
holdenk commented on pull request #3312: URL: https://github.com/apache/hadoop/pull/3312#issuecomment-902861477 I need to re-run the tests after the changes but figured I'd push to see if I'm doing the right thing around getXattr since I haven't used it before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
