liuml07 commented on pull request #2189:
URL: https://github.com/apache/hadoop/pull/2189#issuecomment-698076876
Yeah; for this checkstyle in test we can keep it as-is for the sake of code
consistency. Thanks.
This is an
liuml07 commented on pull request #2189:
URL: https://github.com/apache/hadoop/pull/2189#issuecomment-697078022
No more comments on the latest commit.
Let's wait for the QA and run failing tests locally. I'll commit shortly.
liuml07 commented on pull request #2189:
URL: https://github.com/apache/hadoop/pull/2189#issuecomment-697078022
No more comments on the latest commit.
Let's wait for the QA and run failing tests locally. I'll commit shortly.
liuml07 commented on pull request #2189:
URL: https://github.com/apache/hadoop/pull/2189#issuecomment-693756560
Sorry, I have been busy in other stuff. The recent review I have no other
comments except a few trivial ones. I'll post that and commit this week.
liuml07 commented on pull request #2189:
URL: https://github.com/apache/hadoop/pull/2189#issuecomment-690839476
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
liuml07 commented on pull request #2189:
URL: https://github.com/apache/hadoop/pull/2189#issuecomment-690839476
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
liuml07 commented on pull request #2189:
URL: https://github.com/apache/hadoop/pull/2189#issuecomment-690932868
No this is not a blocker @huangtianhua I will review (again) and commit
hopefully this week if there is no other comments. Thanks,
liuml07 commented on pull request #2189:
URL: https://github.com/apache/hadoop/pull/2189#issuecomment-690839476
Will check again later this week.
Ideally we can get a clean QA. Could you check the test failures and make
sure they are not related? Thanks,
