[GitHub] [hadoop] nandakumar131 commented on a change in pull request #1410: HDDS-2076. Read fails because the block cannot be located in the container
nandakumar131 commented on a change in pull request #1410: HDDS-2076. Read fails because the block cannot be located in the container URL: https://github.com/apache/hadoop/pull/1410#discussion_r322181017 ## File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/TarContainerPacker.java ## @@ -58,6 +59,8 @@ private static final String CONTAINER_FILE_NAME = "container.yaml"; + private static final String CONTAINER_BCSID = "BCSID"; Review comment: We don't need this change. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] nandakumar131 commented on a change in pull request #1410: HDDS-2076. Read fails because the block cannot be located in the container
nandakumar131 commented on a change in pull request #1410: HDDS-2076. Read fails because the block cannot be located in the container URL: https://github.com/apache/hadoop/pull/1410#discussion_r322181109 ## File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/TarContainerPacker.java ## @@ -30,6 +30,7 @@ import java.nio.file.Paths; import java.util.stream.Collectors; +import com.google.common.primitives.Longs; Review comment: Not needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] nandakumar131 commented on a change in pull request #1410: HDDS-2076. Read fails because the block cannot be located in the container
nandakumar131 commented on a change in pull request #1410: HDDS-2076. Read fails because the block cannot be located in the container URL: https://github.com/apache/hadoop/pull/1410#discussion_r322011257 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestContainerReplication.java ## @@ -0,0 +1,199 @@ +package org.apache.hadoop.ozone.client.rpc; Review comment: License is missing This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] nandakumar131 commented on a change in pull request #1410: HDDS-2076. Read fails because the block cannot be located in the container
nandakumar131 commented on a change in pull request #1410: HDDS-2076. Read fails because the block cannot be located in the container URL: https://github.com/apache/hadoop/pull/1410#discussion_r322011377 ## File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/TarContainerPacker.java ## @@ -235,6 +238,16 @@ private void includePath(String containerPath, String subdir, } } + private void includeBCSID(ArchiveOutputStream archiveOutputStream, long bcsID) Review comment: `includeBCSID` is not used anywhere This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] nandakumar131 commented on a change in pull request #1410: HDDS-2076. Read fails because the block cannot be located in the container
nandakumar131 commented on a change in pull request #1410: HDDS-2076. Read fails because the block cannot be located in the container URL: https://github.com/apache/hadoop/pull/1410#discussion_r322011275 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestContainerReplication.java ## @@ -0,0 +1,199 @@ +package org.apache.hadoop.ozone.client.rpc; + +import org.apache.hadoop.hdds.client.BlockID; Review comment: Unused import This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
