[GitHub] [hadoop] pjfanning commented on pull request #4940: HADOOP-18469: centralise XML parser creation in XMLUtils

2022-10-06 Thread GitBox
pjfanning commented on PR #4940: URL: https://github.com/apache/hadoop/pull/4940#issuecomment-1270290164 > thanks, happy with the explanation. > > I'm +1 for the change. there is one suggestion, use AbstractHadoopTestBase, but its not a blocker for this patch. if you don't want to

[GitHub] [hadoop] pjfanning commented on pull request #4940: HADOOP-18469: centralise XML parser creation in XMLUtils

2022-09-27 Thread GitBox
pjfanning commented on PR #4940: URL: https://github.com/apache/hadoop/pull/4940#issuecomment-1259867954 @steveloughran I can rework this to just have the hadoop-common changes and can do other PRs to uptake this in yarn, hdfs, etc. -- This is an automated message from the Apache Git