[GitHub] [hadoop] slfan1989 commented on pull request #4335: HADOOP-18249. Fix getUri() in HttpRequest has been deprecated.

2022-05-24 Thread GitBox


slfan1989 commented on PR #4335:
URL: https://github.com/apache/hadoop/pull/4335#issuecomment-1136439304

   @hemanthboyina Thank you very much for your help reviewing the code!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[GitHub] [hadoop] slfan1989 commented on pull request #4335: HADOOP-18249. Fix getUri() in HttpRequest has been deprecated.

2022-05-24 Thread GitBox


slfan1989 commented on PR #4335:
URL: https://github.com/apache/hadoop/pull/4335#issuecomment-1136041900

   @hemanthboyina please help me to review the code again, thank you very much.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[GitHub] [hadoop] slfan1989 commented on pull request #4335: HADOOP-18249. Fix getUri() in HttpRequest has been deprecated.

2022-05-20 Thread GitBox


slfan1989 commented on PR #4335:
URL: https://github.com/apache/hadoop/pull/4335#issuecomment-1133430744

   > thanks for the PR @slfan1989 , there were few more places where 
httprequest getUri() is used, can you modify them as well ?
   
   Thanks @hemanthboyina  , I'll try to fix the other locations.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org