[GitHub] [hadoop] smengcl commented on issue #1218: HDDS-1891. Ozone fs shell command should work with default port when port number is not specified

2019-08-09 Thread GitBox 
smengcl commented on issue #1218: HDDS-1891. Ozone fs shell command should work 
with default port when port number is not specified
URL: https://github.com/apache/hadoop/pull/1218#issuecomment-519896335
 
 
   Thanks for the comment @adoroszlai ! Just posted a new commit to address 
both checkstyle issues.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] smengcl commented on issue #1218: HDDS-1891. Ozone fs shell command should work with default port when port number is not specified

2019-08-08 Thread GitBox 
smengcl commented on issue #1218: HDDS-1891. Ozone fs shell command should work 
with default port when port number is not specified
URL: https://github.com/apache/hadoop/pull/1218#issuecomment-519760099
 
 
   /retest


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] smengcl commented on issue #1218: HDDS-1891. Ozone fs shell command should work with default port when port number is not specified

2019-08-08 Thread GitBox 
smengcl commented on issue #1218: HDDS-1891. Ozone fs shell command should work 
with default port when port number is not specified
URL: https://github.com/apache/hadoop/pull/1218#issuecomment-519760075
 
 
   Fixed the code and the unit test. The following fs commands all work as I 
tested in docker:
   ```bash
   ozone fs -put README.txt o3fs:///
   ozone fs -ls /
   ozone fs -ls o3fs://bucket.volume.om/
   ozone fs -ls o3fs://bucket.volume.om:9862/
   ozone fs -ls o3fs://bucket.volume/
   ozone fs -get /README.txt R.txt
   ozone fs -get o3fs://bucket.volume.om/README.txt R2.txt
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] smengcl commented on issue #1218: HDDS-1891. Ozone fs shell command should work with default port when port number is not specified

2019-08-08 Thread GitBox 
smengcl commented on issue #1218: HDDS-1891. Ozone fs shell command should work 
with default port when port number is not specified
URL: https://github.com/apache/hadoop/pull/1218#issuecomment-519737497
 
 
   > > One more comment, I think we should make a similar change in 
BasicOzoneFileSystem.java.
   > > See, can we have a some utility method, which can be used across 2 
classes.
   > 
   > OzoneFileSystem extends BasicOzoneFileSystem, so this has been taken care. 
Just test it out locally.
   
   While I'm testing it in a docker-compose cluster, it seems that the change 
of `authority` 
[here](https://github.com/apache/hadoop/pull/1218/commits/ab93f4bc3fd8d2acf31dac5bbf79c49546eccacd#diff-e48c4ce6b86d4a33c3f38ba8d6d06ea3R129)
 might have broken something. It throws error:
   {code}
   bash-4.2$ ozone fs -ls o3fs://bucket.volume.om/
   -ls: Wrong FS: o3fs://bucket.volume.om/, expected: 
o3fs://bucket.volume.om:9862
   ...
   {code}
   
   After I commented out this line, compile and re-test, it works again:
   {code}
   bash-4.2$ ozone fs -ls o3fs://bucket.volume.om/
   Found 1 items
   -rw-rw-rw-   1 hadoop hadoop   1485 1970-01-01 00:46 
o3fs://bucket.volume.om/README.txt
   {code}
   
   Investigating.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org