[GitHub] [hadoop] swamirishi commented on pull request #2133: HADOOP-17122: Preserving Directory Attributes in DistCp with Atomic Copy

2020-08-19 Thread GitBox
swamirishi commented on pull request #2133: URL: https://github.com/apache/hadoop/pull/2133#issuecomment-676516716 @steveloughran I have received a +1. There are no issues. Can you merge the code? This is an automated

[GitHub] [hadoop] swamirishi commented on pull request #2133: HADOOP-17122: Preserving Directory Attributes in DistCp with Atomic Copy

2020-08-19 Thread GitBox
swamirishi commented on pull request #2133: URL: https://github.com/apache/hadoop/pull/2133#issuecomment-676060117 @steveloughran I have made the required changes to fix checksum issue. It worked on local test-patch. Can the code be merged?

[GitHub] [hadoop] swamirishi commented on pull request #2133: HADOOP-17122: Preserving Directory Attributes in DistCp with Atomic Copy

2020-08-17 Thread GitBox
swamirishi commented on pull request #2133: URL: https://github.com/apache/hadoop/pull/2133#issuecomment-674734152 @steveloughran I have made the required changes. Can the code be merged? This is an automated message from

[GitHub] [hadoop] swamirishi commented on pull request #2133: HADOOP-17122: Preserving Directory Attributes in DistCp with Atomic Copy

2020-08-13 Thread GitBox
swamirishi commented on pull request #2133: URL: https://github.com/apache/hadoop/pull/2133#issuecomment-673286070 @steveloughran I have removed the whitespace from the new line I added. Can we get the code merged? This is

[GitHub] [hadoop] swamirishi commented on pull request #2133: HADOOP-17122: Preserving Directory Attributes in DistCp with Atomic Copy

2020-08-10 Thread GitBox
swamirishi commented on pull request #2133: URL: https://github.com/apache/hadoop/pull/2133#issuecomment-671476116 > @swamirishi while you are looking at distcp, have a look at # and see what you think about it...its test code is pretty close to yours, the functionality orthoganal

[GitHub] [hadoop] swamirishi commented on pull request #2133: HADOOP-17122: Preserving Directory Attributes in DistCp with Atomic Copy

2020-08-07 Thread GitBox
swamirishi commented on pull request #2133: URL: https://github.com/apache/hadoop/pull/2133#issuecomment-670827651 @steveloughran Did you take a look at this? This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] swamirishi commented on pull request #2133: HADOOP-17122: Preserving Directory Attributes in DistCp with Atomic Copy

2020-08-07 Thread GitBox
swamirishi commented on pull request #2133: URL: https://github.com/apache/hadoop/pull/2133#issuecomment-670593741 Sure Thanks This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hadoop] swamirishi commented on pull request #2133: HADOOP-17122: Preserving Directory Attributes in DistCp with Atomic Copy

2020-08-04 Thread GitBox
swamirishi commented on pull request #2133: URL: https://github.com/apache/hadoop/pull/2133#issuecomment-668720725 @steveloughran Please take a look at this PR. This is an automated message from the Apache Git Service. To