[GitHub] [hadoop] vinayakumarb commented on a change in pull request #2026: HADOOP-17046. Support downstreams' existing Hadoop-rpc implementations using non-shaded protobuf classes

2020-06-09 Thread GitBox
vinayakumarb commented on a change in pull request #2026: URL: https://github.com/apache/hadoop/pull/2026#discussion_r437853175 ## File path:

[GitHub] [hadoop] vinayakumarb commented on a change in pull request #2026: HADOOP-17046. Support downstreams' existing Hadoop-rpc implementations using non-shaded protobuf classes

2020-06-07 Thread GitBox
vinayakumarb commented on a change in pull request #2026: URL: https://github.com/apache/hadoop/pull/2026#discussion_r436451465 ## File path: hadoop-common-project/hadoop-common/pom.xml ## @@ -1015,7 +1031,81 @@ - + + + aarch64 + +

[GitHub] [hadoop] vinayakumarb commented on a change in pull request #2026: HADOOP-17046. Support downstreams' existing Hadoop-rpc implementations using non-shaded protobuf classes

2020-06-07 Thread GitBox
vinayakumarb commented on a change in pull request #2026: URL: https://github.com/apache/hadoop/pull/2026#discussion_r436449548 ## File path: hadoop-common-project/hadoop-common/pom.xml ## @@ -1015,7 +1031,81 @@ - + + + aarch64 + +

[GitHub] [hadoop] vinayakumarb commented on a change in pull request #2026: HADOOP-17046. Support downstreams' existing Hadoop-rpc implementations using non-shaded protobuf classes

2020-06-03 Thread GitBox
vinayakumarb commented on a change in pull request #2026: URL: https://github.com/apache/hadoop/pull/2026#discussion_r434410613 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java ## @@ -433,7 +438,15 @@ public

[GitHub] [hadoop] vinayakumarb commented on a change in pull request #2026: HADOOP-17046. Support downstreams' existing Hadoop-rpc implementations using non-shaded protobuf classes

2020-06-02 Thread GitBox
vinayakumarb commented on a change in pull request #2026: URL: https://github.com/apache/hadoop/pull/2026#discussion_r434322138 ## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java ## @@ -1295,6 +1296,22 @@ static URI trimUri(URI

[GitHub] [hadoop] vinayakumarb commented on a change in pull request #2026: HADOOP-17046. Support downstreams' existing Hadoop-rpc implementations using non-shaded protobuf classes

2020-06-02 Thread GitBox
vinayakumarb commented on a change in pull request #2026: URL: https://github.com/apache/hadoop/pull/2026#discussion_r434320866 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngineCallback.java ## @@ -18,7 +18,7 @@ package