Re: [PR] Add getEnclosingRoot API to FileSystem interface and all implementations [hadoop]

2023-12-05 Thread via GitHub
mccormickt12 commented on PR #6196: URL: https://github.com/apache/hadoop/pull/6196#issuecomment-1842026956 closing since this was successfully backported https://github.com/apache/hadoop/pull/6262 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Add getEnclosingRoot API to FileSystem interface and all implementations [hadoop]

2023-12-05 Thread via GitHub
mccormickt12 closed pull request #6196: Add getEnclosingRoot API to FileSystem interface and all implementations URL: https://github.com/apache/hadoop/pull/6196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Add getEnclosingRoot API to FileSystem interface and all implementations [hadoop]

2023-10-21 Thread via GitHub
hadoop-yetus commented on PR #6196: URL: https://github.com/apache/hadoop/pull/6196#issuecomment-1773898860 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] Add getEnclosingRoot API to FileSystem interface and all implementations [hadoop]

2023-10-18 Thread via GitHub
mccormickt12 commented on code in PR #6196: URL: https://github.com/apache/hadoop/pull/6196#discussion_r1364661597 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGetEnclosingRoot.java: ## @@ -0,0 +1,94 @@ +/** + * Licensed to the Apache Software

Re: [PR] Add getEnclosingRoot API to FileSystem interface and all implementations [hadoop]

2023-10-18 Thread via GitHub
goiri commented on code in PR #6196: URL: https://github.com/apache/hadoop/pull/6196#discussion_r1364560482 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestGetEnclosingRoot.java: ## @@ -0,0 +1,94 @@ +/** + * Licensed to the Apache Software

Re: [PR] Add getEnclosingRoot API to FileSystem interface and all implementations [hadoop]

2023-10-18 Thread via GitHub
mccormickt12 commented on PR #6196: URL: https://github.com/apache/hadoop/pull/6196#issuecomment-1769333707 > Can you link the JIRA in the title and description too? I can, i think i actually need to close this in leu of https://github.com/apache/hadoop/pull/6198 and then open a new

Re: [PR] Add getEnclosingRoot API to FileSystem interface and all implementations [hadoop]

2023-10-18 Thread via GitHub
goiri commented on PR #6196: URL: https://github.com/apache/hadoop/pull/6196#issuecomment-1769331156 Can you link the JIRA in the title and description too? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Add getEnclosingRoot API to FileSystem interface and all implementations [hadoop]

2023-10-17 Thread via GitHub
hadoop-yetus commented on PR #6196: URL: https://github.com/apache/hadoop/pull/6196#issuecomment-1767405119 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] Add getEnclosingRoot API to FileSystem interface and all implementations [hadoop]

2023-10-17 Thread via GitHub
mccormickt12 commented on PR #6196: URL: https://github.com/apache/hadoop/pull/6196#issuecomment-1766980795 cc @simbadzina @goiri (This is related to the [old pr](https://github.com/apache/hadoop/pull/4967/files#diff-a07f38553cfc52416c1a9bc82110837c8d0c078a0f1ef9c62c290d7de5b3e745) I