Re: [PR] HADOOP-18711. Upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code [hadoop]

2023-12-07 Thread via GitHub
pjfanning commented on PR #5639: URL: https://github.com/apache/hadoop/pull/5639#issuecomment-1846123497 #6201 was merged - this can be closed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] HADOOP-18711. upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code. [hadoop]

2023-10-26 Thread via GitHub
ayushtkn merged PR #6201: URL: https://github.com/apache/hadoop/pull/6201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HADOOP-18711. upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code. [hadoop]

2023-10-25 Thread via GitHub
hadoop-yetus commented on PR #6201: URL: https://github.com/apache/hadoop/pull/6201#issuecomment-1779708179 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-18711. upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code. [hadoop]

2023-10-24 Thread via GitHub
hadoop-yetus commented on PR #6201: URL: https://github.com/apache/hadoop/pull/6201#issuecomment-1776722304 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-18711. upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code. [hadoop]

2023-10-21 Thread via GitHub
hadoop-yetus commented on PR #6201: URL: https://github.com/apache/hadoop/pull/6201#issuecomment-1773945798 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-18711. upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code. [hadoop]

2023-10-18 Thread via GitHub
hadoop-yetus commented on PR #6201: URL: https://github.com/apache/hadoop/pull/6201#issuecomment-1769588697 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-18711. Upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code [hadoop]

2023-10-18 Thread via GitHub
hadoop-yetus commented on PR #5639: URL: https://github.com/apache/hadoop/pull/5639#issuecomment-1769575285 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HADOOP-18711. Upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code [hadoop]

2023-10-18 Thread via GitHub
pjfanning commented on PR #5639: URL: https://github.com/apache/hadoop/pull/5639#issuecomment-1768160519 @rohit-kb I created https://github.com/apache/hadoop/pull/6201 - feel free to continue with this PR but I created 6201 just in case. -- This is an automated message from the Apache

Re: [PR] HADOOP-18711. Upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code [hadoop]

2023-10-18 Thread via GitHub
rohit-kb commented on PR #5639: URL: https://github.com/apache/hadoop/pull/5639#issuecomment-1768153646 @pjfanning my bad, kind of went a bit overboard while avoiding those blanks related checks assuming that these changes won't matter. Also, a bit doubtful regarding the rebase, I

Re: [PR] HADOOP-18711. Upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code [hadoop]

2023-10-18 Thread via GitHub
pjfanning commented on PR #5639: URL: https://github.com/apache/hadoop/pull/5639#issuecomment-1768135406 @rohit-kb could you remove the edits to the 2 pom files? You have 4 edited files in this PR while you only need 2 (the ones that change the nimbus version). See

Re: [PR] HADOOP-18711. Upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code [hadoop]

2023-10-18 Thread via GitHub
rohit-kb commented on PR #5639: URL: https://github.com/apache/hadoop/pull/5639#issuecomment-1767946931 Sure @pjfanning, will do, thanks for the info. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] HADOOP-18711. Upgrade nimbus jwt jar due to issues in its embedded shaded json-smart code [hadoop]

2023-10-17 Thread via GitHub
pjfanning commented on PR #5639: URL: https://github.com/apache/hadoop/pull/5639#issuecomment-1766712078 @rohit-kb could you rebase this? The issue with the module-info classes has recently been resolved in branch-3.3. -- This is an automated message from the Apache Git Service. To