Re: [PR] YARN-11616. Fast fail for NodeConstraintParser when having multi attribute kvs [hadoop]

2023-11-23 Thread via GitHub
zhuqi-lucas merged PR #6282: URL: https://github.com/apache/hadoop/pull/6282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] YARN-11616. Fast fail for NodeConstraintParser when having multi attribute kvs [hadoop]

2023-11-21 Thread via GitHub
slfan1989 commented on PR #6282: URL: https://github.com/apache/hadoop/pull/6282#issuecomment-1821877401 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] YARN-11616. Fast fail for NodeConstraintParser when having multi attribute kvs [hadoop]

2023-11-20 Thread via GitHub
hadoop-yetus commented on PR #6282: URL: https://github.com/apache/hadoop/pull/6282#issuecomment-1818647088 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] YARN-11616. Fast fail for NodeConstraintParser when having multi attribute kvs [hadoop]

2023-11-20 Thread via GitHub
zuston commented on PR #6282: URL: https://github.com/apache/hadoop/pull/6282#issuecomment-1818425405 Could you help review this ? @slfan1989 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] YARN-11616. Fast fail for NodeConstraintParser when having multi attribute kvs [hadoop]

2023-11-20 Thread via GitHub
zuston opened a new pull request, #6282: URL: https://github.com/apache/hadoop/pull/6282 ### Description of PR In the `NodeConstraintParser`, it won't throw exception when multiple attribute kvs are specified. It will return incorrect placement constraint, which will mislead users.