[ 
https://issues.apache.org/jira/browse/HADOOP-14260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16122623#comment-16122623
 ] 

Sean Mackrory edited comment on HADOOP-14260 at 8/11/17 12:53 AM:
------------------------------------------------------------------

+1, pending a clean Yetus run.

As a side-note, seeing the redactor applied to this tool made me wonder if 
redaction should be able to be turned off via a config, if someone was 
debugging something involving redacted properties. But then I remembered that 
the list of regexes that get disabled is configurable, so you could always 
temporarily exclude one if you really needed to. I don't think we should make 
that more accessible - but if anyone is wondering how to debug redacted 
properties, that's what I'd recommend.

edit: which of course I just saw you called out in your 2nd bullet point. Good 
one :)


was (Author: mackrorysd):
+1, pending a clean Yetus run.

As a side-note, seeing the redactor applied to this tool made me wonder if 
redaction should be able to be turned off via a config, if someone was 
debugging something involving redacted properties. But then I remembered that 
the list of regexes that get disabled is configurable, so you could always 
temporarily exclude one if you really needed to. I don't think we should make 
that more accessible - but if anyone is wondering how to debug redacted 
properties, that's what I'd recommend.

> Configuration.dumpConfiguration should redact sensitive information
> -------------------------------------------------------------------
>
>                 Key: HADOOP-14260
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14260
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf, security
>    Affects Versions: 2.6.0
>            Reporter: Vihang Karajgaonkar
>            Assignee: John Zhuge
>         Attachments: HADOOP-14260.001.patch
>
>
> Configuration.dumpConfiguration dumps all the configuration values without 
> redacting the sensitive configurations stored in the Configuration object.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to