[jira] [Comment Edited] (HADOOP-14676) Wrong default value for "fs.df.interval"
[
https://issues.apache.org/jira/browse/HADOOP-14676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16105846#comment-16105846
]
xiangguang zheng edited comment on HADOOP-14676 at 7/31/17 10:25 PM:
-
The manual steps I did to verify:
1. compile and run the unit test towards hadoop common module. When I run the
test, there were 9 test failure and 1 test error. But I have verified that
those failure and errors existed in hadoop trunk before I made any changes, and
none of test failure/error was related to this patch
2. Run local debugger on MiniHadoopClusterManager Class to test if DF load the
correct default interval value(fs.df.interval was removed from core-default.xml
when testing so that DF constructor was forced to read value from Constant
CommonConfigurationKeysPublic.FS_DF_INTERVAL_DEFAULT instead of from
core-default.xml
was (Author: zhengxg3):
The manual steps I did to verify:
1. compile and run the unit test towards hadoop common module. When I run the
test, there were 9 test failure and 1 test error. But I have verified that
those failure and errors existed in hadoop trunk before I made any changes, and
none of test failure/error was related to this patch
2. Run local debugger in on MiniHadoopClusterManager Class to test if DF load
the correct default interval value(fs.df.interval was removed from
core-default.xml when testing so that DF constructor was forced to read value
from Constant CommonConfigurationKeysPublic.FS_DF_INTERVAL_DEFAULT instead of
from core-default.xml
> Wrong default value for "fs.df.interval"
>
>
> Key: HADOOP-14676
> URL: https://issues.apache.org/jira/browse/HADOOP-14676
> Project: Hadoop Common
> Issue Type: Bug
> Components: common, conf, fs
>Affects Versions: 2.6.1
>Reporter: Konstantin Shvachko
>Assignee: xiangguang zheng
> Attachments: HADOOP-14676.001.patch
>
>
> According to {{core-default.xml}} the default value of {{fs.df.interval = 60
> sec}}. But the implementation of {{DF}} substitutes 3 sec instead. The
> problem is that {{DF}} uses outdated constant {{DF.DF_INTERVAL_DEFAULT}}
> instead of the correct one
> {{CommonConfigurationKeysPublic.FS_DF_INTERVAL_DEFAULT}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HADOOP-14676) Wrong default value for "fs.df.interval"
[
https://issues.apache.org/jira/browse/HADOOP-14676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16105846#comment-16105846
]
xiangguang zheng edited comment on HADOOP-14676 at 7/31/17 10:23 PM:
-
The manual steps I did to verify:
1. compile and run the unit test towards hadoop common module. When I run the
test, there were 9 test failure and 1 test error. But I have verified that
those failure and errors existed in hadoop trunk before I made any changes, and
none of test failure/error was related to this patch
2. Run local debugger in on MiniHadoopClusterManager Class to test if DF load
the correct default interval value(fs.df.interval was removed from
core-default.xml when testing so that DF constructor was forced to read value
from Constant CommonConfigurationKeysPublic.FS_DF_INTERVAL_DEFAULT instead of
from core-default.xml
was (Author: zhengxg3):
The manual steps I did to verify is to compile and run the unit test towards
hadoop common module. When I run the test, there were 9 test failure and 1 test
error. But I have verified that those failure and errors existed in hadoop
trunk before I made any changes, and none of test failure/error was related to
this patch
> Wrong default value for "fs.df.interval"
>
>
> Key: HADOOP-14676
> URL: https://issues.apache.org/jira/browse/HADOOP-14676
> Project: Hadoop Common
> Issue Type: Bug
> Components: common, conf, fs
>Affects Versions: 2.6.1
>Reporter: Konstantin Shvachko
>Assignee: xiangguang zheng
> Attachments: HADOOP-14676.001.patch
>
>
> According to {{core-default.xml}} the default value of {{fs.df.interval = 60
> sec}}. But the implementation of {{DF}} substitutes 3 sec instead. The
> problem is that {{DF}} uses outdated constant {{DF.DF_INTERVAL_DEFAULT}}
> instead of the correct one
> {{CommonConfigurationKeysPublic.FS_DF_INTERVAL_DEFAULT}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HADOOP-14676) Wrong default value for "fs.df.interval"
[
https://issues.apache.org/jira/browse/HADOOP-14676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16105363#comment-16105363
]
Erik Krogen edited comment on HADOOP-14676 at 7/28/17 5:49 PM:
---
Hey [~zhengxg3], thanks for working on this. A few things:
* When you upload the patch you should put a version name in it, e.g.
HADOOP-14676.000.patch. This helps us to track the revisions of the patch as we
go through the review-update cycle. Also, I think it might be required for
Jenkins to run the precommit build against your patch.
* I don't think {{DF.DF_INTERVAL_DEFAULT}} is used anywhere anymore, can you
confirm this and if so then delete it altogether?
* Please don't use wildcard ({{*}}) imports.
* Keep line length below 80 characters to pass checkstyle.
was (Author: xkrogen):
Hey [~zhengxg3], thanks for working on this. A few things:
* When you upload the patch you should put a version name in it, e.g.
HADOOP-14676.000.patch. This helps us to track the revisions of the patch as we
go through the review-update cycle. Also, I think it might be required for
Jenkins to run the precommit build against your patch.
* I don't think {{DF.DF_INTERVAL_DEFAULT}} is used anywhere anymore, can you
confirm this and if so then delete it altogether?
* Please don't use wildcard ({{*}}) imports.
> Wrong default value for "fs.df.interval"
>
>
> Key: HADOOP-14676
> URL: https://issues.apache.org/jira/browse/HADOOP-14676
> Project: Hadoop Common
> Issue Type: Bug
> Components: common, conf, fs
>Affects Versions: 2.6.1
>Reporter: Konstantin Shvachko
>Assignee: xiangguang zheng
> Attachments: HADOOP-14676.patch
>
>
> According to {{core-default.xml}} the default value of {{fs.df.interval = 60
> sec}}. But the implementation of {{DF}} substitutes 3 sec instead. The
> problem is that {{DF}} uses outdated constant {{DF.DF_INTERVAL_DEFAULT}}
> instead of the correct one
> {{CommonConfigurationKeysPublic.FS_DF_INTERVAL_DEFAULT}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
