[ https://issues.apache.org/jira/browse/HADOOP-14873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168717#comment-16168717 ]
Wangda Tan edited comment on HADOOP-14873 at 9/16/17 12:27 AM: --------------------------------------------------------------- (Edit: 5:16 pm 9/15/2017 PDT): Removed OSX build, it's very misleading. Thanks [~aw] for creating the JIRA, copy-paste comments from HADOOP-14670: I just checked changes of this JIRA doesn't relate to issues I saw, I tried to revert this patch but issue is still the same. It seems the set (CMAKE_C_STANDARD) doesn't work for the nodemanager project. I hardcoded to change set (CMAKE_C_STANDARD 99) to set (CMAKE_C_STANDARD 90) in nodemanager project. (Since we have code uses C99-only syntax, so changing to 90 should fail build). {code} for (int i = 0; i < n_minor_devices_to_block; i++) { // ... } {code} I tried on my environment: 1) Centos 6, cmake version 3.1.0, gcc 4.4.7 When specify standards (CMAKE_C_STANDARD 90/99) in CMakeList.txt, all fail. When specify in commandline: - {{mvn -DskipTests -Dcontainer-executor.additional_cflags='-std=c90' -Pnative clean install}} (Failed) - {{mvn -DskipTests -Dcontainer-executor.additional_cflags='-std=c99' -Pnative clean install}} (Succeeded) was (Author: leftnoteasy): Thanks [~aw] for creating the JIRA, copy-paste comments from HADOOP-14670: I just checked changes of this JIRA doesn't relate to issues I saw, I tried to revert this patch but issue is still the same. It seems the set (CMAKE_C_STANDARD) doesn't work for the nodemanager project. I hardcoded to change set (CMAKE_C_STANDARD 99) to set (CMAKE_C_STANDARD 90) in nodemanager project. (Since we have code uses C99-only syntax, so changing to 90 should fail build). I tried on two different environment: 1) Centos 6, cmake version 3.1.0, gcc 4.4.7 For both 99/90 standard, all fail. 2) OSX v10.12.4, cmake version 3.5.2, cc = "Apple LLVM version 8.1.0 (clang-802.0.42)". For both 99/90 standard, all succeeded. At least for the for loop in gpu-module.c is C99 only: {code} for (int i = 0; i < n_minor_devices_to_block; i++) { // ... } {code} > CentOS 6.6 + gcc 4.4 + cmake 3.1 don't get C99 > ---------------------------------------------- > > Key: HADOOP-14873 > URL: https://issues.apache.org/jira/browse/HADOOP-14873 > Project: Hadoop Common > Issue Type: Bug > Components: build > Affects Versions: 3.0.0-beta1 > Reporter: Allen Wittenauer > Assignee: Allen Wittenauer > Priority: Critical > > C99 mode isn't getting invoked for containter-executor on CentOS 6.6 + gcc > 4.4. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org