[jira] [Comment Edited] (HADOOP-15223) Replace Collections.EMPTY_SET and EMPTY_MAP with emptySet() and emptyMap() when available

2018-02-14 Thread fang zhenyi (JIRA) 

[ 
https://issues.apache.org/jira/browse/HADOOP-15223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363890#comment-16363890
 ] 

fang zhenyi edited comment on HADOOP-15223 at 2/14/18 12:58 PM:


Thanks [~ajisakaa] for comments.I have remove all of 
{{Collections.EMPTY_MAP}},{{Collections.EMPTY_SET}} , 
{{Collections.emptyList()}} and unnecessary {{@SuppressWarning("unchecked")}} 
annotations.Hope you can review again, thanks a lot.


was (Author: zhenyi):
Thanks [~ajisakaa] for comments.I have remove all of 
{{Collections.EMPTY_MAP}},{{Collections.EMPTY_SET}} , 
{{Collections.emptyList()}} and unnecessary 
@SuppressWarning("unchecked") annotations.Hope you can review again, 
thanks a lot.

> Replace Collections.EMPTY_SET and EMPTY_MAP with emptySet() and emptyMap() 
> when available
> -
>
> Key: HADOOP-15223
> URL: https://issues.apache.org/jira/browse/HADOOP-15223
> Project: Hadoop Common
>  Issue Type: Bug
>Reporter: Akira Ajisaka
>Assignee: fang zhenyi
>Priority: Minor
>  Labels: newbie
> Attachments: HADOOP-15223.001.patch, HADOOP-15223.002.patch
>
>
> The use of {{Collections.EMPTY_SET}} and {{Collections.EMPTY_MAP}} often 
> causes unchecked assignment and it should be replaced with 
> {{Collections.emptySet()}} and {{Collections.emptyMap()}}. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Comment Edited] (HADOOP-15223) Replace Collections.EMPTY_SET and EMPTY_MAP with emptySet() and emptyMap() when available

2018-02-14 Thread fang zhenyi (JIRA) 

[ 
https://issues.apache.org/jira/browse/HADOOP-15223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363890#comment-16363890
 ] 

fang zhenyi edited comment on HADOOP-15223 at 2/14/18 12:58 PM:


Thanks [~ajisakaa] for comments.I have remove all of 
{{Collections.EMPTY_MAP}},{{Collections.EMPTY_SET}} , 
{{Collections.emptyList()}} and unnecessary 
@SuppressWarning("unchecked") annotations.Hope you can review again, 
thanks a lot.


was (Author: zhenyi):
Thanks [~ajisakaa] for comments.I have remove all of 
\{{Collections.EMPTY_MAP}},\{{Collections.EMPTY_SET}} , 
\{{Collections.emptyList()}} and unnecessary 
@SuppressWarning("unchecked") annotations.Hope you can review again, 
thanks a lot.

> Replace Collections.EMPTY_SET and EMPTY_MAP with emptySet() and emptyMap() 
> when available
> -
>
> Key: HADOOP-15223
> URL: https://issues.apache.org/jira/browse/HADOOP-15223
> Project: Hadoop Common
>  Issue Type: Bug
>Reporter: Akira Ajisaka
>Assignee: fang zhenyi
>Priority: Minor
>  Labels: newbie
> Attachments: HADOOP-15223.001.patch, HADOOP-15223.002.patch
>
>
> The use of {{Collections.EMPTY_SET}} and {{Collections.EMPTY_MAP}} often 
> causes unchecked assignment and it should be replaced with 
> {{Collections.emptySet()}} and {{Collections.emptyMap()}}. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Comment Edited] (HADOOP-15223) Replace Collections.EMPTY_SET and EMPTY_MAP with emptySet() and emptyMap() when available

2018-02-12 Thread Akira Ajisaka (JIRA) 

[ 
https://issues.apache.org/jira/browse/HADOOP-15223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361861#comment-16361861
 ] 

Akira Ajisaka edited comment on HADOOP-15223 at 2/13/18 6:08 AM:
-

For example, in the following code, {{Collections.EMPTY_SET}} can be replaced 
with {{Collections.emptySet()}} to avoid unchecked assignment warning.
{code:java}
public Set getAllocationTags() {
  return Collections.EMPTY_SET;
}{code}


was (Author: ajisakaa):
For example, in the following code, {{Collections.EMPTY_SET}} can be replaced 
with {{Collections.emptySet()}} to avoid unchecked assignment.
{code:java}
public Set getAllocationTags() {
  return Collections.EMPTY_SET;
}{code}

> Replace Collections.EMPTY_SET and EMPTY_MAP with emptySet() and emptyMap() 
> when available
> -
>
> Key: HADOOP-15223
> URL: https://issues.apache.org/jira/browse/HADOOP-15223
> Project: Hadoop Common
>  Issue Type: Bug
>Reporter: Akira Ajisaka
>Priority: Minor
>
> The use of {{Collections.EMPTY_SET}} and {{Collections.EMPTY_MAP}} often 
> causes unchecked assignment and it should be replaced with 
> {{Collections.emptySet()}} and {{Collections.emptyMap()}}. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org