[jira] [Comment Edited] (HADOOP-15984) Update jersey from 1.19 to 2.x
[ https://issues.apache.org/jira/browse/HADOOP-15984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819667#comment-17819667 ] Shilun Fan edited comment on HADOOP-15984 at 2/22/24 2:24 PM: -- Here's some slightly better news: I believe I've mostly resolved the issue with Guice and Jersey2 conflicts causing injection failures. I've opted for a different approach to resolve it, and so far, it seems viable. I'll submit the PR as soon as possible. cc: [~aajisaka] [~ste...@apache.org] [~vjasani] [~fanningpj] was (Author: slfan1989): Here's some slightly better news: I believe I've mostly resolved the issue with Guice and Jersey2 conflicts causing injection failures. I've opted for a different approach to resolve it, and so far, it seems viable. I'll submit the PR as soon as possible. cc: [~aajisaka][~ste...@apache.org][~vjasani][~fanningpj] > Update jersey from 1.19 to 2.x > -- > > Key: HADOOP-15984 > URL: https://issues.apache.org/jira/browse/HADOOP-15984 > Project: Hadoop Common > Issue Type: Improvement >Reporter: Akira Ajisaka >Priority: Major > Labels: pull-request-available > Time Spent: 2h 10m > Remaining Estimate: 0h > > jersey-json 1.19 depends on Jackson 1.9.2. Let's upgrade. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HADOOP-15984) Update jersey from 1.19 to 2.x
[
https://issues.apache.org/jira/browse/HADOOP-15984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817023#comment-17817023
]
Shilun Fan edited comment on HADOOP-15984 at 2/13/24 3:01 PM:
--
[~iwasakims] [~fanningpj] Thank you for the comments! I encountered some issues
while debugging locally because jsr and rs-api define some classes with similar
names but not identical content, resulting in conflicts. Indeed, Jersey1 and
Jersey2 cannot coexist.
{code:java}
// jersey1 need jsr311
javax.ws.rs
jsr311-api
1.1.1
// jersey2 need rs-api 2.x
javax.ws.rs
javax.ws.rs-api
2.1.1
{code}
class loading resolution is one way to solve it, but it's quite challenging. We
can opt for a simpler solution, such as hadoop-thirdparty-jersey2, using shade
to rename the packages of the dependency jars. This approach is much simpler.
The benefit of using thirdparty-jersey2 is that we can attempt to upgrade
Jersey on a particular module without affecting other modules.
cc: [~ste...@apache.org]
was (Author: slfan1989):
[~iwasakims] [~fanningpj] Thank you for the comments! I encountered some issues
while debugging locally because jsr and rs-api define some classes with similar
names but not identical content, resulting in conflicts. Indeed, Jersey1 and
Jersey2 cannot coexist.
{code:java}
// jersey1 need jsr311
javax.ws.rs
jsr311-api
1.1.1
// jersey2 need rs-api 2.x
javax.ws.rs
javax.ws.rs-api
2.1.1
{code}
class loading resolution is one way to solve it, but it's quite challenging. We
can opt for a simpler solution, such as hadoop-thirdparty-jersey2, using shade
to rename the packages of the dependency jars. This approach is much simpler.
cc: [~ste...@apache.org]
> Update jersey from 1.19 to 2.x
> --
>
> Key: HADOOP-15984
> URL: https://issues.apache.org/jira/browse/HADOOP-15984
> Project: Hadoop Common
> Issue Type: Improvement
>Reporter: Akira Ajisaka
>Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> jersey-json 1.19 depends on Jackson 1.9.2. Let's upgrade.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HADOOP-15984) Update jersey from 1.19 to 2.x
[
https://issues.apache.org/jira/browse/HADOOP-15984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816869#comment-17816869
]
Masatake Iwasaki edited comment on HADOOP-15984 at 2/13/24 6:48 AM:
{quote}The reason this JIRA is particularly challenging is that the Hadoop
project cannot simultaneously support Jersey 1 and Jersey 2. I am considering
introducing Jersey 2 into Hadoop third-party dependencies and shading the
related paths to ensure that Jersey 1 and Jersey 2 can be introduced into the
Hadoop project simultaneously.
{quote}
[~slfan1989] IIUC, we need some hacks in class loading mechanism to make JAX-RS
1.1 and 2.1 co-exist as [~aajisaka] mentioned. Since Jersey 1.x and 2.x have
different package name and groupId, we usually don't need relocation for them.
*
[https://stackoverflow.com/questions/29632455/getting-jersey-1-x-and-2-x-to-coexist]
*
[https://download.oracle.com/javaee-archive/jersey.java.net/users/2014/04/18550.html]
was (Author: iwasakims):
{quote}
The reason this JIRA is particularly challenging is that the Hadoop project
cannot simultaneously support Jersey 1 and Jersey 2. I am considering
introducing Jersey 2 into Hadoop third-party dependencies and shading the
related paths to ensure that Jersey 1 and Jersey 2 can be introduced into the
Hadoop project simultaneously.
{quote}
[~slfan1989] IIUC, we need some hacks in class loading mechanism to make JAX-RS
1.1 and 2.0 co-exist as [~aajisaka] mentioned. Since Jersey 1.x and 2.x have
different package name and groupId, we usually don't need relocation for them.
*
https://stackoverflow.com/questions/29632455/getting-jersey-1-x-and-2-x-to-coexist
*
https://download.oracle.com/javaee-archive/jersey.java.net/users/2014/04/18550.html
> Update jersey from 1.19 to 2.x
> --
>
> Key: HADOOP-15984
> URL: https://issues.apache.org/jira/browse/HADOOP-15984
> Project: Hadoop Common
> Issue Type: Improvement
>Reporter: Akira Ajisaka
>Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> jersey-json 1.19 depends on Jackson 1.9.2. Let's upgrade.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HADOOP-15984) Update jersey from 1.19 to 2.x
[ https://issues.apache.org/jira/browse/HADOOP-15984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17706148#comment-17706148 ] Viraj Jasani edited comment on HADOOP-15984 at 3/28/23 9:04 PM: When I explored this upgrade last time, this is the WIP PR that I was working on [https://github.com/apache/hadoop/pull/4612] Please note that as I mentioned earlier, yarn tests are not working with the combination of dependencies and the changes done so far, and also not all hdfs tests are passing with this WIP PR. I am currently working on log4j upgrade and will take some time before I can come back to this one. If anyone has bandwidth and would like to take this work up in the meantime, please feel free to do so. There are two WIP PRs attached to this Jira for the reference of code changes (that are explored so far, the real changes are likely going to be more). We have also removed grizzly-http* usages as part of HADOOP-18620 (this was also one of the dependencies that we not compatible as part of the WIP PR) was (Author: vjasani): When I explored this upgrade last time, this is the WIP PR that I was working on [https://github.com/apache/hadoop/pull/4612] Please note that as I mentioned earlier, yarn tests are not working with the combination of dependencies and the changes done so far, and also not all hdfs tests are passing with this WIP PR. I am currently working on log4j upgrade and will take some time before I can come back to this one. If anyone has bandwidth and would like to take this work up in the meantime, please feel free to do so. There are two WIP PRs attached to this Jira for the reference of code changes (that are explored so far, the real changes are likely going to be more). > Update jersey from 1.19 to 2.x > -- > > Key: HADOOP-15984 > URL: https://issues.apache.org/jira/browse/HADOOP-15984 > Project: Hadoop Common > Issue Type: Improvement >Reporter: Akira Ajisaka >Assignee: Viraj Jasani >Priority: Major > Labels: pull-request-available > Time Spent: 2h 10m > Remaining Estimate: 0h > > jersey-json 1.19 depends on Jackson 1.9.2. Let's upgrade. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HADOOP-15984) Update jersey from 1.19 to 2.x
[ https://issues.apache.org/jira/browse/HADOOP-15984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17633472#comment-17633472 ] Ling Xu edited comment on HADOOP-15984 at 11/14/22 3:11 AM: grizzly-http-servlet is just used for test, and just one class used. !image-2022-11-14-11-09-23-320.png! . Can this replaced by mockito? was (Author: jackxu2011): grizzly-http-servlet is just used for test, and just using one class. !image-2022-11-14-11-09-23-320.png! . Can this replaced by mockito? > Update jersey from 1.19 to 2.x > -- > > Key: HADOOP-15984 > URL: https://issues.apache.org/jira/browse/HADOOP-15984 > Project: Hadoop Common > Issue Type: Improvement >Reporter: Akira Ajisaka >Assignee: Viraj Jasani >Priority: Major > Labels: pull-request-available > Time Spent: 2h 10m > Remaining Estimate: 0h > > jersey-json 1.19 depends on Jackson 1.9.2. Let's upgrade. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HADOOP-15984) Update jersey from 1.19 to 2.x
[
https://issues.apache.org/jira/browse/HADOOP-15984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17573978#comment-17573978
]
Viraj Jasani edited comment on HADOOP-15984 at 8/2/22 12:52 AM:
Tried digging bit more last week but this effort is not leading to good
outcomes. Tons of incompatibilities in not only just jersey core modules but
also grizzly, hk2, test framework provider etc modules together, is making this
overall progress quite difficult. Random internet references were the only way
to make progress so far (till the above comment) but now they are also hitting
the limits.
{quote}If someone can please help resolve TestRMWebServices, that would be
really great.
{quote}
I have still not been able to make further progress from this step. And I still
believe that we should not make progress to resolve compilation issues with
other modules until Yarn tests are successful.
Anyone is aware of who might be able to help us unblock? Although we could ask
someone who has integrated Jersey 1 with Hadoop in the first place but even
that might not be useful given the difficulties (Jersey 2 is a different world
with little reference).
was (Author: vjasani):
Tried digging bit more last week but this effort is not leading to good
outcomes. Tons of incompatibilities in not only just jersey core modules but
also grizzly, hk2, test framework provider etc modules together, is making this
overall progress quite difficult. Random internet references were the only way
to make progress so far (till the above comment) but now they are also hitting
the limits.
{quote}If someone can please help resolve TestRMWebServices, that would be
really great.
{quote}
I have still not been able to make further progress from this step. And I still
believe that we should not make progress to resolve compilation issues with
other modules until Yarn tests are successful.
Anyone is aware of who might be able to help us unblock? Although we could ask
someone who has integrated Jersey 1 with Hadoop in the first place but even
that might not be useful given the difficulties (Jersey 2 is a different world).
> Update jersey from 1.19 to 2.x
> --
>
> Key: HADOOP-15984
> URL: https://issues.apache.org/jira/browse/HADOOP-15984
> Project: Hadoop Common
> Issue Type: Improvement
>Reporter: Akira Ajisaka
>Assignee: Viraj Jasani
>Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> jersey-json 1.19 depends on Jackson 1.9.2. Let's upgrade.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HADOOP-15984) Update jersey from 1.19 to 2.x
[
https://issues.apache.org/jira/browse/HADOOP-15984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17557703#comment-17557703
]
Ayush Saxena edited comment on HADOOP-15984 at 6/22/22 9:02 PM:
{quote}So there is no grizzly-http-servlet version that has Jersey 2
dependencies.
{quote}
Awesome :(
Needless to say we already are aware of what problems Jersey upgrade creates
for downstream projects, Had an offline chit-chat with couple of folks and it
indeed is some pain.
The good news is we aren't blocking the release for this, so we have time and
no strict deadline pressure, so we can spend time and figure out a good & safe
solution.
If we don't find anything after brain storming and have concrete answers, then
we will figure out how to get rid of the Jackson upgrade
But we need Jersey for Java-11 also, I haven't spent time exploring any
workaround for it.
was (Author: ayushtkn):
{quote}So there is no grizzly-http-servlet version that has Jersey 2
dependencies.
{quote}
Awesome :(
Needless to say we already are aware of what problems Jersey upgrade creates
for downstream projects, Had an offline chit-chat with couple of folks and it
indeed is some pain.
The good news is we aren't blocking the release for this, so we have time and
no strict deadline pressure, so we can spend time and figure out a good & safe
solution.
If we don't find anything after brain storming and have concrete answers, then
we will figure out how to get rid of the Jackson upgrade
> Update jersey from 1.19 to 2.x
> --
>
> Key: HADOOP-15984
> URL: https://issues.apache.org/jira/browse/HADOOP-15984
> Project: Hadoop Common
> Issue Type: Improvement
>Reporter: Akira Ajisaka
>Assignee: Viraj Jasani
>Priority: Blocker
> Labels: pull-request-available
> Time Spent: 2h
> Remaining Estimate: 0h
>
> jersey-json 1.19 depends on Jackson 1.9.2. Let's upgrade.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HADOOP-15984) Update jersey from 1.19 to 2.x
[ https://issues.apache.org/jira/browse/HADOOP-15984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17557697#comment-17557697 ] Viraj Jasani edited comment on HADOOP-15984 at 6/22/22 8:53 PM: Reg grizzly-http-servlet, version 2.4.4 contains Jersey 1 artifacts: [https://repo1.maven.org/maven2/org/glassfish/grizzly/grizzly-http-servlet/2.4.4/grizzly-http-servlet-2.4.4.pom] The next higher version available is 3.0.0-M1 and it contains Jersey 3 artifacts: [https://repo1.maven.org/maven2/org/glassfish/grizzly/grizzly-http-servlet/3.0.0-M1/grizzly-http-servlet-3.0.0-M1.pom] So there is no grizzly-http-servlet version that has Jersey 2 dependencies. We might have to handle this as well (perhaps get rid of it if we can) was (Author: vjasani): Reg grizzly-http-servlet, version 2.4.4 contains Jersey 1 artifacts: [https://repo1.maven.org/maven2/org/glassfish/grizzly/grizzly-http-servlet/2.4.4/grizzly-http-servlet-2.4.4.pom] The next higher version available is 3.0.0-M1 and it contains Jersey 3 artifacts: [https://repo1.maven.org/maven2/org/glassfish/grizzly/grizzly-http-servlet/3.0.0-M1/grizzly-http-servlet-3.0.0-M1.pom] We might have to handle this as well (perhaps get rid of it if we can) > Update jersey from 1.19 to 2.x > -- > > Key: HADOOP-15984 > URL: https://issues.apache.org/jira/browse/HADOOP-15984 > Project: Hadoop Common > Issue Type: Improvement >Reporter: Akira Ajisaka >Assignee: Viraj Jasani >Priority: Blocker > Labels: pull-request-available > Time Spent: 2h > Remaining Estimate: 0h > > jersey-json 1.19 depends on Jackson 1.9.2. Let's upgrade. -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HADOOP-15984) Update jersey from 1.19 to 2.x
[ https://issues.apache.org/jira/browse/HADOOP-15984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17485374#comment-17485374 ] Miguel Costa edited comment on HADOOP-15984 at 2/1/22, 5:05 PM: Is there any plan to merge this PR? Basically I use a library that uses hadoop and I'm having a lot of security problems because of those and I'm just wondering if there is plans to fix it. was (Author: miguel_costa): Is there any plan to merge this PR? > Update jersey from 1.19 to 2.x > -- > > Key: HADOOP-15984 > URL: https://issues.apache.org/jira/browse/HADOOP-15984 > Project: Hadoop Common > Issue Type: Improvement >Reporter: Akira Ajisaka >Priority: Critical > Labels: pull-request-available > Time Spent: 1h 40m > Remaining Estimate: 0h > > jersey-json 1.19 depends on Jackson 1.9.2. Let's upgrade. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HADOOP-15984) Update jersey from 1.19 to 2.x
[ https://issues.apache.org/jira/browse/HADOOP-15984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962748#comment-16962748 ] Akira Ajisaka edited comment on HADOOP-15984 at 10/30/19 6:43 AM: -- Note: * common: Upgrade finished * hdfs: Upgrade finished but some tests are failing (Help wanted) ** WebHDFS op parameter (for example, liststatus in "?op=liststatus") must be case-insensitive, but now it is case-sensitive ** Now I cannot find a way to enable HDFS-14423 in Jersey 2.x * yarn: In progress * mapreduce, tools: Not yet I'd like to complete the issue by the end of March 2020. If you want to upgrade Jersey earlier, please help me. Cc: [~smeng] was (Author: ajisakaa): Note: * common: Upgrade finished * hdfs: Upgrade finished but some tests are failing (Help wanted) ** WebHDFS op parameter (for example, liststatus in "?op=liststatus") must be case-insensitive, but now it is case-sensitive ** Now I cannot find a way to enable HDFS-14423 * yarn: In progress * mapreduce, tools: Not yet I'd like to complete the issue by the end of March 2020. If you want to upgrade Jersey earlier, please help me. > Update jersey from 1.19 to 2.x > -- > > Key: HADOOP-15984 > URL: https://issues.apache.org/jira/browse/HADOOP-15984 > Project: Hadoop Common > Issue Type: Improvement >Reporter: Akira Ajisaka >Priority: Critical > > jersey-json 1.19 depends on Jackson 1.9.2. Let's upgrade. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
