[jira] [Comment Edited] (HADOOP-16041) UserAgent string for ABFS

2019-01-29 Thread Sean Mackrory (JIRA)


[ 
https://issues.apache.org/jira/browse/HADOOP-16041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755439#comment-16755439
 ] 

Sean Mackrory edited comment on HADOOP-16041 at 1/29/19 10:39 PM:
--

+1. Will commit. (edit: as briefly discussed offline - there is now a space 
after the slash that appears to be unintentional)


was (Author: mackrorysd):
+1. Will commit.

> UserAgent string for ABFS
> -
>
> Key: HADOOP-16041
> URL: https://issues.apache.org/jira/browse/HADOOP-16041
> Project: Hadoop Common
>  Issue Type: Sub-task
>  Components: fs/azure
>Affects Versions: 3.2.0
>Reporter: Shweta
>Assignee: Shweta
>Priority: Major
> Fix For: 3.3.0
>
> Attachments: HADOOP-16041.001.patch, HADOOP-16041.002.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Comment Edited] (HADOOP-16041) UserAgent string for ABFS

2019-01-10 Thread Sean Mackrory (JIRA)


[ 
https://issues.apache.org/jira/browse/HADOOP-16041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739969#comment-16739969
 ] 

Sean Mackrory edited comment on HADOOP-16041 at 1/11/19 2:49 AM:
-

{quote}Partner Service{quote}

To be clear, that's not part of the user agent string. I suspect you're getting 
that from verifyUserAgent, where it sets the configurable prefix to "Partner 
Service", but any Hadoop installation could set that to whatever they wanted. 
The Hadoop distribution in usage can actually be inferred from VersionInfo, 
which is how it's done in other cloud connectors already (and is actually 
what's motivating this change).

We should coordinate with [~tmarquardt] and [~DanielZhou] to make sure there 
isn't any intended future use of Azure Blob FS/1.0, if that's supposed to map 
to some API version or something. Since we don't have a distinct SDK, Hadoop 
*is* the client, so the Hadoop version makes sense to me. But we can preserve 
Azure Blob FS/1.0 if that carries any special meaning for Microsoft.


was (Author: mackrorysd):
{quote}Partner Service{quote}

To be clear, that's not part of the user agent string. I suspect you're getting 
that from verifyUserAgent, where it sets the configurable prefix to "Partner 
Service", but any Hadoop installation could set that to whatever they wanted. 
The Hadoop distribution in usage can actually be inferred from VersionInfo, 
which is how it's done in other cloud connectors already (and is actually 
what's motivating this change).

We should coordinate with [~tmarquardt] to make sure there isn't any intended 
future use of Azure Blob FS/1.0, if that's supposed to map to some API version 
or something. Since we don't have a distinct SDK, Hadoop *is* the client, so 
the Hadoop version makes sense to me. But we can preserve Azure Blob FS/1.0 if 
that carries any special meaning for Microsoft.

> UserAgent string for ABFS
> -
>
> Key: HADOOP-16041
> URL: https://issues.apache.org/jira/browse/HADOOP-16041
> Project: Hadoop Common
>  Issue Type: Sub-task
>  Components: fs/azure
>Affects Versions: 3.2.0
>Reporter: Shweta
>Assignee: Shweta
>Priority: Major
> Fix For: 3.3.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org