[jira] [Commented] (HADOOP-10603) Crypto input and output streams implementing Hadoop stream interfaces

2014-05-23 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14007205#comment-14007205 ] Yi Liu commented on HADOOP-10603: - The new patch is

[jira] [Commented] (HADOOP-10603) Crypto input and output streams implementing Hadoop stream interfaces

2014-05-23 Thread Charles Lamb (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14007457#comment-14007457 ] Charles Lamb commented on HADOOP-10603: --- Yi, I'm sorry I didn't get these

[jira] [Commented] (HADOOP-10603) Crypto input and output streams implementing Hadoop stream interfaces

2014-05-23 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14007792#comment-14007792 ] Andrew Wang commented on HADOOP-10603: -- Hey Charles, how do you feel about

[jira] [Commented] (HADOOP-10603) Crypto input and output streams implementing Hadoop stream interfaces

2014-05-23 Thread Charles Lamb (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14007827#comment-14007827 ] Charles Lamb commented on HADOOP-10603: --- Sounds good. +1 Crypto input and

[jira] [Commented] (HADOOP-10603) Crypto input and output streams implementing Hadoop stream interfaces

2014-05-23 Thread Charles Lamb (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14007829#comment-14007829 ] Charles Lamb commented on HADOOP-10603: --- +1 Crypto input and output streams

[jira] [Commented] (HADOOP-10603) Crypto input and output streams implementing Hadoop stream interfaces

2014-05-23 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14007914#comment-14007914 ] Yi Liu commented on HADOOP-10603: - Thanks Andrew and Charles for review :-). I will

[jira] [Commented] (HADOOP-10603) Crypto input and output streams implementing Hadoop stream interfaces

2014-05-23 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14007960#comment-14007960 ] Yi Liu commented on HADOOP-10603: - I have just committed this to branch, Thanks all. I

[jira] [Commented] (HADOOP-10603) Crypto input and output streams implementing Hadoop stream interfaces

2014-05-22 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14005952#comment-14005952 ] Yi Liu commented on HADOOP-10603: - Charles, thanks for your good comments: {quote} I

[jira] [Commented] (HADOOP-10603) Crypto input and output streams implementing Hadoop stream interfaces

2014-05-22 Thread Charles Lamb (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14006624#comment-14006624 ] Charles Lamb commented on HADOOP-10603: --- Hi Yi, Good work so far. I took your

[jira] [Commented] (HADOOP-10603) Crypto input and output streams implementing Hadoop stream interfaces

2014-05-22 Thread Charles Lamb (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14006628#comment-14006628 ] Charles Lamb commented on HADOOP-10603: --- CryptoInputStream.java: Shouldn't

[jira] [Commented] (HADOOP-10603) Crypto input and output streams implementing Hadoop stream interfaces

2014-05-22 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14006655#comment-14006655 ] Andrew Wang commented on HADOOP-10603: -- Thanks for the mega-rev Yi, I went through

[jira] [Commented] (HADOOP-10603) Crypto input and output streams implementing Hadoop stream interfaces

2014-05-22 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14006678#comment-14006678 ] Yi Liu commented on HADOOP-10603: - Thanks Charles. {quote} Shouldn't usingByteBufferRead

[jira] [Commented] (HADOOP-10603) Crypto input and output streams implementing Hadoop stream interfaces

2014-05-22 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14006680#comment-14006680 ] Yi Liu commented on HADOOP-10603: - Thanks [~andrew.wang] for your nice comments. I will

[jira] [Commented] (HADOOP-10603) Crypto input and output streams implementing Hadoop stream interfaces

2014-05-21 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004498#comment-14004498 ] Yi Liu commented on HADOOP-10603: - Andrew, thanks for your detailed review. Although

[jira] [Commented] (HADOOP-10603) Crypto input and output streams implementing Hadoop stream interfaces

2014-05-21 Thread Charles Lamb (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14005400#comment-14005400 ] Charles Lamb commented on HADOOP-10603: --- Hi Yi, Good work so far. I took your

[jira] [Commented] (HADOOP-10603) Crypto input and output streams implementing Hadoop stream interfaces

2014-05-21 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14005481#comment-14005481 ] Yi Liu commented on HADOOP-10603: - Thanks Charles for good comments. I'm refining the

[jira] [Commented] (HADOOP-10603) Crypto input and output streams implementing Hadoop stream interfaces

2014-05-20 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004190#comment-14004190 ] Andrew Wang commented on HADOOP-10603: -- Hi Yi, thanks for working on this code. I

[jira] [Commented] (HADOOP-10603) Crypto input and output streams implementing Hadoop stream interfaces

2014-05-18 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14001126#comment-14001126 ] Yi Liu commented on HADOOP-10603: - The tests for crypto input and output streams are in

[jira] [Commented] (HADOOP-10603) Crypto input and output streams implementing Hadoop stream interfaces

2014-05-16 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13998767#comment-13998767 ] Yi Liu commented on HADOOP-10603: - In HDFS-6392, Wire crypto streams for encrypted files

[jira] [Commented] (HADOOP-10603) Crypto input and output streams implementing Hadoop stream interfaces

2014-05-16 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13999474#comment-13999474 ] Yi Liu commented on HADOOP-10603: - Thanks [~clamb] and [~tucu00] , good comments.

[jira] [Commented] (HADOOP-10603) Crypto input and output streams implementing Hadoop stream interfaces

2014-05-15 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13998295#comment-13998295 ] Yi Liu commented on HADOOP-10603: - This patch is split from HADOOP-10150 with a bit

[jira] [Commented] (HADOOP-10603) Crypto input and output streams implementing Hadoop stream interfaces

2014-05-15 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13998428#comment-13998428 ] Yi Liu commented on HADOOP-10603: - In HADOOP-10047, @Gopal V add a directbuffer