[jira] [Commented] (HADOOP-10715) Make GraphiteSink#setWriter() private

2014-06-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14044043#comment-14044043 ] Hadoop QA commented on HADOOP-10715: {color:green}+1 overall{color}. Here are the

[jira] [Commented] (HADOOP-10715) Make GraphiteSink#setWriter() private

2014-06-25 Thread Ravi Prakash (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14044257#comment-14044257 ] Ravi Prakash commented on HADOOP-10715: --- Thanks Babak! +1. Patch looks good to me.

[jira] [Commented] (HADOOP-10715) Make GraphiteSink#setWriter() private

2014-06-19 Thread Babak Behzad (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14038107#comment-14038107 ] Babak Behzad commented on HADOOP-10715: --- I just uploaded the patch. Thanks

[jira] [Commented] (HADOOP-10715) Make GraphiteSink#setWriter() private

2014-06-19 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14038110#comment-14038110 ] Ted Yu commented on HADOOP-10715: - lgtm Make GraphiteSink#setWriter() private

[jira] [Commented] (HADOOP-10715) Make GraphiteSink#setWriter() private

2014-06-19 Thread Babak Behzad (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-10715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14038189#comment-14038189 ] Babak Behzad commented on HADOOP-10715: --- The tests are not compilable with that