[
https://issues.apache.org/jira/browse/HADOOP-12041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148230#comment-15148230
]
Rui Li commented on HADOOP-12041:
-
Thanks Zhe and Kai for the explanations. I just filed HADOOP-12808 as
[
https://issues.apache.org/jira/browse/HADOOP-12041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148174#comment-15148174
]
Kai Zheng commented on HADOOP-12041:
bq. So the follow-on task should cover the coder renaming and
[
https://issues.apache.org/jira/browse/HADOOP-12041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133403#comment-15133403
]
Zhe Zhang commented on HADOOP-12041:
Sorry about the confusion. I meant we should have a way to
[
https://issues.apache.org/jira/browse/HADOOP-12041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131408#comment-15131408
]
Kai Zheng commented on HADOOP-12041:
Thanks [~zhz] and [~walter.k.su] for the review and commit!!
[
https://issues.apache.org/jira/browse/HADOOP-12041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131415#comment-15131415
]
Kai Zheng commented on HADOOP-12041:
I meant HADOOP-11540.
> Implement another Reed-Solomon coder
[
https://issues.apache.org/jira/browse/HADOOP-12041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131557#comment-15131557
]
Rui Li commented on HADOOP-12041:
-
So the follow-on task should cover the coder renaming and adding
[
https://issues.apache.org/jira/browse/HADOOP-12041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131369#comment-15131369
]
Hudson commented on HADOOP-12041:
-
FAILURE: Integrated in Hadoop-trunk-Commit #9242 (See
[
https://issues.apache.org/jira/browse/HADOOP-12041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127239#comment-15127239
]
Zhe Zhang commented on HADOOP-12041:
Thanks for the great work Kai. Patch LGTM overall. A few minor
[
https://issues.apache.org/jira/browse/HADOOP-12041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127327#comment-15127327
]
Kai Zheng commented on HADOOP-12041:
Thanks Zhe for the careful review. The comments are very
[
https://issues.apache.org/jira/browse/HADOOP-12041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127569#comment-15127569
]
Kai Zheng commented on HADOOP-12041:
Patch updated addressing an unused import issue.
bq. Missing
[
https://issues.apache.org/jira/browse/HADOOP-12041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127548#comment-15127548
]
Hadoop QA commented on HADOOP-12041:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127674#comment-15127674
]
Hadoop QA commented on HADOOP-12041:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101570#comment-15101570
]
Hadoop QA commented on HADOOP-12041:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101407#comment-15101407
]
Walter Su commented on HADOOP-12041:
The new coder passes test and is stable locally.
bq. What did
[
https://issues.apache.org/jira/browse/HADOOP-12041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101434#comment-15101434
]
Kai Zheng commented on HADOOP-12041:
Thanks [~walter.k.su] for the nice comments!
bq. inited is
[
https://issues.apache.org/jira/browse/HADOOP-12041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15090120#comment-15090120
]
Zhe Zhang commented on HADOOP-12041:
Agreed, let's do the rename separately.
> Implement another
[
https://issues.apache.org/jira/browse/HADOOP-12041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15088720#comment-15088720
]
Kai Zheng commented on HADOOP-12041:
Hi [~zhz],
bq. we should rename the existing coder as
[
https://issues.apache.org/jira/browse/HADOOP-12041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15086391#comment-15086391
]
Zhe Zhang commented on HADOOP-12041:
Thanks Kai for the work. I'm still reviewing the patch but
[
https://issues.apache.org/jira/browse/HADOOP-12041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15086713#comment-15086713
]
Kai Zheng commented on HADOOP-12041:
Thanks Zhe for the good questions.
bq. The old and new coders
[
https://issues.apache.org/jira/browse/HADOOP-12041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15084623#comment-15084623
]
Hadoop QA commented on HADOOP-12041:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15084503#comment-15084503
]
Kai Zheng commented on HADOOP-12041:
Hi [~walter.k.su],
I'm going to update this. Would you help
[
https://issues.apache.org/jira/browse/HADOOP-12041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15035407#comment-15035407
]
Kai Zheng commented on HADOOP-12041:
Thanks [~walter.k.su] for the review. I work on this one
[
https://issues.apache.org/jira/browse/HADOOP-12041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15035229#comment-15035229
]
Walter Su commented on HADOOP-12041:
It looks good. Thanks [~drankye].
1. erasures2erased(int[]
[
https://issues.apache.org/jira/browse/HADOOP-12041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993347#comment-14993347
]
Hadoop QA commented on HADOOP-12041:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986717#comment-14986717
]
Hadoop QA commented on HADOOP-12041:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986355#comment-14986355
]
Kai Zheng commented on HADOOP-12041:
Looks like it isn't too bad for the large portion of new codes
[
https://issues.apache.org/jira/browse/HADOOP-12041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14984725#comment-14984725
]
Hadoop QA commented on HADOOP-12041:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-12041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14977547#comment-14977547
]
Kai Zheng commented on HADOOP-12041:
I will rebase the patch on trunk when HADOOP-12040 is in, but I
[
https://issues.apache.org/jira/browse/HADOOP-12041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14977720#comment-14977720
]
Zhe Zhang commented on HADOOP-12041:
Thanks Kai! Sure, I will review the patch soon.
> Implement
29 matches
Mail list logo