[jira] [Commented] (HADOOP-12556) KafkaSink jar files are created but not copied to target dist
[ https://issues.apache.org/jira/browse/HADOOP-12556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15889231#comment-15889231 ] Hudson commented on HADOOP-12556: - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11324 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/11324/]) HADOOP-12556. KafkaSink jar files are created but not copied to target (aw: rev 989bd56b9fd521a67afbc691c9915be13d7c8e3a) * (edit) hadoop-tools/hadoop-tools-dist/pom.xml > KafkaSink jar files are created but not copied to target dist > - > > Key: HADOOP-12556 > URL: https://issues.apache.org/jira/browse/HADOOP-12556 > Project: Hadoop Common > Issue Type: Bug >Reporter: Babak Behzad >Assignee: Babak Behzad > Fix For: 3.0.0-alpha3 > > Attachments: HADOOP-12556.patch > > > There is a hadoop-kafka artifact missing from hadoop-tools-dist's pom.xml > which was causing the compiled Kafka jar files not to be copied to the target > dist directory. The new patch adds this in order to complete this fix. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-12556) KafkaSink jar files are created but not copied to target dist
[
https://issues.apache.org/jira/browse/HADOOP-12556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886728#comment-15886728
]
Hadoop QA commented on HADOOP-12556:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
22s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 14m
5s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
11s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
14s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
16s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
10s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
11s{color} | {color:green} hadoop-tools-dist in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
19s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 17m 22s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:a9ad5d6 |
| JIRA Issue | HADOOP-12556 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12771062/HADOOP-12556.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit xml |
| uname | Linux e7120994016c 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6
15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / 5f5b031 |
| Default Java | 1.8.0_121 |
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/11724/testReport/ |
| modules | C: hadoop-tools/hadoop-tools-dist U: hadoop-tools/hadoop-tools-dist
|
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/11724/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> KafkaSink jar files are created but not copied to target dist
> -
>
> Key: HADOOP-12556
> URL: https://issues.apache.org/jira/browse/HADOOP-12556
> Project: Hadoop Common
> Issue Type: Bug
>Reporter: Babak Behzad
>Assignee: Babak Behzad
> Attachments: HADOOP-12556.patch
>
>
> There is a hadoop-kafka artifact missing from hadoop-tools-dist's pom.xml
> which was causing the compiled Kafka jar files not to be copied to the target
> dist directory. The new patch adds this in order to complete this fix.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-12556) KafkaSink jar files are created but not copied to target dist
[
https://issues.apache.org/jira/browse/HADOOP-12556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886700#comment-15886700
]
Hadoop QA commented on HADOOP-12556:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 19m
53s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 12m
52s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
11s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
13s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
13s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
10s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
9s{color} | {color:green} hadoop-tools-dist in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
17s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 35m 22s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:a9ad5d6 |
| JIRA Issue | HADOOP-12556 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12771062/HADOOP-12556.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit xml |
| uname | Linux 71ed2107cb10 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24
10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / 5f5b031 |
| Default Java | 1.8.0_121 |
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/11723/testReport/ |
| modules | C: hadoop-tools/hadoop-tools-dist U: hadoop-tools/hadoop-tools-dist
|
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/11723/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> KafkaSink jar files are created but not copied to target dist
> -
>
> Key: HADOOP-12556
> URL: https://issues.apache.org/jira/browse/HADOOP-12556
> Project: Hadoop Common
> Issue Type: Bug
>Reporter: Babak Behzad
>Assignee: Babak Behzad
> Attachments: HADOOP-12556.patch
>
>
> There is a hadoop-kafka artifact missing from hadoop-tools-dist's pom.xml
> which was causing the compiled Kafka jar files not to be copied to the target
> dist directory. The new patch adds this in order to complete this fix.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-12556) KafkaSink jar files are created but not copied to target dist
[ https://issues.apache.org/jira/browse/HADOOP-12556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209146#comment-15209146 ] Allen Wittenauer commented on HADOOP-12556: --- HADOOP-12857 as been committed. I believe that effectively unblocks this patch, since it would mean that the kafka jars would only be in the classpath if the user enables the hadoop-kafka entry in hadoop-env.sh, as no remaining Hadoop code in trunk blindly adds all of the tools lib to the classpath. Let's verify that's the case and if [~ste...@apache.org] is amenable, this can get committed. > KafkaSink jar files are created but not copied to target dist > - > > Key: HADOOP-12556 > URL: https://issues.apache.org/jira/browse/HADOOP-12556 > Project: Hadoop Common > Issue Type: Bug >Reporter: Babak Behzad >Assignee: Babak Behzad > Attachments: HADOOP-12556.patch > > > There is a hadoop-kafka artifact missing from hadoop-tools-dist's pom.xml > which was causing the compiled Kafka jar files not to be copied to the target > dist directory. The new patch adds this in order to complete this fix. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12556) KafkaSink jar files are created but not copied to target dist
[ https://issues.apache.org/jira/browse/HADOOP-12556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15172748#comment-15172748 ] Allen Wittenauer commented on HADOOP-12556: --- I've opened up HADOOP-12857 as a more appropriate venue for this discussion, since we're going way outside the scope of this JIRA. > KafkaSink jar files are created but not copied to target dist > - > > Key: HADOOP-12556 > URL: https://issues.apache.org/jira/browse/HADOOP-12556 > Project: Hadoop Common > Issue Type: Bug >Reporter: Babak Behzad >Assignee: Babak Behzad > Attachments: HADOOP-12556.patch > > > There is a hadoop-kafka artifact missing from hadoop-tools-dist's pom.xml > which was causing the compiled Kafka jar files not to be copied to the target > dist directory. The new patch adds this in order to complete this fix. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12556) KafkaSink jar files are created but not copied to target dist
[ https://issues.apache.org/jira/browse/HADOOP-12556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15169727#comment-15169727 ] Chris Nauroth commented on HADOOP-12556: I'm slightly in favor of option 2: keep it as one big dir. That gives an easy out if someone decides they really do want the whole world by putting share/hadoop/tools/lib/* on the classpath. OTOH, I suppose we could come up with a "whole world" shell profile that walks a more granular directory structure and gathers everything. In general, I really like the idea of using shell profiles to solve this problem. We still have a gap in that we don't have equivalent functionality on Windows. I have a hunch that it won't be feasible to offer all of the rich features of the full shell rewrite in cmd, but maybe we can do just enough to support classpath customization through profiles. > KafkaSink jar files are created but not copied to target dist > - > > Key: HADOOP-12556 > URL: https://issues.apache.org/jira/browse/HADOOP-12556 > Project: Hadoop Common > Issue Type: Bug >Reporter: Babak Behzad >Assignee: Babak Behzad > Attachments: HADOOP-12556.patch > > > There is a hadoop-kafka artifact missing from hadoop-tools-dist's pom.xml > which was causing the compiled Kafka jar files not to be copied to the target > dist directory. The new patch adds this in order to complete this fix. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12556) KafkaSink jar files are created but not copied to target dist
[ https://issues.apache.org/jira/browse/HADOOP-12556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15169320#comment-15169320 ] Allen Wittenauer commented on HADOOP-12556: --- cc: [~cnauroth] since I think he'll be interested as well. The more and more I think about this situation and others (e.g., HADOOP-12721), the more and more I'm inclined hadoop-tools-dist needs to be revisited now that it's getting more and more case-specific content. With the existence of shell profiles in trunk, this gets significantly easier... Two potential options: * break apart hadoop-tools-dist into multiple directories. create a shell profile that sucks that functionalities entire dir. * keep hadoop-tools-dist as one big dir (thus making it bw compat, but still potentially messy). build a tool that creates shell profiles based upon the maven dependency trees to list the specific jars needed by that functionality. In both cases, to activate, simply copy shellprofile.d/foo.sh.example to HADOOP_CONFIG_DIR/shellprofile.d/foo.sh. Or uncomment. Or whatever. In the end, the shellprofile will add only the necessary components to the classpath. And since it is being done via shell profiles a) those jars will always be present, b) it doesn't interfere with any of the other env var settings that users typically modify, c) should be bw compat with the entire universe so long as they honor the output of the various classpath commands > KafkaSink jar files are created but not copied to target dist > - > > Key: HADOOP-12556 > URL: https://issues.apache.org/jira/browse/HADOOP-12556 > Project: Hadoop Common > Issue Type: Bug >Reporter: Babak Behzad >Assignee: Babak Behzad > Attachments: HADOOP-12556.patch > > > There is a hadoop-kafka artifact missing from hadoop-tools-dist's pom.xml > which was causing the compiled Kafka jar files not to be copied to the target > dist directory. The new patch adds this in order to complete this fix. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12556) KafkaSink jar files are created but not copied to target dist
[ https://issues.apache.org/jira/browse/HADOOP-12556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15168800#comment-15168800 ] Steve Loughran commented on HADOOP-12556: - I'd like it so that if you explicitly ask for hadoop-kafka then you get everything you need. My own concerns are to make sure that if you depended on core stuff (hadoop-client), you don't get another set of classpath problems. And we have so much cruft (why does junit get into mapreduce/lib? Because it did in the past and if you pull it now, things break ... ) You're talking about hadoop-tools-dist, aren't you? If so, where do the JARs end up on a release build? > KafkaSink jar files are created but not copied to target dist > - > > Key: HADOOP-12556 > URL: https://issues.apache.org/jira/browse/HADOOP-12556 > Project: Hadoop Common > Issue Type: Bug >Reporter: Babak Behzad >Assignee: Babak Behzad > Attachments: HADOOP-12556.patch > > > There is a hadoop-kafka artifact missing from hadoop-tools-dist's pom.xml > which was causing the compiled Kafka jar files not to be copied to the target > dist directory. The new patch adds this in order to complete this fix. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12556) KafkaSink jar files are created but not copied to target dist
[
https://issues.apache.org/jira/browse/HADOOP-12556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15167901#comment-15167901
]
Hadoop QA commented on HADOOP-12556:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 15m 18s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
14s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 8s
{color} | {color:green} trunk passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 10s
{color} | {color:green} trunk passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 16s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
12s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 9s
{color} | {color:green} trunk passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 10s
{color} | {color:green} trunk passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
11s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 9s
{color} | {color:green} the patch passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 9s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 8s
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 8s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 13s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
11s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 0s
{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 9s
{color} | {color:green} the patch passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 8s
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 7s
{color} | {color:green} hadoop-tools-dist in the patch passed with JDK
v1.8.0_72. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 8s
{color} | {color:green} hadoop-tools-dist in the patch passed with JDK
v1.7.0_95. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 26m 14s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:0ca8df7 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12771062/HADOOP-12556.patch |
| JIRA Issue | HADOOP-12556 |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit xml |
| uname | Linux 41ab026fc99a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / c4d4df8 |
| Default Java | 1.7.0_95 |
| Multi-JDK versions | /usr/lib/jvm/java-8-oracle:1.8.0_72
/usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 |
| JDK v1.7.0_95 Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/8722/testReport/ |
| modules | C: hadoop-tools/hadoop-tools-dist U: hadoop-tools/hadoop-tools-dist
|
| Console output |
[jira] [Commented] (HADOOP-12556) KafkaSink jar files are created but not copied to target dist
[
https://issues.apache.org/jira/browse/HADOOP-12556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15167856#comment-15167856
]
Ravi Prakash commented on HADOOP-12556:
---
Hi Steve! Thanks for your review. Is there a reason you'd be reluctant to add
kafka as a dependency to hadoop-tools ? These are the dependencies which would
get added
{code}
< [INFO] +- org.apache.hadoop:hadoop-kafka:jar:3.0.0-SNAPSHOT:compile
< [INFO] | \- org.apache.kafka:kafka_2.10:jar:0.8.2.1:compile
< [INFO] | +- com.yammer.metrics:metrics-core:jar:2.2.0:compile
< [INFO] | +- org.scala-lang:scala-library:jar:2.10.4:compile
< [INFO] | +- org.apache.kafka:kafka-clients:jar:0.8.2.1:compile
< [INFO] | | \- net.jpountz.lz4:lz4:jar:1.2.0:compile
< [INFO] | +- net.sf.jopt-simple:jopt-simple:jar:3.2:compile
< [INFO] | \- com.101tec:zkclient:jar:0.3:compile
{code}
Are there guidelines for when a dependency is scoped as {{compile}} vs
{{provided}}? I thought the reason you [wanted a new
submodule|https://issues.apache.org/jira/browse/HADOOP-10949?focusedCommentId=14725921=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14725921]
(hadoop-kafka) so that we didn't have to add kafka to the hadoop-common.
I agree that we should try to reduce our dependencies as much as possible, but
I don't really see an alternative here.
> KafkaSink jar files are created but not copied to target dist
> -
>
> Key: HADOOP-12556
> URL: https://issues.apache.org/jira/browse/HADOOP-12556
> Project: Hadoop Common
> Issue Type: Bug
>Reporter: Babak Behzad
>Assignee: Babak Behzad
> Attachments: HADOOP-12556.patch
>
>
> There is a hadoop-kafka artifact missing from hadoop-tools-dist's pom.xml
> which was causing the compiled Kafka jar files not to be copied to the target
> dist directory. The new patch adds this in order to complete this fix.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12556) KafkaSink jar files are created but not copied to target dist
[ https://issues.apache.org/jira/browse/HADOOP-12556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15089578#comment-15089578 ] Babak Behzad commented on HADOOP-12556: --- Sure, sounds good to me! Thanks [~steve_l]. What do you think [~raviprak] and [~aw]? > KafkaSink jar files are created but not copied to target dist > - > > Key: HADOOP-12556 > URL: https://issues.apache.org/jira/browse/HADOOP-12556 > Project: Hadoop Common > Issue Type: Bug >Reporter: Babak Behzad >Assignee: Babak Behzad > Attachments: HADOOP-12556.patch > > > There is a hadoop-kafka artifact missing from hadoop-tools-dist's pom.xml > which was causing the compiled Kafka jar files not to be copied to the target > dist directory. The new patch adds this in order to complete this fix. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12556) KafkaSink jar files are created but not copied to target dist
[
https://issues.apache.org/jira/browse/HADOOP-12556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14995695#comment-14995695
]
Hadoop QA commented on HADOOP-12556:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 12s
{color} | {color:blue} docker + precommit patch detected. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
14s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 10s
{color} | {color:green} trunk passed with JDK v1.8.0_60 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 10s
{color} | {color:green} trunk passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
13s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 9s
{color} | {color:green} trunk passed with JDK v1.8.0_60 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 11s
{color} | {color:green} trunk passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
13s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 9s
{color} | {color:green} the patch passed with JDK v1.8.0_60 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 9s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 10s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 10s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
12s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 0s
{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 9s
{color} | {color:green} the patch passed with JDK v1.8.0_60 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 11s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 9s
{color} | {color:green} hadoop-tools-dist in the patch passed with JDK
v1.8.0_60. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 11s
{color} | {color:green} hadoop-tools-dist in the patch passed with JDK
v1.7.0_79. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
22s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 7m 1s {color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.7.1 Server=1.7.1
Image:test-patch-base-hadoop-date2015-11-08 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12771062/HADOOP-12556.patch |
| JIRA Issue | HADOOP-12556 |
| Optional Tests | asflicense javac javadoc mvninstall unit xml compile
|
| uname | Linux 39ef64c026b6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-ee5baeb/precommit/personality/hadoop.sh
|
| git revision | trunk / 6d2332a |
| Default Java | 1.7.0_79 |
| Multi-JDK versions | /usr/lib/jvm/java-8-oracle:1.8.0_60
/usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 |
| JDK v1.7.0_79 Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/8052/testReport/ |
| modules | C: hadoop-tools/hadoop-tools-dist U: hadoop-tools/hadoop-tools-dist
|
| Max memory used | 227MB |
| Powered by | Apache Yetus http://yetus.apache.org |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/8052/console |
This
[jira] [Commented] (HADOOP-12556) KafkaSink jar files are created but not copied to target dist
[ https://issues.apache.org/jira/browse/HADOOP-12556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994219#comment-14994219 ] Steve Loughran commented on HADOOP-12556: - I'm going to be ruthless here: do we want the kafka JARs in? or just hadoop-kafka, which gives you the full sink once you stick kafka on the CP? As I'm happy with the latter, but would like to not add kafka to the current set of JARs > KafkaSink jar files are created but not copied to target dist > - > > Key: HADOOP-12556 > URL: https://issues.apache.org/jira/browse/HADOOP-12556 > Project: Hadoop Common > Issue Type: Bug >Reporter: Babak Behzad >Assignee: Babak Behzad > Attachments: HADOOP-12556.patch > > > There is a hadoop-kafka artifact missing from hadoop-tools-dist's pom.xml > which was causing the compiled Kafka jar files not to be copied to the target > dist directory. The new patch adds this in order to complete this fix. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12556) KafkaSink jar files are created but not copied to target dist
[ https://issues.apache.org/jira/browse/HADOOP-12556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994039#comment-14994039 ] Babak Behzad commented on HADOOP-12556: --- This is a short fix related to the KafkaSink ([https://issues.apache.org/jira/browse/HADOOP-10949]). Since the ticket was closed, we created this new ticket, as [~aw] instructed me to do so. The patch is attached. > KafkaSink jar files are created but not copied to target dist > - > > Key: HADOOP-12556 > URL: https://issues.apache.org/jira/browse/HADOOP-12556 > Project: Hadoop Common > Issue Type: Bug >Reporter: Babak Behzad >Assignee: Babak Behzad > Attachments: HADOOP-12556.patch > > > There is a hadoop-kafka artifact missing from hadoop-tools-dist's pom.xml > which was causing the compiled Kafka jar files not to be copied to the target > dist directory. The new patch adds this in order to complete this fix. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
