[jira] [Commented] (HADOOP-12954) Add a way to change hadoop.security.token.service.use_ip
[
https://issues.apache.org/jira/browse/HADOOP-12954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709530#comment-15709530
]
Robert Kanter commented on HADOOP-12954:
Seems like a good idea to me.
> Add a way to change hadoop.security.token.service.use_ip
>
>
> Key: HADOOP-12954
> URL: https://issues.apache.org/jira/browse/HADOOP-12954
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
>Affects Versions: 2.6.0
>Reporter: Robert Kanter
>Assignee: Robert Kanter
> Fix For: 2.9.0, 3.0.0-alpha1
>
> Attachments: HADOOP-12954.001.patch, HADOOP-12954.002.patch,
> HADOOP-12954.003.patch
>
>
> Currently, {{hadoop.security.token.service.use_ip}} is set on JVM startup via:
> {code:java}
> static {
> Configuration conf = new Configuration();
> boolean useIp = conf.getBoolean(
> CommonConfigurationKeys.HADOOP_SECURITY_TOKEN_SERVICE_USE_IP,
> CommonConfigurationKeys.HADOOP_SECURITY_TOKEN_SERVICE_USE_IP_DEFAULT);
> setTokenServiceUseIp(useIp);
> }
> {code}
> This is a problem for clients, such as Oozie, who don't add *-site.xml files
> to their classpath. Oozie normally creates a {{JobClient}} and passes a
> {{Configuration}} to it with the proper configs we need. However, because
> {{hadoop.security.token.service.use_ip}} is specified in a static block like
> this, and there's no API to change it, Oozie has no way to set it to the
> non-default value.
> I propose we add a {{setConfiguration}} method which takes a
> {{Configuration}} and rereads {{hadoop.security.token.service.use_ip}}.
> There's a few other properties that are also loaded statically on startup
> that can be reloaded here as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-12954) Add a way to change hadoop.security.token.service.use_ip
[
https://issues.apache.org/jira/browse/HADOOP-12954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709522#comment-15709522
]
Junping Du commented on HADOOP-12954:
-
Hi Robert and Steve, do we want to backport this issue to 2.8 as well?
> Add a way to change hadoop.security.token.service.use_ip
>
>
> Key: HADOOP-12954
> URL: https://issues.apache.org/jira/browse/HADOOP-12954
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
>Affects Versions: 2.6.0
>Reporter: Robert Kanter
>Assignee: Robert Kanter
> Fix For: 2.9.0, 3.0.0-alpha1
>
> Attachments: HADOOP-12954.001.patch, HADOOP-12954.002.patch,
> HADOOP-12954.003.patch
>
>
> Currently, {{hadoop.security.token.service.use_ip}} is set on JVM startup via:
> {code:java}
> static {
> Configuration conf = new Configuration();
> boolean useIp = conf.getBoolean(
> CommonConfigurationKeys.HADOOP_SECURITY_TOKEN_SERVICE_USE_IP,
> CommonConfigurationKeys.HADOOP_SECURITY_TOKEN_SERVICE_USE_IP_DEFAULT);
> setTokenServiceUseIp(useIp);
> }
> {code}
> This is a problem for clients, such as Oozie, who don't add *-site.xml files
> to their classpath. Oozie normally creates a {{JobClient}} and passes a
> {{Configuration}} to it with the proper configs we need. However, because
> {{hadoop.security.token.service.use_ip}} is specified in a static block like
> this, and there's no API to change it, Oozie has no way to set it to the
> non-default value.
> I propose we add a {{setConfiguration}} method which takes a
> {{Configuration}} and rereads {{hadoop.security.token.service.use_ip}}.
> There's a few other properties that are also loaded statically on startup
> that can be reloaded here as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-12954) Add a way to change hadoop.security.token.service.use_ip
[
https://issues.apache.org/jira/browse/HADOOP-12954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15214753#comment-15214753
]
Hudson commented on HADOOP-12954:
-
FAILURE: Integrated in Hadoop-trunk-Commit #9513 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/9513/])
HADOOP-12954. Add a way to change hadoop.security.token.service.use_ip
(rkanter: rev 8cac1bb09f55ff2f285914e349507472ff86f4d7)
*
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestSecurityUtil.java
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java
> Add a way to change hadoop.security.token.service.use_ip
>
>
> Key: HADOOP-12954
> URL: https://issues.apache.org/jira/browse/HADOOP-12954
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
>Affects Versions: 2.6.0
>Reporter: Robert Kanter
>Assignee: Robert Kanter
> Fix For: 2.9.0
>
> Attachments: HADOOP-12954.001.patch, HADOOP-12954.002.patch,
> HADOOP-12954.003.patch
>
>
> Currently, {{hadoop.security.token.service.use_ip}} is set on JVM startup via:
> {code:java}
> static {
> Configuration conf = new Configuration();
> boolean useIp = conf.getBoolean(
> CommonConfigurationKeys.HADOOP_SECURITY_TOKEN_SERVICE_USE_IP,
> CommonConfigurationKeys.HADOOP_SECURITY_TOKEN_SERVICE_USE_IP_DEFAULT);
> setTokenServiceUseIp(useIp);
> }
> {code}
> This is a problem for clients, such as Oozie, who don't add *-site.xml files
> to their classpath. Oozie normally creates a {{JobClient}} and passes a
> {{Configuration}} to it with the proper configs we need. However, because
> {{hadoop.security.token.service.use_ip}} is specified in a static block like
> this, and there's no API to change it, Oozie has no way to set it to the
> non-default value.
> I propose we add a {{setConfiguration}} method which takes a
> {{Configuration}} and rereads {{hadoop.security.token.service.use_ip}}.
> There's a few other properties that are also loaded statically on startup
> that can be reloaded here as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12954) Add a way to change hadoop.security.token.service.use_ip
[
https://issues.apache.org/jira/browse/HADOOP-12954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15213035#comment-15213035
]
Steve Loughran commented on HADOOP-12954:
-
LGTM: +1
> Add a way to change hadoop.security.token.service.use_ip
>
>
> Key: HADOOP-12954
> URL: https://issues.apache.org/jira/browse/HADOOP-12954
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
>Affects Versions: 2.6.0
>Reporter: Robert Kanter
>Assignee: Robert Kanter
> Attachments: HADOOP-12954.001.patch, HADOOP-12954.002.patch,
> HADOOP-12954.003.patch
>
>
> Currently, {{hadoop.security.token.service.use_ip}} is set on JVM startup via:
> {code:java}
> static {
> Configuration conf = new Configuration();
> boolean useIp = conf.getBoolean(
> CommonConfigurationKeys.HADOOP_SECURITY_TOKEN_SERVICE_USE_IP,
> CommonConfigurationKeys.HADOOP_SECURITY_TOKEN_SERVICE_USE_IP_DEFAULT);
> setTokenServiceUseIp(useIp);
> }
> {code}
> This is a problem for clients, such as Oozie, who don't add *-site.xml files
> to their classpath. Oozie normally creates a {{JobClient}} and passes a
> {{Configuration}} to it with the proper configs we need. However, because
> {{hadoop.security.token.service.use_ip}} is specified in a static block like
> this, and there's no API to change it, Oozie has no way to set it to the
> non-default value.
> I propose we add a {{setConfiguration}} method which takes a
> {{Configuration}} and rereads {{hadoop.security.token.service.use_ip}}.
> There's a few other properties that are also loaded statically on startup
> that can be reloaded here as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12954) Add a way to change hadoop.security.token.service.use_ip
[
https://issues.apache.org/jira/browse/HADOOP-12954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212310#comment-15212310
]
Robert Kanter commented on HADOOP-12954:
License warnings and unit test failures are unrelated
> Add a way to change hadoop.security.token.service.use_ip
>
>
> Key: HADOOP-12954
> URL: https://issues.apache.org/jira/browse/HADOOP-12954
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
>Affects Versions: 2.6.0
>Reporter: Robert Kanter
>Assignee: Robert Kanter
> Attachments: HADOOP-12954.001.patch, HADOOP-12954.002.patch,
> HADOOP-12954.003.patch
>
>
> Currently, {{hadoop.security.token.service.use_ip}} is set on JVM startup via:
> {code:java}
> static {
> Configuration conf = new Configuration();
> boolean useIp = conf.getBoolean(
> CommonConfigurationKeys.HADOOP_SECURITY_TOKEN_SERVICE_USE_IP,
> CommonConfigurationKeys.HADOOP_SECURITY_TOKEN_SERVICE_USE_IP_DEFAULT);
> setTokenServiceUseIp(useIp);
> }
> {code}
> This is a problem for clients, such as Oozie, who don't add *-site.xml files
> to their classpath. Oozie normally creates a {{JobClient}} and passes a
> {{Configuration}} to it with the proper configs we need. However, because
> {{hadoop.security.token.service.use_ip}} is specified in a static block like
> this, and there's no API to change it, Oozie has no way to set it to the
> non-default value.
> I propose we add a {{setConfiguration}} method which takes a
> {{Configuration}} and rereads {{hadoop.security.token.service.use_ip}}.
> There's a few other properties that are also loaded statically on startup
> that can be reloaded here as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12954) Add a way to change hadoop.security.token.service.use_ip
[
https://issues.apache.org/jira/browse/HADOOP-12954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212308#comment-15212308
]
Hadoop QA commented on HADOOP-12954:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 19s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m
34s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 11m
42s {color} | {color:green} trunk passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 10m
11s {color} | {color:green} trunk passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
30s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 21s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
22s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 7s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 26s
{color} | {color:green} trunk passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 32s
{color} | {color:green} trunk passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
1s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 11m
40s {color} | {color:green} the patch passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 11m 40s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 10m
16s {color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 10m 16s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
31s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 19s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
19s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
24s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 24s
{color} | {color:green} the patch passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 31s
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 10m 40s {color}
| {color:red} hadoop-common in the patch failed with JDK v1.8.0_74. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 9m 55s {color}
| {color:red} hadoop-common in the patch failed with JDK v1.7.0_95. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 35s
{color} | {color:red} Patch generated 2 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 92m 24s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| JDK v1.8.0_74 Failed junit tests | hadoop.ipc.TestRPCWaitForProxy |
| | hadoop.fs.shell.find.TestIname |
| JDK v1.8.0_74 Timed out junit tests |
org.apache.hadoop.util.TestNativeLibraryChecker |
| JDK v1.7.0_95 Timed out junit tests |
org.apache.hadoop.util.TestNativeLibraryChecker |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:fbe3e86 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12795436/HADOOP-12954.003.patch
|
| JIRA Issue | HADOOP-12954 |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux d7829f319579 3.13.0-36-lowlatency #63-Ubuntu SMP
[jira] [Commented] (HADOOP-12954) Add a way to change hadoop.security.token.service.use_ip
[
https://issues.apache.org/jira/browse/HADOOP-12954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15211751#comment-15211751
]
Steve Loughran commented on HADOOP-12954:
-
Can we have some log@ debug mention that the IP flag has been set?
> Add a way to change hadoop.security.token.service.use_ip
>
>
> Key: HADOOP-12954
> URL: https://issues.apache.org/jira/browse/HADOOP-12954
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
>Affects Versions: 2.6.0
>Reporter: Robert Kanter
>Assignee: Robert Kanter
> Attachments: HADOOP-12954.001.patch, HADOOP-12954.002.patch
>
>
> Currently, {{hadoop.security.token.service.use_ip}} is set on JVM startup via:
> {code:java}
> static {
> Configuration conf = new Configuration();
> boolean useIp = conf.getBoolean(
> CommonConfigurationKeys.HADOOP_SECURITY_TOKEN_SERVICE_USE_IP,
> CommonConfigurationKeys.HADOOP_SECURITY_TOKEN_SERVICE_USE_IP_DEFAULT);
> setTokenServiceUseIp(useIp);
> }
> {code}
> This is a problem for clients, such as Oozie, who don't add *-site.xml files
> to their classpath. Oozie normally creates a {{JobClient}} and passes a
> {{Configuration}} to it with the proper configs we need. However, because
> {{hadoop.security.token.service.use_ip}} is specified in a static block like
> this, and there's no API to change it, Oozie has no way to set it to the
> non-default value.
> I propose we add a {{setConfiguration}} method which takes a
> {{Configuration}} and rereads {{hadoop.security.token.service.use_ip}}.
> There's a few other properties that are also loaded statically on startup
> that can be reloaded here as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12954) Add a way to change hadoop.security.token.service.use_ip
[
https://issues.apache.org/jira/browse/HADOOP-12954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209487#comment-15209487
]
Hadoop QA commented on HADOOP-12954:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 18s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
10s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 46s
{color} | {color:green} trunk passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m 55s
{color} | {color:green} trunk passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
25s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 9s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
42s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 57s
{color} | {color:green} trunk passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 8s
{color} | {color:green} trunk passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
46s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 46s
{color} | {color:green} the patch passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m 46s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m 32s
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 7m 32s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
26s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 8s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 2s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 4s
{color} | {color:green} the patch passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 18s
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 7m 31s {color}
| {color:red} hadoop-common in the patch failed with JDK v1.8.0_74. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 7m 41s {color}
| {color:red} hadoop-common in the patch failed with JDK v1.7.0_95. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 36s
{color} | {color:red} Patch generated 2 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 67m 12s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| JDK v1.8.0_74 Timed out junit tests |
org.apache.hadoop.util.TestNativeLibraryChecker |
| JDK v1.7.0_95 Timed out junit tests |
org.apache.hadoop.util.TestNativeLibraryChecker |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:fbe3e86 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12795070/HADOOP-12954.002.patch
|
| JIRA Issue | HADOOP-12954 |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux ae673bea6f5e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
[jira] [Commented] (HADOOP-12954) Add a way to change hadoop.security.token.service.use_ip
[
https://issues.apache.org/jira/browse/HADOOP-12954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209188#comment-15209188
]
Steve Loughran commented on HADOOP-12954:
-
What's going to happen if this method is called during the execution of a
service?
I'd propose having an inner and and outer method, with the outer one logging
(info?) that this update has happened, The inner one would be the one used at
startup
> Add a way to change hadoop.security.token.service.use_ip
>
>
> Key: HADOOP-12954
> URL: https://issues.apache.org/jira/browse/HADOOP-12954
> Project: Hadoop Common
> Issue Type: Bug
>Affects Versions: 2.6.0
>Reporter: Robert Kanter
>Assignee: Robert Kanter
> Attachments: HADOOP-12954.001.patch
>
>
> Currently, {{hadoop.security.token.service.use_ip}} is set on JVM startup via:
> {code:java}
> static {
> Configuration conf = new Configuration();
> boolean useIp = conf.getBoolean(
> CommonConfigurationKeys.HADOOP_SECURITY_TOKEN_SERVICE_USE_IP,
> CommonConfigurationKeys.HADOOP_SECURITY_TOKEN_SERVICE_USE_IP_DEFAULT);
> setTokenServiceUseIp(useIp);
> }
> {code}
> This is a problem for clients, such as Oozie, who don't add *-site.xml files
> to their classpath. Oozie normally creates a {{JobClient}} and passes a
> {{Configuration}} to it with the proper configs we need. However, because
> {{hadoop.security.token.service.use_ip}} is specified in a static block like
> this, and there's no API to change it, Oozie has no way to set it to the
> non-default value.
> I propose we add a {{setConfiguration}} method which takes a
> {{Configuration}} and rereads {{hadoop.security.token.service.use_ip}}.
> There's a few other properties that are also loaded statically on startup
> that can be reloaded here as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12954) Add a way to change hadoop.security.token.service.use_ip
[
https://issues.apache.org/jira/browse/HADOOP-12954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208820#comment-15208820
]
Robert Kanter commented on HADOOP-12954:
License warnings and unit test failures are unrelated
> Add a way to change hadoop.security.token.service.use_ip
>
>
> Key: HADOOP-12954
> URL: https://issues.apache.org/jira/browse/HADOOP-12954
> Project: Hadoop Common
> Issue Type: Bug
>Affects Versions: 2.6.0
>Reporter: Robert Kanter
>Assignee: Robert Kanter
> Attachments: HADOOP-12954.001.patch
>
>
> Currently, {{hadoop.security.token.service.use_ip}} is set on JVM startup via:
> {code:java}
> static {
> Configuration conf = new Configuration();
> boolean useIp = conf.getBoolean(
> CommonConfigurationKeys.HADOOP_SECURITY_TOKEN_SERVICE_USE_IP,
> CommonConfigurationKeys.HADOOP_SECURITY_TOKEN_SERVICE_USE_IP_DEFAULT);
> setTokenServiceUseIp(useIp);
> }
> {code}
> This is a problem for clients, such as Oozie, who don't add *-site.xml files
> to their classpath. Oozie normally creates a {{JobClient}} and passes a
> {{Configuration}} to it with the proper configs we need. However, because
> {{hadoop.security.token.service.use_ip}} is specified in a static block like
> this, and there's no API to change it, Oozie has no way to set it to the
> non-default value.
> I propose we add a {{setConfiguration}} method which takes a
> {{Configuration}} and rereads {{hadoop.security.token.service.use_ip}}.
> There's a few other properties that are also loaded statically on startup
> that can be reloaded here as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12954) Add a way to change hadoop.security.token.service.use_ip
[
https://issues.apache.org/jira/browse/HADOOP-12954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207930#comment-15207930
]
Hadoop QA commented on HADOOP-12954:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 15s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
44s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 9m 48s
{color} | {color:green} trunk passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m 47s
{color} | {color:green} trunk passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
21s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 1s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
13s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
36s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 5s
{color} | {color:green} trunk passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 6s
{color} | {color:green} trunk passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
45s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m 36s
{color} | {color:green} the patch passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 8m 36s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m 47s
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 7m 47s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
21s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 59s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
13s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 1s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 13s
{color} | {color:green} the patch passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 15s
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 13m 59s {color}
| {color:red} hadoop-common in the patch failed with JDK v1.8.0_74. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 9m 27s {color}
| {color:red} hadoop-common in the patch failed with JDK v1.7.0_95. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 22s
{color} | {color:red} Patch generated 2 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 79m 3s {color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| JDK v1.8.0_74 Timed out junit tests |
org.apache.hadoop.util.TestNativeLibraryChecker |
| JDK v1.7.0_95 Timed out junit tests |
org.apache.hadoop.util.TestNativeLibraryChecker |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:fbe3e86 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12794885/HADOOP-12954.001.patch
|
| JIRA Issue | HADOOP-12954 |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux 76aff2f7e08a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
[jira] [Commented] (HADOOP-12954) Add a way to change hadoop.security.token.service.use_ip
[
https://issues.apache.org/jira/browse/HADOOP-12954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207552#comment-15207552
]
Robert Kanter commented on HADOOP-12954:
Ya, let's leave them both open. This is a Common change and the MR AM would be
in MapReduce, so we'd need to JIRAs anyway. We can add the
{{setConfiguration}} method in this JIRA and use MAPREDUCE-6565 to call it
(similar to what OOZIE-2490 is for).
> Add a way to change hadoop.security.token.service.use_ip
>
>
> Key: HADOOP-12954
> URL: https://issues.apache.org/jira/browse/HADOOP-12954
> Project: Hadoop Common
> Issue Type: Bug
>Affects Versions: 2.6.0
>Reporter: Robert Kanter
>Assignee: Robert Kanter
> Attachments: HADOOP-12954.001.patch
>
>
> Currently, {{hadoop.security.token.service.use_ip}} is set on JVM startup via:
> {code:java}
> static {
> Configuration conf = new Configuration();
> boolean useIp = conf.getBoolean(
> CommonConfigurationKeys.HADOOP_SECURITY_TOKEN_SERVICE_USE_IP,
> CommonConfigurationKeys.HADOOP_SECURITY_TOKEN_SERVICE_USE_IP_DEFAULT);
> setTokenServiceUseIp(useIp);
> }
> {code}
> This is a problem for clients, such as Oozie, who don't add *-site.xml files
> to their classpath. Oozie normally creates a {{JobClient}} and passes a
> {{Configuration}} to it with the proper configs we need. However, because
> {{hadoop.security.token.service.use_ip}} is specified in a static block like
> this, and there's no API to change it, Oozie has no way to set it to the
> non-default value.
> I propose we add a {{setConfiguration}} method which takes a
> {{Configuration}} and rereads {{hadoop.security.token.service.use_ip}}.
> There's a few other properties that are also loaded statically on startup
> that can be reloaded here as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12954) Add a way to change hadoop.security.token.service.use_ip
[
https://issues.apache.org/jira/browse/HADOOP-12954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207529#comment-15207529
]
Chris Nauroth commented on HADOOP-12954:
Thanks, Robert. I think this makes sense. I guess the new
{{SecurityUtil#setConfiguration}} call would have to be wired into the MR AM.
If you weren't planning on doing that within the scope of this issue, then
maybe it makes more sense to keep both open instead of resolving one as
duplicate of another.
bq. Though for MAPREDUCE-6565, why can't you have a core-site.xml added via
mapreduce.application.classpath?
You can, but when I filed MAPREDUCE-6565, I was asserting that you shouldn't
have to do this. The behavior is different from a lot of other things in that
the correct value of use_ip doesn't propagate down via the submitted job.xml.
> Add a way to change hadoop.security.token.service.use_ip
>
>
> Key: HADOOP-12954
> URL: https://issues.apache.org/jira/browse/HADOOP-12954
> Project: Hadoop Common
> Issue Type: Bug
>Affects Versions: 2.6.0
>Reporter: Robert Kanter
>Assignee: Robert Kanter
> Attachments: HADOOP-12954.001.patch
>
>
> Currently, {{hadoop.security.token.service.use_ip}} is set on JVM startup via:
> {code:java}
> static {
> Configuration conf = new Configuration();
> boolean useIp = conf.getBoolean(
> CommonConfigurationKeys.HADOOP_SECURITY_TOKEN_SERVICE_USE_IP,
> CommonConfigurationKeys.HADOOP_SECURITY_TOKEN_SERVICE_USE_IP_DEFAULT);
> setTokenServiceUseIp(useIp);
> }
> {code}
> This is a problem for clients, such as Oozie, who don't add *-site.xml files
> to their classpath. Oozie normally creates a {{JobClient}} and passes a
> {{Configuration}} to it with the proper configs we need. However, because
> {{hadoop.security.token.service.use_ip}} is specified in a static block like
> this, and there's no API to change it, Oozie has no way to set it to the
> non-default value.
> I propose we add a {{setConfiguration}} method which takes a
> {{Configuration}} and rereads {{hadoop.security.token.service.use_ip}}.
> There's a few other properties that are also loaded statically on startup
> that can be reloaded here as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12954) Add a way to change hadoop.security.token.service.use_ip
[
https://issues.apache.org/jira/browse/HADOOP-12954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207503#comment-15207503
]
Robert Kanter commented on HADOOP-12954:
The end problems were different, but it's the same root cause:
{{hadoop.security.token.service.use_ip}} is initialized from the classpath and
core-site.xml isn't there.
I think my proposal should work to solve both problems. The Oozie server can
call {{SecurityUtil.setConfiguration(conf)}} to pass the {{Configuration}} it
loaded. The MR AM could do the same. Though for MAPREDUCE-6565, why can't you
have a core-site.xml added via {{mapreduce.application.classpath}}?
> Add a way to change hadoop.security.token.service.use_ip
>
>
> Key: HADOOP-12954
> URL: https://issues.apache.org/jira/browse/HADOOP-12954
> Project: Hadoop Common
> Issue Type: Bug
>Affects Versions: 2.6.0
>Reporter: Robert Kanter
>Assignee: Robert Kanter
>
> Currently, {{hadoop.security.token.service.use_ip}} is set on JVM startup via:
> {code:java}
> static {
> Configuration conf = new Configuration();
> boolean useIp = conf.getBoolean(
> CommonConfigurationKeys.HADOOP_SECURITY_TOKEN_SERVICE_USE_IP,
> CommonConfigurationKeys.HADOOP_SECURITY_TOKEN_SERVICE_USE_IP_DEFAULT);
> setTokenServiceUseIp(useIp);
> }
> {code}
> This is a problem for clients, such as Oozie, who don't add *-site.xml files
> to their classpath. Oozie normally creates a {{JobClient}} and passes a
> {{Configuration}} to it with the proper configs we need. However, because
> {{hadoop.security.token.service.use_ip}} is specified in a static block like
> this, and there's no API to change it, Oozie has no way to set it to the
> non-default value.
> I propose we add a {{setConfiguration}} method which takes a
> {{Configuration}} and rereads {{hadoop.security.token.service.use_ip}}.
> There's a few other properties that are also loaded statically on startup
> that can be reloaded here as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12954) Add a way to change hadoop.security.token.service.use_ip
[
https://issues.apache.org/jira/browse/HADOOP-12954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207496#comment-15207496
]
Chris Nauroth commented on HADOOP-12954:
Hi [~rkanter]. Is this a duplicate of MAPREDUCE-6565?
> Add a way to change hadoop.security.token.service.use_ip
>
>
> Key: HADOOP-12954
> URL: https://issues.apache.org/jira/browse/HADOOP-12954
> Project: Hadoop Common
> Issue Type: Bug
>Affects Versions: 2.6.0
>Reporter: Robert Kanter
>Assignee: Robert Kanter
>
> Currently, {{hadoop.security.token.service.use_ip}} is set on JVM startup via:
> {code:java}
> static {
> Configuration conf = new Configuration();
> boolean useIp = conf.getBoolean(
> CommonConfigurationKeys.HADOOP_SECURITY_TOKEN_SERVICE_USE_IP,
> CommonConfigurationKeys.HADOOP_SECURITY_TOKEN_SERVICE_USE_IP_DEFAULT);
> setTokenServiceUseIp(useIp);
> }
> {code}
> This is a problem for clients, such as Oozie, who don't add *-site.xml files
> to their classpath. Oozie normally creates a {{JobClient}} and passes a
> {{Configuration}} to it with the proper configs we need. However, because
> {{hadoop.security.token.service.use_ip}} is specified in a static block like
> this, and there's no API to change it, Oozie has no way to set it to the
> non-default value.
> I propose we add a {{setConfiguration}} method which takes a
> {{Configuration}} and rereads {{hadoop.security.token.service.use_ip}}.
> There's a few other properties that are also loaded statically on startup
> that can be reloaded here as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
