[jira] [Commented] (HADOOP-13802) Make generic options help more consistent, and aligned
[
https://issues.apache.org/jira/browse/HADOOP-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15651744#comment-15651744
]
Grant Sohn commented on HADOOP-13802:
-
[~liuml07], thanks for your help getting this in.
> Make generic options help more consistent, and aligned
> --
>
> Key: HADOOP-13802
> URL: https://issues.apache.org/jira/browse/HADOOP-13802
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.6.0
>Reporter: Grant Sohn
>Assignee: Grant Sohn
>Priority: Minor
> Fix For: 2.9.0, 3.0.0-alpha2
>
> Attachments: HADOOP-13802.1.patch, HADOOP-13802.2.patch,
> HADOOP-13802.3.patch, HADOOP-13802.4.patch
>
>
> The generic options have always been this:
> {noformat}
> Generic options supported are
> -conf specify an application configuration file
> -D
[jira] [Commented] (HADOOP-13802) Make generic options help more consistent, and aligned
[
https://issues.apache.org/jira/browse/HADOOP-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15649256#comment-15649256
]
Hudson commented on HADOOP-13802:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10792 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/10792/])
HADOOP-13802. Make generic options help more consistent, and aligned. (liuml07:
rev 2a65eb121e23243fcb642d28b3f74241536485d8)
* (edit)
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java
> Make generic options help more consistent, and aligned
> --
>
> Key: HADOOP-13802
> URL: https://issues.apache.org/jira/browse/HADOOP-13802
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.6.0
>Reporter: Grant Sohn
>Assignee: Grant Sohn
>Priority: Minor
> Fix For: 2.9.0, 3.0.0-alpha2
>
> Attachments: HADOOP-13802.1.patch, HADOOP-13802.2.patch,
> HADOOP-13802.3.patch, HADOOP-13802.4.patch
>
>
> The generic options have always been this:
> {noformat}
> Generic options supported are
> -conf specify an application configuration file
> -D
[jira] [Commented] (HADOOP-13802) Make generic options help more consistent, and aligned
[
https://issues.apache.org/jira/browse/HADOOP-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15649195#comment-15649195
]
Hadoop QA commented on HADOOP-13802:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
46s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 10m
46s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
33s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
5s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
21s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
27s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
51s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 9m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 9m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
33s{color} | {color:green} hadoop-common-project/hadoop-common: The patch
generated 0 new + 30 unchanged - 4 fixed = 30 total (was 34) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 7m 26s{color}
| {color:red} hadoop-common in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
38s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 46m 33s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.net.TestClusterTopology |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:e809691 |
| JIRA Issue | HADOOP-13802 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12838066/HADOOP-13802.4.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux ce58a75a275f 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18
21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / 29e3b34 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| unit |
https://builds.apache.org/job/PreCommit-HADOOP-Build/11033/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/11033/testReport/ |
| modules | C: hadoop-common-project/hadoop-common U:
hadoop-common-project/hadoop-common |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/11033/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Make generic options help more consistent, and aligned
> --
>
> Key: HADOOP-13802
> URL:
[jira] [Commented] (HADOOP-13802) Make generic options help more consistent, and aligned
[
https://issues.apache.org/jira/browse/HADOOP-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648989#comment-15648989
]
Grant Sohn commented on HADOOP-13802:
-
Code change only reformatting text, does not require a test.
> Make generic options help more consistent, and aligned
> --
>
> Key: HADOOP-13802
> URL: https://issues.apache.org/jira/browse/HADOOP-13802
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.6.0
>Reporter: Grant Sohn
>Assignee: Grant Sohn
>Priority: Minor
> Attachments: HADOOP-13802.1.patch, HADOOP-13802.2.patch,
> HADOOP-13802.3.patch
>
>
> The generic options have always been this:
> {noformat}
> Generic options supported are
> -conf specify an application configuration file
> -D
[jira] [Commented] (HADOOP-13802) Make generic options help more consistent, and aligned
[
https://issues.apache.org/jira/browse/HADOOP-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648691#comment-15648691
]
Hadoop QA commented on HADOOP-13802:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
29s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 11m
17s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
33s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
7s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
23s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
30s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
52s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 10m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 10m
5s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 34s{color} | {color:orange} hadoop-common-project/hadoop-common: The patch
generated 6 new + 30 unchanged - 4 fixed = 36 total (was 34) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 8m
53s{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
42s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 50m 42s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:e809691 |
| JIRA Issue | HADOOP-13802 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12838035/HADOOP-13802.3.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux 455dd2b763c6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / dbb133c |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HADOOP-Build/11027/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/11027/testReport/ |
| modules | C: hadoop-common-project/hadoop-common U:
hadoop-common-project/hadoop-common |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/11027/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Make generic options help more consistent, and aligned
> --
>
> Key: HADOOP-13802
> URL: https://issues.apache.org/jira/browse/HADOOP-13802
>
[jira] [Commented] (HADOOP-13802) Make generic options help more consistent, and aligned
[
https://issues.apache.org/jira/browse/HADOOP-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648517#comment-15648517
]
Grant Sohn commented on HADOOP-13802:
-
Fixed.
> Make generic options help more consistent, and aligned
> --
>
> Key: HADOOP-13802
> URL: https://issues.apache.org/jira/browse/HADOOP-13802
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.6.0
>Reporter: Grant Sohn
>Assignee: Grant Sohn
>Priority: Minor
> Attachments: HADOOP-13802.1.patch, HADOOP-13802.2.patch,
> HADOOP-13802.3.patch
>
>
> The generic options have always been this:
> {noformat}
> Generic options supported are
> -conf specify an application configuration file
> -D
[jira] [Commented] (HADOOP-13802) Make generic options help more consistent, and aligned
[
https://issues.apache.org/jira/browse/HADOOP-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15647252#comment-15647252
]
Akira Ajisaka commented on HADOOP-13802:
Agreed.
> Make generic options help more consistent, and aligned
> --
>
> Key: HADOOP-13802
> URL: https://issues.apache.org/jira/browse/HADOOP-13802
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.6.0
>Reporter: Grant Sohn
>Assignee: Grant Sohn
>Priority: Minor
> Attachments: HADOOP-13802.1.patch, HADOOP-13802.2.patch
>
>
> The generic options have always been this:
> {noformat}
> Generic options supported are
> -conf specify an application configuration file
> -D
[jira] [Commented] (HADOOP-13802) Make generic options help more consistent, and aligned
[
https://issues.apache.org/jira/browse/HADOOP-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15646689#comment-15646689
]
Grant Sohn commented on HADOOP-13802:
-
Would it okay, I replace the '\n' with println() instead? This implicitly uses
line.separator.
> Make generic options help more consistent, and aligned
> --
>
> Key: HADOOP-13802
> URL: https://issues.apache.org/jira/browse/HADOOP-13802
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.6.0
>Reporter: Grant Sohn
>Assignee: Grant Sohn
>Priority: Minor
> Attachments: HADOOP-13802.1.patch, HADOOP-13802.2.patch
>
>
> The generic options have always been this:
> {noformat}
> Generic options supported are
> -conf specify an application configuration file
> -D
[jira] [Commented] (HADOOP-13802) Make generic options help more consistent, and aligned
[
https://issues.apache.org/jira/browse/HADOOP-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15646136#comment-15646136
]
Akira Ajisaka commented on HADOOP-13802:
Mostly looks good to me.
Would you replace {{\n}} with {{System.getProperty("line.separator")}} to
support Windows environment?
> Make generic options help more consistent, and aligned
> --
>
> Key: HADOOP-13802
> URL: https://issues.apache.org/jira/browse/HADOOP-13802
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.6.0
>Reporter: Grant Sohn
>Assignee: Grant Sohn
>Priority: Minor
> Attachments: HADOOP-13802.1.patch, HADOOP-13802.2.patch
>
>
> The generic options have always been this:
> {noformat}
> Generic options supported are
> -conf specify an application configuration file
> -D
[jira] [Commented] (HADOOP-13802) Make generic options help more consistent, and aligned
[
https://issues.apache.org/jira/browse/HADOOP-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15645532#comment-15645532
]
Hadoop QA commented on HADOOP-13802:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
19s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
7s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 12m
5s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
33s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
15s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
22s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
45s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
52s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 10m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 10m
31s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 31s{color} | {color:orange} hadoop-common-project/hadoop-common: The patch
generated 6 new + 30 unchanged - 4 fixed = 36 total (was 34) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 9m
3s{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
40s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 53m 14s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:e809691 |
| JIRA Issue | HADOOP-13802 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12837836/HADOOP-13802.2.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux b7e633c0909b 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29
20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / de3b4aa |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HADOOP-Build/11012/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/11012/testReport/ |
| modules | C: hadoop-common-project/hadoop-common U:
hadoop-common-project/hadoop-common |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/11012/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Make generic options help more consistent, and aligned
> --
>
> Key: HADOOP-13802
> URL: https://issues.apache.org/jira/browse/HADOOP-13802
> Project:
[jira] [Commented] (HADOOP-13802) Make generic options help more consistent, and aligned
[
https://issues.apache.org/jira/browse/HADOOP-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15645417#comment-15645417
]
Hadoop QA commented on HADOOP-13802:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
20s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
14s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 12m
49s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
34s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
12s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
23s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
34s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
52s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 9m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 9m
40s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 32s{color} | {color:orange} hadoop-common-project/hadoop-common: The patch
generated 6 new + 30 unchanged - 4 fixed = 36 total (was 34) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 9m
15s{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
41s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 51m 59s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:e809691 |
| JIRA Issue | HADOOP-13802 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12837827/HADOOP-13802.1.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux 4c89f01f1505 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29
20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / de3b4aa |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HADOOP-Build/11011/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/11011/testReport/ |
| modules | C: hadoop-common-project/hadoop-common U:
hadoop-common-project/hadoop-common |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/11011/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Make generic options help more consistent, and aligned
> --
>
> Key: HADOOP-13802
> URL: https://issues.apache.org/jira/browse/HADOOP-13802
> Project:
[jira] [Commented] (HADOOP-13802) Make generic options help more consistent, and aligned
[
https://issues.apache.org/jira/browse/HADOOP-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15645217#comment-15645217
]
Mingliang Liu commented on HADOOP-13802:
{code}
out.println("bin/hadoop command [genericOptions] [commandOptions]\n");
{code}
we can simply replace bin/hadoop with hadoop. The PATH may be set, and the
working directory may not be the $HADOOP_HOME.
+1 other than that (pending on Jenkins).
Ping [~ajisakaa] for 2nd opinion.
> Make generic options help more consistent, and aligned
> --
>
> Key: HADOOP-13802
> URL: https://issues.apache.org/jira/browse/HADOOP-13802
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.6.0
>Reporter: Grant Sohn
>Assignee: Grant Sohn
>Priority: Trivial
> Attachments: HADOOP-13802.1.patch
>
>
> The generic options have always been this:
> {noformat}
> Generic options supported are
> -conf specify an application configuration file
> -D
[jira] [Commented] (HADOOP-13802) Make generic options help more consistent, and aligned
[
https://issues.apache.org/jira/browse/HADOOP-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15645142#comment-15645142
]
Grant Sohn commented on HADOOP-13802:
-
I'll try to add one shortly.
> Make generic options help more consistent, and aligned
> --
>
> Key: HADOOP-13802
> URL: https://issues.apache.org/jira/browse/HADOOP-13802
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.6.0
>Reporter: Grant Sohn
>Priority: Trivial
>
> The generic options have always been this:
> {noformat}
> Generic options supported are
> -conf specify an application configuration file
> -D
[jira] [Commented] (HADOOP-13802) Make generic options help more consistent, and aligned
[
https://issues.apache.org/jira/browse/HADOOP-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15645072#comment-15645072
]
Mingliang Liu commented on HADOOP-13802:
Do you mind providing a patch? I can review/commit this after that. If I'm
asking too much, I'll assign this to someone else.
> Make generic options help more consistent, and aligned
> --
>
> Key: HADOOP-13802
> URL: https://issues.apache.org/jira/browse/HADOOP-13802
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.6.0
>Reporter: Grant Sohn
>Priority: Trivial
>
> The generic options have always been this:
> {noformat}
> Generic options supported are
> -conf specify an application configuration file
> -D
[jira] [Commented] (HADOOP-13802) Make generic options help more consistent, and aligned
[
https://issues.apache.org/jira/browse/HADOOP-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15645059#comment-15645059
]
Mingliang Liu commented on HADOOP-13802:
{quote}
My only nit on this is adding the ":" at the end of "The general command line
syntax is:".
{quote}
...and the option/description is aligned?
> Make generic options help more consistent, and aligned
> --
>
> Key: HADOOP-13802
> URL: https://issues.apache.org/jira/browse/HADOOP-13802
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.6.0
>Reporter: Grant Sohn
>Priority: Trivial
>
> The generic options have always been this:
> {noformat}
> Generic options supported are
> -conf specify an application configuration file
> -D
[jira] [Commented] (HADOOP-13802) Make generic options help more consistent, and aligned
[
https://issues.apache.org/jira/browse/HADOOP-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15645055#comment-15645055
]
Grant Sohn commented on HADOOP-13802:
-
That was a mistake on my part. Here is the corrected version.
{noformat}
Generic options supported are:
-conf specify an application configuration file
-D
[jira] [Commented] (HADOOP-13802) Make generic options help more consistent, and aligned
[
https://issues.apache.org/jira/browse/HADOOP-13802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15645041#comment-15645041
]
Mingliang Liu commented on HADOOP-13802:
The format looks pretty good.
Are we removing
{code}
The general command line syntax is bin/hadoop command [genericOptions]
[commandOptions]
{code}
which I don't quite support. We have to tell the user that genericOptions comes
before commandOptions, don't we?
> Make generic options help more consistent, and aligned
> --
>
> Key: HADOOP-13802
> URL: https://issues.apache.org/jira/browse/HADOOP-13802
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.6.0
>Reporter: Grant Sohn
>Priority: Trivial
>
> The generic options have always been this:
> {noformat}
> Generic options supported are
> -conf specify an application configuration file
> -D
