[jira] [Commented] (HADOOP-14218) Replace assertThat with assertTrue in MetricsAsserts
[
https://issues.apache.org/jira/browse/HADOOP-14218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944590#comment-15944590
]
Hudson commented on HADOOP-14218:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11478 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/11478/])
HADOOP-14218. Replace assertThat with assertTrue in MetricsAsserts. (aajisaka:
rev 448ec81fd7133f413853570f116d5f6e16f68bd9)
* (edit)
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/MetricsAsserts.java
> Replace assertThat with assertTrue in MetricsAsserts
>
>
> Key: HADOOP-14218
> URL: https://issues.apache.org/jira/browse/HADOOP-14218
> Project: Hadoop Common
> Issue Type: Test
>Reporter: Akira Ajisaka
>Assignee: Akira Ajisaka
>Priority: Minor
> Fix For: 2.9.0, 3.0.0-alpha3
>
> Attachments: HADOOP-14218.01.patch
>
>
> {code:title=MetricsAsserts.java}
> public static void assertCounterGt(String name, long greater,
> MetricsRecordBuilder rb) {
> Assert.assertThat("Bad value for metric " + name, getLongCounter(name,
> rb),
> new GreaterThan(greater));
> }
> {code}
> The following code cannot be compiled with Mockito 2.1+ because it does not
> depend on org.hamcrest.Matcher anymore. We can simply replace this code with
> {{assertTrue(message, getLongCounter() > greater)}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14218) Replace assertThat with assertTrue in MetricsAsserts
[
https://issues.apache.org/jira/browse/HADOOP-14218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15943530#comment-15943530
]
Haibo Chen commented on HADOOP-14218:
-
+1 nonbinding
> Replace assertThat with assertTrue in MetricsAsserts
>
>
> Key: HADOOP-14218
> URL: https://issues.apache.org/jira/browse/HADOOP-14218
> Project: Hadoop Common
> Issue Type: Test
>Reporter: Akira Ajisaka
>Assignee: Akira Ajisaka
>Priority: Minor
> Attachments: HADOOP-14218.01.patch
>
>
> {code:title=MetricsAsserts.java}
> public static void assertCounterGt(String name, long greater,
> MetricsRecordBuilder rb) {
> Assert.assertThat("Bad value for metric " + name, getLongCounter(name,
> rb),
> new GreaterThan(greater));
> }
> {code}
> The following code cannot be compiled with Mockito 2.1+ because it does not
> depend on org.hamcrest.Matcher anymore. We can simply replace this code with
> {{assertTrue(message, getLongCounter() > greater)}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14218) Replace assertThat with assertTrue in MetricsAsserts
[
https://issues.apache.org/jira/browse/HADOOP-14218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942816#comment-15942816
]
Hadoop QA commented on HADOOP-14218:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
18s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 12m
38s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 17m
17s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
36s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
6s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
19s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
30s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
48s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 15m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 15m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 8m 57s{color}
| {color:red} hadoop-common in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
34s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 66m 56s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.ha.TestZKFailoverController |
| | hadoop.security.TestKDiag |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:a9ad5d6 |
| JIRA Issue | HADOOP-14218 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12860603/HADOOP-14218.01.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux 575d87761382 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6
15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / 945b006 |
| Default Java | 1.8.0_121 |
| findbugs | v3.0.0 |
| unit |
https://builds.apache.org/job/PreCommit-HADOOP-Build/11935/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/11935/testReport/ |
| modules | C: hadoop-common-project/hadoop-common U:
hadoop-common-project/hadoop-common |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/11935/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Replace assertThat with assertTrue in MetricsAsserts
>
>
> Key: HADOOP-14218
> URL: https://issues.apache.org/jira/browse/HADOOP-14218
> Project: Hadoop Common
> Issue Type: Test
>Reporter: Akira Ajisaka
>Assignee: Akira Ajisaka
>
