[
https://issues.apache.org/jira/browse/HADOOP-15158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16391230#comment-16391230
]
Steve Loughran commented on HADOOP-15158:
-
Is this adding the idea of putting user:secret into
[
https://issues.apache.org/jira/browse/HADOOP-15158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387825#comment-16387825
]
wujinhu commented on HADOOP-15158:
--
[~Sammi] Please help to review this patch, thanks!
> AliyunOSS:
[
https://issues.apache.org/jira/browse/HADOOP-15158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376518#comment-16376518
]
wujinhu commented on HADOOP-15158:
--
Thanks [~ste...@apache.org] for the review. I have looked at the
[
https://issues.apache.org/jira/browse/HADOOP-15158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376511#comment-16376511
]
genericqa commented on HADOOP-15158:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332683#comment-16332683
]
Steve Loughran commented on HADOOP-15158:
-
Test wise, no need for
[
https://issues.apache.org/jira/browse/HADOOP-15158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332678#comment-16332678
]
Steve Loughran commented on HADOOP-15158:
-
You should have a look @ HADOOP-15141, and see if you
[
https://issues.apache.org/jira/browse/HADOOP-15158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328913#comment-16328913
]
genericqa commented on HADOOP-15158:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319836#comment-16319836
]
genericqa commented on HADOOP-15158:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319790#comment-16319790
]
wujinhu commented on HADOOP-15158:
--
Attach patch! I add a test to cover those changed code lines.
>
[
https://issues.apache.org/jira/browse/HADOOP-15158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319774#comment-16319774
]
genericqa commented on HADOOP-15158:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318900#comment-16318900
]
Steve Loughran commented on HADOOP-15158:
-
Changing the constructor is the simplest change for
11 matches
Mail list logo