[jira] [Commented] (HADOOP-15158) AliyunOSS: Supports role based credential in URL

2018-03-08 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16391230#comment-16391230 ] Steve Loughran commented on HADOOP-15158: - Is this adding the idea of putting user:secret into

[jira] [Commented] (HADOOP-15158) AliyunOSS: Supports role based credential in URL

2018-03-06 Thread wujinhu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387825#comment-16387825 ] wujinhu commented on HADOOP-15158: -- [~Sammi] Please help to review this patch, thanks! > AliyunOSS:

[jira] [Commented] (HADOOP-15158) AliyunOSS: Supports role based credential in URL

2018-02-26 Thread wujinhu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376518#comment-16376518 ] wujinhu commented on HADOOP-15158: -- Thanks [~ste...@apache.org] for the review. I have looked at the

[jira] [Commented] (HADOOP-15158) AliyunOSS: Supports role based credential in URL

2018-02-26 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376511#comment-16376511 ] genericqa commented on HADOOP-15158: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15158) AliyunOSS: Supports role based credential

2018-01-19 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332683#comment-16332683 ] Steve Loughran commented on HADOOP-15158: - Test wise, no need for

[jira] [Commented] (HADOOP-15158) AliyunOSS: Supports role based credential

2018-01-19 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332678#comment-16332678 ] Steve Loughran commented on HADOOP-15158: - You should have a look @ HADOOP-15141, and see if you

[jira] [Commented] (HADOOP-15158) AliyunOSS: Supports role based credential

2018-01-17 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328913#comment-16328913 ] genericqa commented on HADOOP-15158: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15158) AliyunOSS: Supports role based credential

2018-01-09 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319836#comment-16319836 ] genericqa commented on HADOOP-15158: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15158) AliyunOSS: Supports role based credential

2018-01-09 Thread wujinhu (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319790#comment-16319790 ] wujinhu commented on HADOOP-15158: -- Attach patch! I add a test to cover those changed code lines. >

[jira] [Commented] (HADOOP-15158) AliyunOSS: Supports role based credential

2018-01-09 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319774#comment-16319774 ] genericqa commented on HADOOP-15158: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15158) AliyunOSS: Supports role based credential

2018-01-09 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318900#comment-16318900 ] Steve Loughran commented on HADOOP-15158: - Changing the constructor is the simplest change for