[jira] [Commented] (HADOOP-15346) S3ARetryPolicy for 400/BadArgument to be "fail"
[ https://issues.apache.org/jira/browse/HADOOP-15346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433511#comment-16433511 ] Hudson commented on HADOOP-15346: - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13967 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/13967/]) HADOOP-15346 S3ARetryPolicy for 400/BadArgument to be "fail". (fabbri: rev b0aff8a96221fbf40d1eafe51b4f530b73146a20) * (edit) hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3ARetryPolicy.java * (edit) hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/TestInvoker.java > S3ARetryPolicy for 400/BadArgument to be "fail" > --- > > Key: HADOOP-15346 > URL: https://issues.apache.org/jira/browse/HADOOP-15346 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/s3 >Affects Versions: 3.1.0 >Reporter: Steve Loughran >Assignee: Steve Loughran >Priority: Major > Fix For: 3.1.1 > > Attachments: HADOOP-15346-001.patch > > > The retry policy for the AWS 400/BadArgument response is currently "treat as > a connectivity error" on the basis that sometimes it works again. > It doesn't, not normally, and by using the connectivity retry policy, > unrecoverable failures can take time to surface. > Proposed: switch to a fail fast policy for BadArgumentException -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15346) S3ARetryPolicy for 400/BadArgument to be "fail"
[ https://issues.apache.org/jira/browse/HADOOP-15346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433445#comment-16433445 ] Aaron Fabbri commented on HADOOP-15346: --- +1 on the patch, LGTM. Running through the tests now. > S3ARetryPolicy for 400/BadArgument to be "fail" > --- > > Key: HADOOP-15346 > URL: https://issues.apache.org/jira/browse/HADOOP-15346 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/s3 >Affects Versions: 3.1.0 >Reporter: Steve Loughran >Assignee: Steve Loughran >Priority: Major > Attachments: HADOOP-15346-001.patch > > > The retry policy for the AWS 400/BadArgument response is currently "treat as > a connectivity error" on the basis that sometimes it works again. > It doesn't, not normally, and by using the connectivity retry policy, > unrecoverable failures can take time to surface. > Proposed: switch to a fail fast policy for BadArgumentException -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15346) S3ARetryPolicy for 400/BadArgument to be "fail"
[ https://issues.apache.org/jira/browse/HADOOP-15346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426031#comment-16426031 ] genericqa commented on HADOOP-15346: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 11m 10s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 35m 23s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 33s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 24s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 41s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 11m 34s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 47s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 23s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 33s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 27s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 27s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 15s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 29s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 11m 33s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 18s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m 32s{color} | {color:green} hadoop-aws in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 23s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 80m 2s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8620d2b | | JIRA Issue | HADOOP-15346 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12917584/HADOOP-15346-001.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 3363f73882f6 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 7853ec8 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_162 | | findbugs | v3.1.0-RC1 | | Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/14434/testReport/ | | Max. process+thread count | 341 (vs. ulimit of 1) | | modules | C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws | | Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/14434/console | | Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > S3ARetryPolicy for 400/BadArgument to be "fail" > --- > > Key: HADOOP-15346 > URL:
[jira] [Commented] (HADOOP-15346) S3ARetryPolicy for 400/BadArgument to be "fail"
[ https://issues.apache.org/jira/browse/HADOOP-15346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425917#comment-16425917 ] Steve Loughran commented on HADOOP-15346: - Patch 001: move to fail fast on BR. > S3ARetryPolicy for 400/BadArgument to be "fail" > --- > > Key: HADOOP-15346 > URL: https://issues.apache.org/jira/browse/HADOOP-15346 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/s3 >Affects Versions: 3.1.0 >Reporter: Steve Loughran >Assignee: Steve Loughran >Priority: Major > Attachments: HADOOP-15346-001.patch > > > The retry policy for the AWS 400/BadArgument response is currently "treat as > a connectivity error" on the basis that sometimes it works again. > It doesn't, not normally, and by using the connectivity retry policy, > unrecoverable failures can take time to surface. > Proposed: switch to a fail fast policy for BadArgumentException -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org