[
https://issues.apache.org/jira/browse/HADOOP-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433084#comment-16433084
]
Hudson commented on HADOOP-15357:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13960 (See
[
https://issues.apache.org/jira/browse/HADOOP-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432419#comment-16432419
]
Jim Brennan commented on HADOOP-15357:
--
[~jlowe], [~lmccay], let me know if you would prefer that I
[
https://issues.apache.org/jira/browse/HADOOP-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430573#comment-16430573
]
Jim Brennan commented on HADOOP-15357:
--
[~lmccay], yeah, I think that functionality is covered by
[
https://issues.apache.org/jira/browse/HADOOP-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428702#comment-16428702
]
Larry McCay commented on HADOOP-15357:
--
I supposed the fact that get() is already tested for
[
https://issues.apache.org/jira/browse/HADOOP-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426962#comment-16426962
]
Jim Brennan commented on HADOOP-15357:
--
[~lmccay], looks like this is ready for review again. Only
[
https://issues.apache.org/jira/browse/HADOOP-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426321#comment-16426321
]
genericqa commented on HADOOP-15357:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426094#comment-16426094
]
Larry McCay commented on HADOOP-15357:
--
I don't disagree - that is not to say that I know that we
[
https://issues.apache.org/jira/browse/HADOOP-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426069#comment-16426069
]
Jim Brennan commented on HADOOP-15357:
--
[~lmccay], thanks for the review!
{quote}I notice that you
[
https://issues.apache.org/jira/browse/HADOOP-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425973#comment-16425973
]
Larry McCay commented on HADOOP-15357:
--
Hi [~Jim_Brennan] - the patch looks good.
I notice that
[
https://issues.apache.org/jira/browse/HADOOP-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424565#comment-16424565
]
Jim Brennan commented on HADOOP-15357:
--
[~lmccay], [~asuresh], I believe this patch is ready for
[
https://issues.apache.org/jira/browse/HADOOP-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424553#comment-16424553
]
genericqa commented on HADOOP-15357:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424387#comment-16424387
]
Jim Brennan commented on HADOOP-15357:
--
Renamed local variable to fix the check-style issue and
[
https://issues.apache.org/jira/browse/HADOOP-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424316#comment-16424316
]
genericqa commented on HADOOP-15357:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424056#comment-16424056
]
Jim Brennan commented on HADOOP-15357:
--
[~lmccay], thanks for the prompt replies. I will happy to
[
https://issues.apache.org/jira/browse/HADOOP-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423282#comment-16423282
]
Larry McCay commented on HADOOP-15357:
--
[~Jim_Brennan] - I think that both of your assertions are
[
https://issues.apache.org/jira/browse/HADOOP-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423054#comment-16423054
]
Jim Brennan commented on HADOOP-15357:
--
One additional question: shouldn't this code be using
[
https://issues.apache.org/jira/browse/HADOOP-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423004#comment-16423004
]
Jim Brennan commented on HADOOP-15357:
--
I think you can just replace this:
{code:java}
[
https://issues.apache.org/jira/browse/HADOOP-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422962#comment-16422962
]
Larry McCay commented on HADOOP-15357:
--
Hi [~Jim_Brennan] - this definitely is an oversight in the
[
https://issues.apache.org/jira/browse/HADOOP-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422925#comment-16422925
]
Jim Brennan commented on HADOOP-15357:
--
[~lmc...@apache.org], [~asuresh], can you please comment on
19 matches
Mail list logo
