[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462875#comment-16462875
]
Rushabh S Shah commented on HADOOP-15408:
-
bq. Fine as in "won't NPE"
It won't throw NPE.
bq.
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461298#comment-16461298
]
Xiao Chen commented on HADOOP-15408:
Could you please clarify?
Fine as in "won't NPE" or fine as in
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461216#comment-16461216
]
Rushabh S Shah commented on HADOOP-15408:
-
{quote}
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460431#comment-16460431
]
genericqa commented on HADOOP-15408:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460227#comment-16460227
]
Xiao Chen commented on HADOOP-15408:
Uploaded a poc.patch for discussion. Idea is simple: do not
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459988#comment-16459988
]
Xiao Chen commented on HADOOP-15408:
bq. Please file jiras against the components you've identified
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459983#comment-16459983
]
Xiao Chen commented on HADOOP-15408:
bq. We believe we are running the latest version of spark which
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459975#comment-16459975
]
Rushabh S Shah commented on HADOOP-15408:
-
bq. I want this fixed asap too,
We have fixed it
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459966#comment-16459966
]
Daryn Sharp commented on HADOOP-15408:
--
bq. I want this fixed asap too, but I'm afraid with the
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459926#comment-16459926
]
Xiao Chen commented on HADOOP-15408:
Thanks [~daryn] for the comment and background.
I want this
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459706#comment-16459706
]
Daryn Sharp commented on HADOOP-15408:
--
bq. Because it is a public API...
It is but it isn't.
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459485#comment-16459485
]
Xiao Chen commented on HADOOP-15408:
I find cycles to test this today, and was able to reproduce
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459107#comment-16459107
]
Xiao Chen commented on HADOOP-15408:
I was saying this because in patch 1, TestKMS was changed to
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458911#comment-16458911
]
Rushabh S Shah commented on HADOOP-15408:
-
bq. In other words, even though the bytes are the
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458842#comment-16458842
]
Xiao Chen commented on HADOOP-15408:
Thanks for the explanation, that feels better. :)
But as patch
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458803#comment-16458803
]
Rushabh S Shah commented on HADOOP-15408:
-
bq. so I assumed that was the st you saw...
Yes.
bq.
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458737#comment-16458737
]
Xiao Chen commented on HADOOP-15408:
bq. I was asking that where did you see this stack trace ?
That
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458731#comment-16458731
]
Rushabh S Shah commented on HADOOP-15408:
-
{quote}What exception did you see with this case?
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16455651#comment-16455651
]
Junping Du commented on HADOOP-15408:
-
Looks like previous patch doesn't land on 2.9.1 branch so
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16455487#comment-16455487
]
Xiao Chen commented on HADOOP-15408:
Thanks for testing [~shahrs87].
With both jars present you can
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16455478#comment-16455478
]
Rushabh S Shah commented on HADOOP-15408:
-
{quote}
java.util.ServiceConfigurationError:
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453233#comment-16453233
]
Xiao Chen commented on HADOOP-15408:
Thanks a lot!
> HADOOP-14445 broke Spark.
>
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452992#comment-16452992
]
Rushabh S Shah commented on HADOOP-15408:
-
bq. Would you be able to test whether the split
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452967#comment-16452967
]
Xiao Chen commented on HADOOP-15408:
No worries Rushabh. Would you be able to test whether the split
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452800#comment-16452800
]
genericqa commented on HADOOP-15408:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452744#comment-16452744
]
Rushabh S Shah commented on HADOOP-15408:
-
{quote}And because the new jar will meet kms-dt (e.g.
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452594#comment-16452594
]
Xiao Chen commented on HADOOP-15408:
{noformat}
2018-04-20 21:09:53,273 ERROR [main]
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452551#comment-16452551
]
Rushabh S Shah commented on HADOOP-15408:
-
bq. the new jar alone won't be able to decode kms-dt?
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452538#comment-16452538
]
Xiao Chen commented on HADOOP-15408:
bq. Please don't think I am intruding.
not at all. More than
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452519#comment-16452519
]
Rushabh S Shah commented on HADOOP-15408:
-
bq. Thanks for testing. The patch was to express the
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451796#comment-16451796
]
genericqa commented on HADOOP-15408:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451674#comment-16451674
]
Xiao Chen commented on HADOOP-15408:
Hi [~shahrs87], comments below and a request in the end.
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451504#comment-16451504
]
Rushabh S Shah commented on HADOOP-15408:
-
Thanks [~xiaochen] for the patch.
Had an offline chat
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450396#comment-16450396
]
Steve Loughran commented on HADOOP-15408:
-
We've always had a "don't mix hadoop-* jars" policy,
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450342#comment-16450342
]
Xiao Chen commented on HADOOP-15408:
Sorry I have not debugged this, so could be missing something.
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450294#comment-16450294
]
Rushabh S Shah commented on HADOOP-15408:
-
{quote}This fix also broke Ranger, for the same
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450285#comment-16450285
]
Arpit Agarwal commented on HADOOP-15408:
This fix also broke Ranger, for the same reason.
>
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450213#comment-16450213
]
Xiao Chen commented on HADOOP-15408:
ouch, didn't test it but feels like a scenario that we have to
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450184#comment-16450184
]
Rushabh S Shah commented on HADOOP-15408:
-
bq. Is it a valid use case?
I think yes.
If we can
[
https://issues.apache.org/jira/browse/HADOOP-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450159#comment-16450159
]
Wei-Chiu Chuang commented on HADOOP-15408:
--
Hi Rushabh, thanks for filing the jira.
It looks
40 matches
Mail list logo
