[jira] [Commented] (HADOOP-15576) S3A Multipart Uploader to work with S3Guard and encryption

2018-08-08 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573124#comment-16573124 ] Hudson commented on HADOOP-15576: - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14724 (See

[jira] [Commented] (HADOOP-15576) S3A Multipart Uploader to work with S3Guard and encryption

2018-08-08 Thread Ewan Higgs (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573090#comment-16573090 ] Ewan Higgs commented on HADOOP-15576: - Merged. Thanks, [~ste...@apache.org], for your input and

[jira] [Commented] (HADOOP-15576) S3A Multipart Uploader to work with S3Guard and encryption

2018-08-07 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571984#comment-16571984 ] Steve Loughran commented on HADOOP-15576: - I've given it the +1, you now free to apply. Do a

[jira] [Commented] (HADOOP-15576) S3A Multipart Uploader to work with S3Guard and encryption

2018-08-07 Thread Ewan Higgs (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571368#comment-16571368 ] Ewan Higgs commented on HADOOP-15576: - {quote}I think this is good to go in, if you are happy with

[jira] [Commented] (HADOOP-15576) S3A Multipart Uploader to work with S3Guard and encryption

2018-08-06 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570980#comment-16570980 ] Steve Loughran commented on HADOOP-15576: - I think this is good to go in, if you are happy with

[jira] [Commented] (HADOOP-15576) S3A Multipart Uploader to work with S3Guard and encryption

2018-08-06 Thread Ewan Higgs (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570240#comment-16570240 ] Ewan Higgs commented on HADOOP-15576: - {quote}legit regression; the rejection of 0-part MPUs is

[jira] [Commented] (HADOOP-15576) S3A Multipart Uploader to work with S3Guard and encryption

2018-08-03 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569018#comment-16569018 ] genericqa commented on HADOOP-15576: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15576) S3A Multipart Uploader to work with S3Guard and encryption

2018-08-03 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568876#comment-16568876 ] Steve Loughran commented on HADOOP-15576: - Patch 008 * fix staging committer mock tests to

[jira] [Commented] (HADOOP-15576) S3A Multipart Uploader to work with S3Guard and encryption

2018-08-03 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568746#comment-16568746 ] Steve Loughran commented on HADOOP-15576: - legit regression; the rejection of 0-part MPUs is

[jira] [Commented] (HADOOP-15576) S3A Multipart Uploader to work with S3Guard and encryption

2018-08-03 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568095#comment-16568095 ] genericqa commented on HADOOP-15576: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15576) S3A Multipart Uploader to work with S3Guard and encryption

2018-08-03 Thread Ewan Higgs (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567945#comment-16567945 ] Ewan Higgs commented on HADOOP-15576: - Thanks. The changes mostly look very good. {quote}The rule

[jira] [Commented] (HADOOP-15576) S3A Multipart Uploader to work with S3Guard and encryption

2018-08-03 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567845#comment-16567845 ] Steve Loughran commented on HADOOP-15576: - HADOOP-15576 patch 007 * S3A part handles marshall

[jira] [Commented] (HADOOP-15576) S3A Multipart Uploader to work with S3Guard and encryption

2018-08-02 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567086#comment-16567086 ] Steve Loughran commented on HADOOP-15576: - Failing tests all look unrelated; if they involved

[jira] [Commented] (HADOOP-15576) S3A Multipart Uploader to work with S3Guard and encryption

2018-08-02 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566593#comment-16566593 ] genericqa commented on HADOOP-15576: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15576) S3A Multipart Uploader to work with S3Guard and encryption

2018-08-01 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566362#comment-16566362 ] Steve Loughran commented on HADOOP-15576: - Looks like cause is finishedWrite is setting len ==

[jira] [Commented] (HADOOP-15576) S3A Multipart Uploader to work with S3Guard and encryption

2018-08-01 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566041#comment-16566041 ] Steve Loughran commented on HADOOP-15576: - duration: 300s, which, as they are bandwidth heavy,

[jira] [Commented] (HADOOP-15576) S3A Multipart Uploader to work with S3Guard and encryption

2018-08-01 Thread Ewan Higgs (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565100#comment-16565100 ] Ewan Higgs commented on HADOOP-15576: - I wonder if I've misconfigured the test because they

[jira] [Commented] (HADOOP-15576) S3A Multipart Uploader to work with S3Guard and encryption

2018-07-31 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564625#comment-16564625 ] Steve Loughran commented on HADOOP-15576: - Playing with this * tests take a v long time. *

[jira] [Commented] (HADOOP-15576) S3A Multipart Uploader to work with S3Guard and encryption

2018-07-31 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564363#comment-16564363 ] genericqa commented on HADOOP-15576: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15576) S3A Multipart Uploader to work with S3Guard and encryption

2018-07-31 Thread Ewan Higgs (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563967#comment-16563967 ] Ewan Higgs commented on HADOOP-15576: - 004 - Add test for empty uploadID - Make the part size

[jira] [Commented] (HADOOP-15576) S3A Multipart Uploader to work with S3Guard and encryption

2018-07-27 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16560108#comment-16560108 ] genericqa commented on HADOOP-15576: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15576) S3A Multipart Uploader to work with S3Guard and encryption

2018-07-27 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16560038#comment-16560038 ] Steve Loughran commented on HADOOP-15576: - bq. This is interesting and worthwhile to know what

[jira] [Commented] (HADOOP-15576) S3A Multipart Uploader to work with S3Guard and encryption

2018-07-27 Thread Ewan Higgs (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559857#comment-16559857 ] Ewan Higgs commented on HADOOP-15576: - 003 - Added Test - second complete throws IOException -

[jira] [Commented] (HADOOP-15576) S3A Multipart Uploader to work with S3Guard and encryption

2018-07-26 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559015#comment-16559015 ] genericqa commented on HADOOP-15576: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-15576) S3A Multipart Uploader to work with S3Guard and encryption

2018-07-26 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558745#comment-16558745 ] Steve Loughran commented on HADOOP-15576: - Looking good. One recommended change in tests; the

[jira] [Commented] (HADOOP-15576) S3A Multipart Uploader to work with S3Guard and encryption

2018-07-26 Thread Ewan Higgs (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558465#comment-16558465 ] Ewan Higgs commented on HADOOP-15576: - 002 - Move test(s) to fit into the Contract test framework.

[jira] [Commented] (HADOOP-15576) S3A Multipart Uploader to work with S3Guard and encryption

2018-07-25 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16556138#comment-16556138 ] Steve Loughran commented on HADOOP-15576: - you're going to hate me for this, but here's my

[jira] [Commented] (HADOOP-15576) S3A Multipart Uploader to work with S3Guard and encryption

2018-07-25 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16556043#comment-16556043 ] genericqa commented on HADOOP-15576: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||