[jira] [Commented] (HADOOP-16310) Log of a slow RPC request should contain the parameter of the request
[
https://issues.apache.org/jira/browse/HADOOP-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942050#comment-16942050
]
Brahma Reddy Battula commented on HADOOP-16310:
---
Resloving as duplicate of HADOOP-16531
> Log of a slow RPC request should contain the parameter of the request
> -
>
> Key: HADOOP-16310
> URL: https://issues.apache.org/jira/browse/HADOOP-16310
> Project: Hadoop Common
> Issue Type: Improvement
> Components: rpc-server
>Affects Versions: 3.1.1, 2.7.7, 3.1.2
>Reporter: lindongdong
>Priority: Minor
>
> Now, the log of a slow RPC request just contains the
> *methodName*,*processingTime* and *client*. Code is here:
> {code:java}
> if ((rpcMetrics.getProcessingSampleCount() > minSampleSize) &&
> (processingTime > threeSigma)) {
> if(LOG.isWarnEnabled()) {
> String client = CurCall.get().toString();
> LOG.warn(
> "Slow RPC : " + methodName + " took " + processingTime +
> " milliseconds to process from client " + client);
> }
> rpcMetrics.incrSlowRpc();
> }{code}
>
> It is not enough to analyze why the RPC request is slow.
> The parameter of the request is a very important thing, and need to be logged.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16310) Log of a slow RPC request should contain the parameter of the request
[
https://issues.apache.org/jira/browse/HADOOP-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915805#comment-16915805
]
Zhankun Tang commented on HADOOP-16310:
---
Bulk update: Preparing for 3.1.3 release. moved all 3.1.2 non-blocker issues to
3.1.4, please move back if it is a blocker for you.
> Log of a slow RPC request should contain the parameter of the request
> -
>
> Key: HADOOP-16310
> URL: https://issues.apache.org/jira/browse/HADOOP-16310
> Project: Hadoop Common
> Issue Type: Improvement
> Components: rpc-server
>Affects Versions: 3.1.1, 2.7.7, 3.1.2
>Reporter: lindongdong
>Priority: Minor
>
> Now, the log of a slow RPC request just contains the
> *methodName*,*processingTime* and *client*. Code is here:
> {code:java}
> if ((rpcMetrics.getProcessingSampleCount() > minSampleSize) &&
> (processingTime > threeSigma)) {
> if(LOG.isWarnEnabled()) {
> String client = CurCall.get().toString();
> LOG.warn(
> "Slow RPC : " + methodName + " took " + processingTime +
> " milliseconds to process from client " + client);
> }
> rpcMetrics.incrSlowRpc();
> }{code}
>
> It is not enough to analyze why the RPC request is slow.
> The parameter of the request is a very important thing, and need to be logged.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
