[jira] [Commented] (HADOOP-16615) Add password check for credential provider

2019-10-24 Thread Hudson (Jira) 


[ 
https://issues.apache.org/jira/browse/HADOOP-16615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16959116#comment-16959116
 ] 

Hudson commented on HADOOP-16615:
-

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17569 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/17569/])
HADOOP-16615. Add password check for credential provider, (stevel: rev 
2eba2624723e2258bddef72d05a1e90576082315)
* (edit) 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/alias/CredentialShell.java
* (edit) hadoop-common-project/hadoop-common/src/site/markdown/CommandsManual.md
* (edit) 
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/alias/TestCredShell.java


> Add password check for credential provider
> --
>
> Key: HADOOP-16615
> URL: https://issues.apache.org/jira/browse/HADOOP-16615
> Project: Hadoop Common
>  Issue Type: Improvement
>Affects Versions: 3.1.3
>Reporter: hong dongdong
>Assignee: hong dongdong
>Priority: Major
> Fix For: 3.3.0
>
> Attachments: HADOOP-16615.patch
>
>
> When we use hadoop credential provider to store password, we can not sure if 
> the password is the same as what we remembered.
> So, I think we need a check tool.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-16615) Add password check for credential provider

2019-10-08 Thread hong dongdong (Jira) 


[ 
https://issues.apache.org/jira/browse/HADOOP-16615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16947316#comment-16947316
 ] 

hong dongdong commented on HADOOP-16615:


[~ste...@apache.org] pls review PR 
[https://github.com/apache/hadoop/pull/1614], and the test fails seems 
unrelated to this patch.

> Add password check for credential provider
> --
>
> Key: HADOOP-16615
> URL: https://issues.apache.org/jira/browse/HADOOP-16615
> Project: Hadoop Common
>  Issue Type: Improvement
>Reporter: hong dongdong
>Priority: Major
> Attachments: HADOOP-16615.patch
>
>
> When we use hadoop credential provider to store password, we can not sure if 
> the password is the same as what we remembered.
> So, I think we need a check tool.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-16615) Add password check for credential provider

2019-10-08 Thread Steve Loughran (Jira) 


[ 
https://issues.apache.org/jira/browse/HADOOP-16615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946968#comment-16946968
 ] 

Steve Loughran commented on HADOOP-16615:
-

looks good; there's some minor changes in the test code I'd like. 

Could you submit this as a github PR?

> Add password check for credential provider
> --
>
> Key: HADOOP-16615
> URL: https://issues.apache.org/jira/browse/HADOOP-16615
> Project: Hadoop Common
>  Issue Type: Improvement
>Reporter: hong dongdong
>Priority: Major
> Attachments: HADOOP-16615.patch
>
>
> When we use hadoop credential provider to store password, we can not sure if 
> the password is the same as what we remembered.
> So, I think we need a check tool.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-16615) Add password check for credential provider

2019-10-08 Thread Hadoop QA (Jira) 


[ 
https://issues.apache.org/jira/browse/HADOOP-16615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946680#comment-16946680
 ] 

Hadoop QA commented on HADOOP-16615:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 20m 
19s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 22m 
14s{color} | {color:green} trunk passed {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  3m 
22s{color} | {color:red} root in trunk failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
39s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m 
18s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
14m 13s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
36s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
21s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
55s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  3m 
19s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  3m 19s{color} 
| {color:red} root in the patch failed. {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
0m 36s{color} | {color:orange} hadoop-common-project/hadoop-common: The patch 
generated 11 new + 23 unchanged - 0 fixed = 34 total (was 23) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m  
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
13m 29s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
15s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  9m 
34s{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
31s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 97m  1s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.2 Server=19.03.2 Image:yetus/hadoop:1dde3efb91e |
| JIRA Issue | HADOOP-16615 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12982474/HADOOP-16615.patch |
| Optional Tests |  dupname  asflicense  compile  javac  javadoc  mvninstall  
mvnsite  unit  shadedclient  findbugs  checkstyle  |
| uname | Linux f46a84f1fa83 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 91320b4 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_222 |
| compile | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/16578/artifact/out/branch-compile-root.txt
 |
| findbugs | v3.1.0-RC1 |
| compile | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/16578/artifact/out/patch-compile-root.txt
 |
| javac | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/16578/artifact/out/patch-compile-root.txt
 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/16578/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt
 |
|  Test Resul

[jira] [Commented] (HADOOP-16615) Add password check for credential provider

2019-10-08 Thread hong dongdong (Jira) 


[ 
https://issues.apache.org/jira/browse/HADOOP-16615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946608#comment-16946608
 ] 

hong dongdong commented on HADOOP-16615:


[~ste...@apache.org], PR have bean submitted, test and documentation added too.

> Add password check for credential provider
> --
>
> Key: HADOOP-16615
> URL: https://issues.apache.org/jira/browse/HADOOP-16615
> Project: Hadoop Common
>  Issue Type: Improvement
>Reporter: hong dongdong
>Priority: Major
> Attachments: HADOOP-16615.patch
>
>
> When we use hadoop credential provider to store password, we can not sure if 
> the password is the same as what we remembered.
> So, I think we need a check tool.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-16615) Add password check for credential provider

2019-09-30 Thread Steve Loughran (Jira) 


[ 
https://issues.apache.org/jira/browse/HADOOP-16615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16941003#comment-16941003
 ] 

Steve Loughran commented on HADOOP-16615:
-

makes sense. 

* can you submit it as a github PR for ease of reviewing
* it'll need tests and documentation

> Add password check for credential provider
> --
>
> Key: HADOOP-16615
> URL: https://issues.apache.org/jira/browse/HADOOP-16615
> Project: Hadoop Common
>  Issue Type: Improvement
>Reporter: hong dongdong
>Priority: Major
> Attachments: HADOOP-16615.patch
>
>
> When we use hadoop credential provider to store password, we can not sure if 
> the password is the same as what we remembered.
> So, I think we need a check tool.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-16615) Add password check for credential provider

2019-09-29 Thread Hadoop QA (Jira) 


[ 
https://issues.apache.org/jira/browse/HADOOP-16615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16940532#comment-16940532
 ] 

Hadoop QA commented on HADOOP-16615:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  1m  
6s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 26m 
15s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 25m 
19s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
10s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  2m  
0s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
19m 46s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
41s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m  
0s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 26m 
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 26m 
37s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
1m 10s{color} | {color:orange} hadoop-common-project/hadoop-common: The patch 
generated 9 new + 4 unchanged - 0 fixed = 13 total (was 4) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m 
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
15m 51s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
52s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 10m 
48s{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
52s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}143m  3s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.0 Server=19.03.0 Image:yetus/hadoop:efed4450bf1 |
| JIRA Issue | HADOOP-16615 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12981716/HADOOP-16615.patch |
| Optional Tests |  dupname  asflicense  compile  javac  javadoc  mvninstall  
mvnsite  unit  shadedclient  findbugs  checkstyle  |
| uname | Linux 4597366ebb08 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / c0edc84 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_222 |
| findbugs | v3.1.0-RC1 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/16559/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/16559/testReport/ |
| Max. process+thread count | 1780 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common U: 
hadoop-common-proj