[jira] [Commented] (HADOOP-16649) Defining hadoop-azure and hadoop-azure-datalake in HADOOP_OPTIONAL_TOOLS will ignore hadoop-azure

2020-10-14 Thread thierry accart (Jira)


[ 
https://issues.apache.org/jira/browse/HADOOP-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213929#comment-17213929
 ] 

thierry accart commented on HADOOP-16649:
-

Hi

for information: I tried to enrich the {{hadoop_add_param.bats}} with a 
dedicated test

{{@test "hadoop_add_param (positive 2)" {}}
{{  hadoop_add_param testvar hadoop-azure hadoop-azure }}
{{  hadoop_add_param testvar hadoop-azure-datalake }}{{hadoop-azure-datalake 
}}{{}}
{{  echo ">${testvar}<"}}
{{  }}{{[ "}}{{${testvar}" = "hadoop-azure-datalake hadoop-azure" ]}}
{{}}}

-->  execution of {{run-bats.sh 
(}}{{hadoop-common-project/hadoop-common/src/test/scripts/run-bats.s}}h)  does 
*_not_* fail :-/

 

But, good news, changing internal order

{{  hadoop_add_param testvar hadoop-azure hadoop-azure }}
{{  hadoop_add_param testvar hadoop-azure-datalake }}{{hadoop-azure-datalake 
}}{{}}
{{}}

fails as expected :)

> Defining hadoop-azure and hadoop-azure-datalake in HADOOP_OPTIONAL_TOOLS will 
> ignore hadoop-azure
> -
>
> Key: HADOOP-16649
> URL: https://issues.apache.org/jira/browse/HADOOP-16649
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: bin
>Affects Versions: 3.2.1
> Environment: Shell, but it also trickles down into all code using 
> `FileSystem` 
>Reporter: Tom Lous
>Priority: Minor
>
> When defining both `hadoop-azure` and `hadoop-azure-datalake` in 
> HADOOP_OPTIONAL_TOOLS in `conf/hadoop-env.sh`, `hadoop-azure` will get 
> ignored.
> eg setting this:
> HADOOP_OPTIONAL_TOOLS="hadoop-azure-datalake,hadoop-azure"
>  
>  with debug on:
>  
> DEBUG: Profiles: importing 
> /opt/hadoop/libexec/shellprofile.d/hadoop-azure-datalake.sh
> DEBUG: HADOOP_SHELL_PROFILES accepted hadoop-azure-datalake
> DEBUG: Profiles: importing /opt/hadoop/libexec/shellprofile.d/hadoop-azure.sh
> DEBUG: HADOOP_SHELL_PROFILES 
> DEBUG: HADOOP_SHELL_PROFILES declined hadoop-azure hadoop-azure
>  
> whereas:
>  
> HADOOP_OPTIONAL_TOOLS="hadoop-azure"
>  
>  with debug on:
> DEBUG: Profiles: importing /opt/hadoop/libexec/shellprofile.d/hadoop-azure.sh
> DEBUG: HADOOP_SHELL_PROFILES accepted hadoop-azure
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-16649) Defining hadoop-azure and hadoop-azure-datalake in HADOOP_OPTIONAL_TOOLS will ignore hadoop-azure

2019-10-10 Thread Steve Loughran (Jira)


[ 
https://issues.apache.org/jira/browse/HADOOP-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948747#comment-16948747
 ] 

Steve Loughran commented on HADOOP-16649:
-

yes -the hard part is coming up with a test; look in 
hadoop-common-project/hadoop-common/src/test/scripts for what there is already

> Defining hadoop-azure and hadoop-azure-datalake in HADOOP_OPTIONAL_TOOLS will 
> ignore hadoop-azure
> -
>
> Key: HADOOP-16649
> URL: https://issues.apache.org/jira/browse/HADOOP-16649
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: bin
>Affects Versions: 3.2.1
> Environment: Shell, but it also trickles down into all code using 
> `FileSystem` 
>Reporter: Tom Lous
>Priority: Minor
>
> When defining both `hadoop-azure` and `hadoop-azure-datalake` in 
> HADOOP_OPTIONAL_TOOLS in `conf/hadoop-env.sh`, `hadoop-azure` will get 
> ignored.
> eg setting this:
> HADOOP_OPTIONAL_TOOLS="hadoop-azure-datalake,hadoop-azure"
>  
>  with debug on:
>  
> DEBUG: Profiles: importing 
> /opt/hadoop/libexec/shellprofile.d/hadoop-azure-datalake.sh
> DEBUG: HADOOP_SHELL_PROFILES accepted hadoop-azure-datalake
> DEBUG: Profiles: importing /opt/hadoop/libexec/shellprofile.d/hadoop-azure.sh
> DEBUG: HADOOP_SHELL_PROFILES 
> DEBUG: HADOOP_SHELL_PROFILES declined hadoop-azure hadoop-azure
>  
> whereas:
>  
> HADOOP_OPTIONAL_TOOLS="hadoop-azure"
>  
>  with debug on:
> DEBUG: Profiles: importing /opt/hadoop/libexec/shellprofile.d/hadoop-azure.sh
> DEBUG: HADOOP_SHELL_PROFILES accepted hadoop-azure
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-16649) Defining hadoop-azure and hadoop-azure-datalake in HADOOP_OPTIONAL_TOOLS will ignore hadoop-azure

2019-10-10 Thread Tom Lous (Jira)


[ 
https://issues.apache.org/jira/browse/HADOOP-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948418#comment-16948418
 ] 

Tom Lous commented on HADOOP-16649:
---

I don't mind having a look at it, but is it as simple as fixing the issue on a 
for &, creating a PR referencing this ticket?

> Defining hadoop-azure and hadoop-azure-datalake in HADOOP_OPTIONAL_TOOLS will 
> ignore hadoop-azure
> -
>
> Key: HADOOP-16649
> URL: https://issues.apache.org/jira/browse/HADOOP-16649
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: bin
>Affects Versions: 3.2.1
> Environment: Shell, but it also trickles down into all code using 
> `FileSystem` 
>Reporter: Tom Lous
>Priority: Minor
>
> When defining both `hadoop-azure` and `hadoop-azure-datalake` in 
> HADOOP_OPTIONAL_TOOLS in `conf/hadoop-env.sh`, `hadoop-azure` will get 
> ignored.
> eg setting this:
> HADOOP_OPTIONAL_TOOLS="hadoop-azure-datalake,hadoop-azure"
>  
>  with debug on:
>  
> DEBUG: Profiles: importing 
> /opt/hadoop/libexec/shellprofile.d/hadoop-azure-datalake.sh
> DEBUG: HADOOP_SHELL_PROFILES accepted hadoop-azure-datalake
> DEBUG: Profiles: importing /opt/hadoop/libexec/shellprofile.d/hadoop-azure.sh
> DEBUG: HADOOP_SHELL_PROFILES 
> DEBUG: HADOOP_SHELL_PROFILES declined hadoop-azure hadoop-azure
>  
> whereas:
>  
> HADOOP_OPTIONAL_TOOLS="hadoop-azure"
>  
>  with debug on:
> DEBUG: Profiles: importing /opt/hadoop/libexec/shellprofile.d/hadoop-azure.sh
> DEBUG: HADOOP_SHELL_PROFILES accepted hadoop-azure
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Commented] (HADOOP-16649) Defining hadoop-azure and hadoop-azure-datalake in HADOOP_OPTIONAL_TOOLS will ignore hadoop-azure

2019-10-10 Thread Steve Loughran (Jira)


[ 
https://issues.apache.org/jira/browse/HADOOP-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948390#comment-16948390
 ] 

Steve Loughran commented on HADOOP-16649:
-

looks like a bug in {{hadoop_add_param}}; its looking for a specific string, 
and rejecting things.

Someone who understands those scripts is going to have to help here

> Defining hadoop-azure and hadoop-azure-datalake in HADOOP_OPTIONAL_TOOLS will 
> ignore hadoop-azure
> -
>
> Key: HADOOP-16649
> URL: https://issues.apache.org/jira/browse/HADOOP-16649
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: bin
>Affects Versions: 3.2.1
> Environment: Shell, but it also trickles down into all code using 
> `FileSystem` 
>Reporter: Tom Lous
>Priority: Minor
>
> When defining both `hadoop-azure` and `hadoop-azure-datalake` in 
> HADOOP_OPTIONAL_TOOLS in `conf/hadoop-env.sh`, `hadoop-azure` will get 
> ignored.
> eg setting this:
> HADOOP_OPTIONAL_TOOLS="hadoop-azure-datalake,hadoop-azure"
>  
>  with debug on:
>  
> DEBUG: Profiles: importing 
> /opt/hadoop/libexec/shellprofile.d/hadoop-azure-datalake.sh
> DEBUG: HADOOP_SHELL_PROFILES accepted hadoop-azure-datalake
> DEBUG: Profiles: importing /opt/hadoop/libexec/shellprofile.d/hadoop-azure.sh
> DEBUG: HADOOP_SHELL_PROFILES 
> DEBUG: HADOOP_SHELL_PROFILES declined hadoop-azure hadoop-azure
>  
> whereas:
>  
> HADOOP_OPTIONAL_TOOLS="hadoop-azure"
>  
>  with debug on:
> DEBUG: Profiles: importing /opt/hadoop/libexec/shellprofile.d/hadoop-azure.sh
> DEBUG: HADOOP_SHELL_PROFILES accepted hadoop-azure
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org