[
https://issues.apache.org/jira/browse/HADOOP-16958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081766#comment-17081766
]
Ayush Saxena commented on HADOOP-16958:
---
v004 LGTM +1
> NullPointerException(NPE) when
[
https://issues.apache.org/jira/browse/HADOOP-16958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081706#comment-17081706
]
Hadoop QA commented on HADOOP-16958:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-16958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081679#comment-17081679
]
Ctest commented on HADOOP-16958:
Sorry for not removing the unused Bool import which caused the javac
[
https://issues.apache.org/jira/browse/HADOOP-16958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081658#comment-17081658
]
Ayush Saxena commented on HADOOP-16958:
---
Jenkins seems to have complains. Can you give a check to
[
https://issues.apache.org/jira/browse/HADOOP-16958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081558#comment-17081558
]
Hadoop QA commented on HADOOP-16958:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-16958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081533#comment-17081533
]
Ctest commented on HADOOP-16958:
Thanks! I just submitted the 003.patch.
> NullPointerException(NPE)
[
https://issues.apache.org/jira/browse/HADOOP-16958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081377#comment-17081377
]
Ayush Saxena commented on HADOOP-16958:
---
You can move it back at the end, as it was.
[
https://issues.apache.org/jira/browse/HADOOP-16958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081370#comment-17081370
]
Ctest commented on HADOOP-16958:
The tests failed because I moved the check policy==null to the start
[
https://issues.apache.org/jira/browse/HADOOP-16958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081346#comment-17081346
]
Ayush Saxena commented on HADOOP-16958:
---
The test failures seems to be related, Please check
[
https://issues.apache.org/jira/browse/HADOOP-16958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081102#comment-17081102
]
Hadoop QA commented on HADOOP-16958:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-16958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079289#comment-17079289
]
Ayush Saxena commented on HADOOP-16958:
---
Thanx [~ctest.team] for the report and fix. Had a quick
[
https://issues.apache.org/jira/browse/HADOOP-16958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077941#comment-17077941
]
Hadoop QA commented on HADOOP-16958:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-16958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077820#comment-17077820
]
Ctest commented on HADOOP-16958:
Add HADOOP-16958.001.patch to fix as many *checkstyle* problems as
[
https://issues.apache.org/jira/browse/HADOOP-16958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077804#comment-17077804
]
Hadoop QA commented on HADOOP-16958:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-16958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077667#comment-17077667
]
Ctest commented on HADOOP-16958:
[~ayushtkn] Thx for the quick reply, I submitted a patch with a UT.
>
[
https://issues.apache.org/jira/browse/HADOOP-16958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076171#comment-17076171
]
Ayush Saxena commented on HADOOP-16958:
---
Thanx for the report, go ahead. Do attach a UT to repro
16 matches
Mail list logo