[jira] [Updated] (HADOOP-15962) FileUtils Small Buffer Size
[
https://issues.apache.org/jira/browse/HADOOP-15962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
BELUGA BEHR updated HADOOP-15962:
-
Attachment: HADOOP-15962.2.patch
> FileUtils Small Buffer Size
> ---
>
> Key: HADOOP-15962
> URL: https://issues.apache.org/jira/browse/HADOOP-15962
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common
>Affects Versions: 3.3.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Minor
> Attachments: HADOOP-15962.1.patch, HADOOP-15962.2.patch
>
>
> Note sure if this code is even being used, but it implements a copy routing
> utilizing a 2K buffer. Modern JVM uses 8K, but 4K should be minimum. Also,
> there are libraries for this stuff.
> {code:java|title=FileUtil.java}
> int count;
> byte data[] = new byte[2048];
> try (BufferedOutputStream outputStream = new BufferedOutputStream(
> new FileOutputStream(outputFile));) {
> while ((count = tis.read(data)) != -1) {
> outputStream.write(data, 0, count);
> }
> outputStream.flush();
> }
> {code}
> I also fixed a couple of check-style warnings.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-15962) FileUtils Small Buffer Size
[
https://issues.apache.org/jira/browse/HADOOP-15962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
BELUGA BEHR updated HADOOP-15962:
-
Status: Open (was: Patch Available)
> FileUtils Small Buffer Size
> ---
>
> Key: HADOOP-15962
> URL: https://issues.apache.org/jira/browse/HADOOP-15962
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common
>Affects Versions: 3.3.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Minor
> Attachments: HADOOP-15962.1.patch, HADOOP-15962.2.patch
>
>
> Note sure if this code is even being used, but it implements a copy routing
> utilizing a 2K buffer. Modern JVM uses 8K, but 4K should be minimum. Also,
> there are libraries for this stuff.
> {code:java|title=FileUtil.java}
> int count;
> byte data[] = new byte[2048];
> try (BufferedOutputStream outputStream = new BufferedOutputStream(
> new FileOutputStream(outputFile));) {
> while ((count = tis.read(data)) != -1) {
> outputStream.write(data, 0, count);
> }
> outputStream.flush();
> }
> {code}
> I also fixed a couple of check-style warnings.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-15962) FileUtils Small Buffer Size
[
https://issues.apache.org/jira/browse/HADOOP-15962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
BELUGA BEHR updated HADOOP-15962:
-
Status: Patch Available (was: Open)
[~ste...@apache.org] Thanks for the review!
I have removed some changes for easier merging.
> FileUtils Small Buffer Size
> ---
>
> Key: HADOOP-15962
> URL: https://issues.apache.org/jira/browse/HADOOP-15962
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common
>Affects Versions: 3.3.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Minor
> Attachments: HADOOP-15962.1.patch, HADOOP-15962.2.patch
>
>
> Note sure if this code is even being used, but it implements a copy routing
> utilizing a 2K buffer. Modern JVM uses 8K, but 4K should be minimum. Also,
> there are libraries for this stuff.
> {code:java|title=FileUtil.java}
> int count;
> byte data[] = new byte[2048];
> try (BufferedOutputStream outputStream = new BufferedOutputStream(
> new FileOutputStream(outputFile));) {
> while ((count = tis.read(data)) != -1) {
> outputStream.write(data, 0, count);
> }
> outputStream.flush();
> }
> {code}
> I also fixed a couple of check-style warnings.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-15962) FileUtils Small Buffer Size
[
https://issues.apache.org/jira/browse/HADOOP-15962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
BELUGA BEHR updated HADOOP-15962:
-
Status: Patch Available (was: Open)
> FileUtils Small Buffer Size
> ---
>
> Key: HADOOP-15962
> URL: https://issues.apache.org/jira/browse/HADOOP-15962
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common
>Affects Versions: 3.3.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Minor
> Attachments: HADOOP-15962.1.patch
>
>
> Note sure if this code is even being used, but it implements a copy routing
> utilizing a 2K buffer. Modern JVM uses 8K, but 4K should be minimum. Also,
> there are libraries for this stuff.
> {code:java|title=FileUtil.java}
> int count;
> byte data[] = new byte[2048];
> try (BufferedOutputStream outputStream = new BufferedOutputStream(
> new FileOutputStream(outputFile));) {
> while ((count = tis.read(data)) != -1) {
> outputStream.write(data, 0, count);
> }
> outputStream.flush();
> }
> {code}
> I also fixed a couple of check-style warnings.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-15962) FileUtils Small Buffer Size
[
https://issues.apache.org/jira/browse/HADOOP-15962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
BELUGA BEHR updated HADOOP-15962:
-
Attachment: HADOOP-15962.1.patch
> FileUtils Small Buffer Size
> ---
>
> Key: HADOOP-15962
> URL: https://issues.apache.org/jira/browse/HADOOP-15962
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common
>Affects Versions: 3.3.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Minor
> Attachments: HADOOP-15962.1.patch
>
>
> Note sure if this code is even being used, but it implements a copy routing
> utilizing a 2K buffer. Modern JVM uses 8K, but 4K should be minimum. Also,
> there are libraries for this stuff.
> {code:java|title=FileUtil.java}
> int count;
> byte data[] = new byte[2048];
> try (BufferedOutputStream outputStream = new BufferedOutputStream(
> new FileOutputStream(outputFile));) {
> while ((count = tis.read(data)) != -1) {
> outputStream.write(data, 0, count);
> }
> outputStream.flush();
> }
> {code}
> I also fixed a couple of check-style warnings.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
