[GitHub] [hadoop] hadoop-yetus commented on issue #1803: HADOOP-16621. [pb-upgrade] Remove Protobuf classes from signatures of Public APIs.
hadoop-yetus commented on issue #1803: HADOOP-16621. [pb-upgrade] Remove Protobuf classes from signatures of Public APIs. URL: https://github.com/apache/hadoop/pull/1803#issuecomment-574308327 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 166m 53s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ trunk Compile Tests _ | | +0 :ok: | mvndep | 2m 42s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 46m 6s | trunk passed | | +1 :green_heart: | compile | 42m 4s | trunk passed | | +1 :green_heart: | checkstyle | 3m 52s | trunk passed | | +1 :green_heart: | mvnsite | 3m 11s | trunk passed | | +1 :green_heart: | shadedclient | 27m 37s | branch has no errors when building and testing our client artifacts. | | +1 :green_heart: | javadoc | 3m 24s | trunk passed | | +0 :ok: | spotbugs | 2m 54s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 5m 46s | trunk passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 3s | the patch passed | | +1 :green_heart: | compile | 29m 28s | the patch passed | | +1 :green_heart: | javac | 29m 27s | the patch passed | | +1 :green_heart: | checkstyle | 4m 14s | the patch passed | | +1 :green_heart: | mvnsite | 2m 46s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. | | +1 :green_heart: | shadedclient | 19m 33s | patch has no errors when building and testing our client artifacts. | | +1 :green_heart: | javadoc | 3m 27s | the patch passed | | +1 :green_heart: | findbugs | 6m 36s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 18m 36s | hadoop-common in the patch failed. | | +1 :green_heart: | unit | 3m 17s | hadoop-hdfs-client in the patch passed. | | +1 :green_heart: | asflicense | 1m 9s | The patch does not generate ASF License warnings. | | | | 393m 23s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.metrics2.lib.TestMutableRollingAverages | | | hadoop.metrics2.lib.TestMutableMetrics | | | hadoop.io.nativeio.TestNativeIO | | | hadoop.ha.TestZKFailoverController | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1803/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1803 | | Optional Tests | dupname asflicense xml compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 2606c56d7b0f 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 1c51f36 | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1803/4/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1803/4/testReport/ | | Max. process+thread count | 1650 (vs. ulimit of 5500) | | modules | C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client U: . | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1803/4/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on issue #1803: HADOOP-16621. [pb-upgrade] Remove Protobuf classes from signatures of Public APIs.
hadoop-yetus commented on issue #1803: HADOOP-16621. [pb-upgrade] Remove Protobuf classes from signatures of Public APIs. URL: https://github.com/apache/hadoop/pull/1803#issuecomment-573713244 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 6s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 1s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ trunk Compile Tests _ | | +0 :ok: | mvndep | 1m 33s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 24m 9s | trunk passed | | +1 :green_heart: | compile | 22m 29s | trunk passed | | +1 :green_heart: | checkstyle | 3m 14s | trunk passed | | +1 :green_heart: | mvnsite | 2m 44s | trunk passed | | +1 :green_heart: | shadedclient | 21m 57s | branch has no errors when building and testing our client artifacts. | | +1 :green_heart: | javadoc | 2m 8s | trunk passed | | +0 :ok: | spotbugs | 2m 26s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 4m 30s | trunk passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 1m 34s | the patch passed | | +1 :green_heart: | compile | 16m 51s | the patch passed | | +1 :green_heart: | javac | 16m 51s | the patch passed | | -0 :warning: | checkstyle | 2m 47s | root: The patch generated 1 new + 49 unchanged - 0 fixed = 50 total (was 49) | | +1 :green_heart: | mvnsite | 2m 18s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +1 :green_heart: | shadedclient | 13m 55s | patch has no errors when building and testing our client artifacts. | | +1 :green_heart: | javadoc | 2m 3s | the patch passed | | +1 :green_heart: | findbugs | 4m 47s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 9m 26s | hadoop-common in the patch passed. | | +1 :green_heart: | unit | 2m 6s | hadoop-hdfs-client in the patch passed. | | +1 :green_heart: | asflicense | 0m 45s | The patch does not generate ASF License warnings. | | | | 140m 40s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1803/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1803 | | Optional Tests | dupname asflicense xml compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux bf1d36b4a053 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 52b360a | | Default Java | 1.8.0_232 | | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1803/3/artifact/out/diff-checkstyle-root.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1803/3/testReport/ | | Max. process+thread count | 1347 (vs. ulimit of 5500) | | modules | C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client U: . | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1803/3/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on issue #1803: HADOOP-16621. [pb-upgrade] Remove Protobuf classes from signatures of Public APIs.
hadoop-yetus commented on issue #1803: HADOOP-16621. [pb-upgrade] Remove Protobuf classes from signatures of Public APIs. URL: https://github.com/apache/hadoop/pull/1803#issuecomment-573637260 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 23s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 1s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ trunk Compile Tests _ | | +0 :ok: | mvndep | 1m 9s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 21m 55s | trunk passed | | +1 :green_heart: | compile | 19m 11s | trunk passed | | +1 :green_heart: | checkstyle | 2m 48s | trunk passed | | +1 :green_heart: | mvnsite | 2m 17s | trunk passed | | +1 :green_heart: | shadedclient | 19m 47s | branch has no errors when building and testing our client artifacts. | | +1 :green_heart: | javadoc | 2m 8s | trunk passed | | +0 :ok: | spotbugs | 2m 43s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 5m 11s | trunk passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 28s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 1m 47s | the patch passed | | +1 :green_heart: | compile | 19m 31s | the patch passed | | +1 :green_heart: | javac | 19m 31s | the patch passed | | -0 :warning: | checkstyle | 2m 52s | root: The patch generated 1 new + 49 unchanged - 0 fixed = 50 total (was 49) | | +1 :green_heart: | mvnsite | 2m 37s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. | | +1 :green_heart: | shadedclient | 13m 46s | patch has no errors when building and testing our client artifacts. | | +1 :green_heart: | javadoc | 2m 6s | the patch passed | | +1 :green_heart: | findbugs | 4m 58s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 10m 44s | hadoop-common in the patch passed. | | +1 :green_heart: | unit | 2m 12s | hadoop-hdfs-client in the patch passed. | | +1 :green_heart: | asflicense | 0m 46s | The patch does not generate ASF License warnings. | | | | 137m 17s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1803/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1803 | | Optional Tests | dupname asflicense xml compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 60162d94a380 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 52b360a | | Default Java | 1.8.0_232 | | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1803/2/artifact/out/diff-checkstyle-root.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1803/2/testReport/ | | Max. process+thread count | 1377 (vs. ulimit of 5500) | | modules | C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client U: . | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1803/2/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on issue #1803: HADOOP-16621. [pb-upgrade] Remove Protobuf classes from signatures of Public APIs.
hadoop-yetus commented on issue #1803: HADOOP-16621. [pb-upgrade] Remove Protobuf classes from signatures of Public APIs. URL: https://github.com/apache/hadoop/pull/1803#issuecomment-573574668 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 25m 11s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ trunk Compile Tests _ | | +0 :ok: | mvndep | 1m 10s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 18m 6s | trunk passed | | +1 :green_heart: | compile | 16m 37s | trunk passed | | +1 :green_heart: | checkstyle | 2m 37s | trunk passed | | +1 :green_heart: | mvnsite | 2m 26s | trunk passed | | +1 :green_heart: | shadedclient | 19m 6s | branch has no errors when building and testing our client artifacts. | | +1 :green_heart: | javadoc | 2m 19s | trunk passed | | +0 :ok: | spotbugs | 2m 24s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 4m 23s | trunk passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 25s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 1m 31s | the patch passed | | +1 :green_heart: | compile | 15m 53s | the patch passed | | +1 :green_heart: | javac | 15m 53s | the patch passed | | -0 :warning: | checkstyle | 2m 33s | root: The patch generated 1 new + 49 unchanged - 0 fixed = 50 total (was 49) | | +1 :green_heart: | mvnsite | 2m 27s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedclient | 12m 45s | patch has no errors when building and testing our client artifacts. | | +1 :green_heart: | javadoc | 2m 18s | the patch passed | | -1 :x: | findbugs | 2m 18s | hadoop-common-project/hadoop-common generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) | | -1 :x: | findbugs | 2m 33s | hadoop-hdfs-project/hadoop-hdfs-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 9m 6s | hadoop-common in the patch passed. | | +1 :green_heart: | unit | 2m 18s | hadoop-hdfs-client in the patch passed. | | +1 :green_heart: | asflicense | 0m 52s | The patch does not generate ASF License warnings. | | | | 147m 3s | | | Reason | Tests | |---:|:--| | FindBugs | module:hadoop-common-project/hadoop-common | | | Sequence of calls to java.util.concurrent.ConcurrentHashMap may not be atomic in org.apache.hadoop.ipc.ProtobufHelper.getFixedByteString(String) At ProtobufHelper.java:may not be atomic in org.apache.hadoop.ipc.ProtobufHelper.getFixedByteString(String) At ProtobufHelper.java:[line 91] | | | Sequence of calls to java.util.concurrent.ConcurrentHashMap may not be atomic in org.apache.hadoop.ipc.ProtobufHelper.getFixedByteString(Text) At ProtobufHelper.java:may not be atomic in org.apache.hadoop.ipc.ProtobufHelper.getFixedByteString(Text) At ProtobufHelper.java:[line 77] | | FindBugs | module:hadoop-hdfs-project/hadoop-hdfs-client | | | Private method org.apache.hadoop.hdfs.protocolPB.PBHelperClient.getFixedByteString(Text) is never called At PBHelperClient.java:called At PBHelperClient.java:[line 236] | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1803/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1803 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux cc80fed1cb0c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 52b360a | | Default Java | 1.8.0_232 | | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1803/1/artifact/out/diff-checkstyle-root.txt | | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1803/1/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html | | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1803/1/artifact/out/new-findbu
