[GitHub] [hadoop] umamaheswararao commented on pull request #2057: HDFS-15389. DFSAdmin should close filesystem and dfsadmin -setBalancerBandwidth should work with ViewFSOverloadScheme.
umamaheswararao commented on pull request #2057: URL: https://github.com/apache/hadoop/pull/2057#issuecomment-639951401 Most of these tests failed with the OOM errors. Could you please confirm the failed tests are running fine? Thank you This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] umamaheswararao commented on pull request #2057: HDFS-15389. DFSAdmin should close filesystem and dfsadmin -setBalancerBandwidth should work with ViewFSOverloadScheme.
umamaheswararao commented on pull request #2057: URL: https://github.com/apache/hadoop/pull/2057#issuecomment-639776462 @ayushtkn, you are right. -setBalancerBancdwidthNeed need not be a separate sub heading. You can just add note in dfsadmin itself. Later I will add remaining commands(cacehadmin..etc) doc update. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] umamaheswararao commented on pull request #2057: HDFS-15389. DFSAdmin should close filesystem and dfsadmin -setBalancerBandwidth should work with ViewFSOverloadScheme.
umamaheswararao commented on pull request #2057: URL: https://github.com/apache/hadoop/pull/2057#issuecomment-639708773 Thanks @ayushtkn for reporting it. LGTM. However I have one point, can we add a note about balancer bandwidth command with overloadScheme when they need to pass -fs? I think we have other commands to cover as well https://issues.apache.org/jira/browse/HDFS-15329. How about we will just add a note down to the section of "dfsadmin with ViewFsOverloadScheme" Something like this "Note: -setbanalcerbandwidth, (later with HDFS-15329: cacheadmin,ECadmin etc) would work in similar way, that user needs to pass -fs option to run on child filesystems" Or we can keep a heading "HDFS commands with ViewFSOverloadScheme" then sub heading should be: dfsadmin, -setbalancerbandwidth etc? I am ok either way. As we already updated guide, do you mind covering in doc? Code changes looks fine to me. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
