[jira] [Comment Edited] (HADOOP-15369) Avoid usage of ${project.version} in parent poms

2018-04-16 Thread Xiaoyu Yao (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-15369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439645#comment-16439645
 ] 

Xiaoyu Yao edited comment on HADOOP-15369 at 4/16/18 5:16 PM:
--

I agree that we need to document this. [~bharatviswa], the 
maven-enforcer-plugin message added with this patch already contains the 
information about new required variable {{hadoop.version}}.

[~elek], can you add the additional step as a followup to release to the hadoop 
wiki if this has not been added yet? 


was (Author: xyao):
I agree that we need to document this. [~bharatviswa], the 
maven-enforcer-plugin message added with this patch already contains the 
information about new required variable {{hadoop.version}}.

[~elek], can you add the additional step to release to the hadoop wiki if this 
has not been added yet? 

> Avoid usage of ${project.version} in parent poms
> 
>
> Key: HADOOP-15369
> URL: https://issues.apache.org/jira/browse/HADOOP-15369
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: build
>Affects Versions: 3.2.0
>Reporter: Elek, Marton
>Assignee: Elek, Marton
>Priority: Major
> Attachments: HADOOP-15369-trnk.001.patch
>
>
> hadoop-project/pom.xml and hadoop-project-dist/pom.xml use 
> _${project.version}_ variable in dependencyManagement and plugin dependencies.
> Unfortunatelly it could not work if we use different version in a child 
> project as ${project.version} variable is resolved *after* the inheritance.
> From [maven 
> doc|https://maven.apache.org/guides/introduction/introduction-to-the-pom.html#Project_Inheritance]:
> {quote}
> For example, to access the project.version variable, you would reference it 
> like so:
>   ${project.version}
> One factor to note is that these variables are processed after inheritance as 
> outlined above. This means that if a parent project uses a variable, then its 
> definition in the child, not the parent, will be the one eventually used.
> {quote}
> The community voted to keep ozone in-tree but use a different release cycle. 
> To achieve this we need different version for selected subproject therefor we 
> can't use ${project.version} any more. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Comment Edited] (HADOOP-15369) Avoid usage of ${project.version} in parent poms

2018-04-16 Thread Xiaoyu Yao (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-15369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439645#comment-16439645
 ] 

Xiaoyu Yao edited comment on HADOOP-15369 at 4/16/18 4:16 PM:
--

I agree that we need to document this. [~bharatviswa], the 
maven-enforcer-plugin message added with this patch already contains the 
information about new required variable {{hadoop.version}}.

[~elek], can you add the additional step to release to the hadoop wiki if this 
has not been added yet? 


was (Author: xyao):
I agree that we need to document this. [~bharatviswa], the 
maven-enforcer-plugin message already contains the information about the 
hadoop.version is required.

[~elek], can you add the additional step to release to the hadoop wiki if this 
has not been added yet? 

> Avoid usage of ${project.version} in parent poms
> 
>
> Key: HADOOP-15369
> URL: https://issues.apache.org/jira/browse/HADOOP-15369
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: build
>Affects Versions: 3.2.0
>Reporter: Elek, Marton
>Assignee: Elek, Marton
>Priority: Major
> Attachments: HADOOP-15369-trnk.001.patch
>
>
> hadoop-project/pom.xml and hadoop-project-dist/pom.xml use 
> _${project.version}_ variable in dependencyManagement and plugin dependencies.
> Unfortunatelly it could not work if we use different version in a child 
> project as ${project.version} variable is resolved *after* the inheritance.
> From [maven 
> doc|https://maven.apache.org/guides/introduction/introduction-to-the-pom.html#Project_Inheritance]:
> {quote}
> For example, to access the project.version variable, you would reference it 
> like so:
>   ${project.version}
> One factor to note is that these variables are processed after inheritance as 
> outlined above. This means that if a parent project uses a variable, then its 
> definition in the child, not the parent, will be the one eventually used.
> {quote}
> The community voted to keep ozone in-tree but use a different release cycle. 
> To achieve this we need different version for selected subproject therefor we 
> can't use ${project.version} any more. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Comment Edited] (HADOOP-15369) Avoid usage of ${project.version} in parent poms

2018-04-16 Thread Xiaoyu Yao (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-15369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439645#comment-16439645
 ] 

Xiaoyu Yao edited comment on HADOOP-15369 at 4/16/18 4:15 PM:
--

I agree that we need to document this. [~bharatviswa], the 
maven-enforcer-plugin message already contains the information about the 
hadoop.version is required.

[~elek], can you add the additional step to release to the hadoop wiki if this 
has not been added yet? 


was (Author: xyao):
I agree with [~bharatviswa] that we need to document this. [~elek] , can you 
add the additional step to release after this patch in the hadoop wiki if this 
has not been added yet? 

> Avoid usage of ${project.version} in parent poms
> 
>
> Key: HADOOP-15369
> URL: https://issues.apache.org/jira/browse/HADOOP-15369
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: build
>Affects Versions: 3.2.0
>Reporter: Elek, Marton
>Assignee: Elek, Marton
>Priority: Major
> Attachments: HADOOP-15369-trnk.001.patch
>
>
> hadoop-project/pom.xml and hadoop-project-dist/pom.xml use 
> _${project.version}_ variable in dependencyManagement and plugin dependencies.
> Unfortunatelly it could not work if we use different version in a child 
> project as ${project.version} variable is resolved *after* the inheritance.
> From [maven 
> doc|https://maven.apache.org/guides/introduction/introduction-to-the-pom.html#Project_Inheritance]:
> {quote}
> For example, to access the project.version variable, you would reference it 
> like so:
>   ${project.version}
> One factor to note is that these variables are processed after inheritance as 
> outlined above. This means that if a parent project uses a variable, then its 
> definition in the child, not the parent, will be the one eventually used.
> {quote}
> The community voted to keep ozone in-tree but use a different release cycle. 
> To achieve this we need different version for selected subproject therefor we 
> can't use ${project.version} any more. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org