[ https://issues.apache.org/jira/browse/HADOOP-16416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16908006#comment-16908006 ]
Gabor Bota edited comment on HADOOP-16416 at 8/15/19 11:28 AM: --------------------------------------------------------------- You forgot to add final to v003 patch. was (Author: gabor.bota): +1 on patch v003, even if checkstyle has it's own issues with this - I think {{final static}} should be uppercase. > mark DynamoDBMetadataStore.deleteTrackingValueMap as final > ---------------------------------------------------------- > > Key: HADOOP-16416 > URL: https://issues.apache.org/jira/browse/HADOOP-16416 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/s3 > Affects Versions: 3.2.0 > Reporter: Steve Loughran > Assignee: kevin su > Priority: Trivial > Attachments: HADOOP-16416.001.patch, HADOOP-16416.002.patch, > HADOOP-16416.003.patch > > > S3Guard's {{DynamoDBMetadataStore.deleteTrackingValueMap}} field is static > and can/should be marked as final; its name changed to upper case to match > the coding conventions. -- This message was sent by Atlassian JIRA (v7.6.14#76016) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org